From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-048.btinternet.com (mailomta2-re.btinternet.com [213.120.69.95]) by sourceware.org (Postfix) with ESMTPS id C95CF3858C00 for ; Sun, 18 Sep 2022 13:17:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C95CF3858C00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-048.btinternet.com with ESMTP id <20220918131726.GMDX3057.re-prd-fep-048.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Sun, 18 Sep 2022 14:17:26 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A8DE83A34AA7D X-Originating-IP: [81.153.98.187] X-OWM-Source-IP: 81.153.98.187 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvhedgieehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepffekiefgudejheetudeigfejledtleegleetkeduteeftdfffefhueefgfeutedtnecukfhppeekuddrudehfedrleekrddukeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddukeejpdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgtphhtthhopehpuhhrphhlvggrrhhmrgguihhllhhojeejsehprhhothhonhdrmhgv X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.187) by re-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A8DE83A34AA7D; Sun, 18 Sep 2022 14:17:26 +0100 Message-ID: <36e04564-451e-f569-4f08-6dd79901b87c@dronecode.org.uk> Date: Sun, 18 Sep 2022 14:17:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Cygport Bug: "find: No such file" Errors When Packaging Content-Language: en-GB To: William Hu , "cygwin-apps@cygwin.com" References: <9e4a2d4b-528e-f19f-048f-cc07f824c47a@dronecode.org.uk> <8mDrr73_tuJ35T8Yyn_WTxWpsSPecUSaqm6bGgkdd-8L0Ty4BVLJHjZD1X6yoVCSaKbzluKR5UXShhDTTy0C42Ata9HRD2nC_ZKdt3ndkJ4=@proton.me> From: Jon Turney In-Reply-To: <8mDrr73_tuJ35T8Yyn_WTxWpsSPecUSaqm6bGgkdd-8L0Ty4BVLJHjZD1X6yoVCSaKbzluKR5UXShhDTTy0C42Ata9HRD2nC_ZKdt3ndkJ4=@proton.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1192.1 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17/09/2022 22:14, William Hu via Cygwin-apps wrote: > Hi Jon, > >> I think just dropping ${mldir} would prevent cygport from detecting the >> dependencies of an ocaml library (other ocaml libraries, or ocaml >> itself?), but the second alternative sounds acceptable. >> >> Patches welcome, as always :) > > Thanks for the insight! Patch attached :) Thanks. This change is probably safe and does what you say, but it looks like it could potentially misbehave when ${mldir} doesn't exist, but ${D}/${mldir} does (a situation which probably can't occur, as it doesn't seem to make sense to build ocaml libraries when ocaml isn't installed?) In future, please try to use git-format-patch, if possible, as that saves me having to write patch commentary, and ensures correct patch attribution.