From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-047.btinternet.com (mailomta31-re.btinternet.com [213.120.69.124]) by sourceware.org (Postfix) with ESMTPS id 9F9383857B8D for ; Fri, 23 Sep 2022 14:45:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F9383857B8D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.54.6]) by re-prd-fep-047.btinternet.com with ESMTP id <20220923144513.UKLH3222.re-prd-fep-047.btinternet.com@re-prd-rgout-003.btmx-prd.synchronoss.net>; Fri, 23 Sep 2022 15:45:13 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 61A69BAC2F76E444 X-Originating-IP: [81.153.98.187] X-OWM-Source-IP: 81.153.98.187 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefiedgkedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeehudeuveeujeeujeegueefhedttdekvedtudeileefteetfeefjeejudekfefggfenucffohhmrghinheptgihghifihhnrdgtohhmnecukfhppeekuddrudehfedrleekrddukeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddukeejpdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepfedprhgtphhtthhopeevhhhrihhsthhirghnrdfhrhgrnhhkvgesthdqohhnlhhinhgvrdguvgdprhgtphhtthhopefuthhrohhmvghkohdqihegjehjihfvvgfmgifrkfesphhusghlihgtrdhgmhgrnhgvrdhorhhgpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhm X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.187) by re-prd-rgout-003.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 61A69BAC2F76E444; Fri, 23 Sep 2022 15:45:13 +0100 Message-ID: <395d4def-71a5-c144-710f-772e64e5e93b@dronecode.org.uk> Date: Fri, 23 Sep 2022 15:45:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [Bug] setup regression To: Achim Gratz , "cygwin-apps@cygwin.com" , Christian Franke References: <87leqcocft.fsf@Rainer.invalid> <87h710obeh.fsf@Rainer.invalid> <87tu4z5owu.fsf@Rainer.invalid> Content-Language: en-GB From: Jon Turney In-Reply-To: <87tu4z5owu.fsf@Rainer.invalid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3568.8 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/09/2022 17:56, Achim Gratz wrote: > Achim Gratz writes: >> Achim Gratz writes: >>> I had updated setup to 2.921 recently, so I rolled it back to 2.920 and >>> this version does the package selection correctly. I haven't yet looked >>> what commit is responsible, but whatever the cause of the regression is >>> still in 2.922 as well. >> >> The most likely change responsible for this is the additions in >> package_meta.cc in commit c99e4c14911181636892355a4f1855024051ea1d. I >> might not be able to check this tomorrow, though I'll try to free up >> some time for that. > > That was indeed the culprit. I've reverted just these two hunks on top > of release_2.922 and things worked again. > Yes, looking again at that change, the first hunk in package_meta.cc, changing Install_action doesn't look right. If I remember correctly action=Install_action, desired=empty package version (evaluating as a boolean is false) means "install the solver's preferred version", so converting that to NoChange_action seems wrong. I'm kind of confused how to reproduce this, or why it decided to install only some things, rather than nothing. Christian, From your reply to https://cygwin.com/pipermail/cygwin-apps/2022-August/042212.html, it seems this change is meant to handle the case where 'I' is pressed but the package isn't accessible? Although I don't seem quite how.