From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-049.btinternet.com (mailomta5-sa.btinternet.com [213.120.69.11]) by sourceware.org (Postfix) with ESMTPS id 067223858C78 for ; Mon, 27 May 2024 21:16:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 067223858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 067223858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716844596; cv=none; b=fQHQwwzq5MCmlCuAL+FOl6MTBJsRyCR3tc28/D6ThttZjU9bjM5lIQzEtMdwGjHqykew6wqalFMzqBiAT3vnXGTqfL156nMkYgG5p5N3meaOJ211g8bXJ2IocyC9ifK0ZhPRJHftnYNssBi0YTwLeyIAdqZ51hewvbDIszQXB/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716844596; c=relaxed/simple; bh=N1tBP9n36ywFRftq1vQgjXKfqophrXBGv7idqnfTup4=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=lryJjxPUHWrmAb4djs0T7/ly34bjVFmVB+TD3xpS3CdVQKnH+8dsuas5RDOOPKyY7i2VDOneY2/yiVpDASMzz3v1zbb26Uw/cPVR3m022jHaMvSNpirdWQZ0iPH11x6yj5QMOVKIyRNjVwcbCE+oQgf00Bd9k5Oe+NyFotEVyR8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from sa-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.38.6]) by sa-prd-fep-049.btinternet.com with ESMTP id <20240527211634.NYIP27949.sa-prd-fep-049.btinternet.com@sa-prd-rgout-003.btmx-prd.synchronoss.net>; Mon, 27 May 2024 22:16:34 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 65A5682A0F2BE2E9 X-Originating-IP: [86.139.167.83] X-OWM-Source-IP: 86.139.167.83 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvledrvdejgedgudehjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfevjggtgfesthejredttddvjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepfeeijeeitdetheehleethefggeffkeeukeefkeehgfevleehgfefveduffeitdejnecuffhomhgrihhnpegthihgfihinhdrtghomhdpghhithhhuhgsrdgtohhmnecukfhppeekiedrudefledrudeijedrkeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdelngdpihhnvghtpeekiedrudefledrudeijedrkeefpdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegsohholhgvrghnlhgrsggvlhesghhmrghilhdrtghomhdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgvvhfkrfephhhoshhtkeeiqddufeelqdduieejqdekfedrrhgrnhhgvgekiedqudefledrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgv hiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhsthepshgrqdhprhguqdhrghhouhhtqddttdef X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.109] (86.139.167.83) by sa-prd-rgout-003.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 65A5682A0F2BE2E9; Mon, 27 May 2024 22:16:34 +0100 Message-ID: <3bf9ed69-c9c7-41d8-bc66-e6599761f87c@dronecode.org.uk> Date: Mon, 27 May 2024 22:16:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH cygport] bin/cygport.in: Allow `-fdebug-prefix-map` to be selected instead of `-ffile-prefix-map` To: Daisuke Fujimura References: From: Jon Turney Content-Language: en-US Cc: cygwin-apps@cygwin.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25/05/2024 08:25, Daisuke Fujimura via Cygwin-apps wrote: > Having seen this commit ( > https://cygwin.com/git/?p=cygwin-apps/cygport.git;a=commit;h=9e82685e32f6717675e9f6bf55dd1336e3fc3831 > ), > I understand that this is problematic from a reproducibility point of > view, but I would like to be able to specify a `-fdebug-prefix-map` > because C sources with code like `#include __FILE__` cannot be > compiled. > > https://github.com/cygwin/scallywag/actions/runs/9002845391/job/24732313857#step:6:1302 > > ``` > /cygdrive/d/a/scallywag/ruby/ruby-3.3.1-1.x86_64/src/ruby-3.3.1/debug_counter.h:359:10: > fatal error: /usr/src/debug/ruby-3.3.1-1/debug_counter.h: No such file > or directory > 359 | #include __FILE__ > | ^~~~~~~~ > compilation terminated. > ``` > > The patch is as follows. Thanks very much for the patch. Yeah, I tripped over this when I was testing your previous patch. This seems like a generic problem which everyone is going to have with ruby, though. And from a brief look at the debug_counter.h header, it does seem like a case of excessive cleverness - on first glance, it looks like this could just be written using a separate header, rather than recursively including itself with some define set... (and I guess it's actually a gcc bug, or at least misfeature, that you can make '#include __FILE__' do something other than it's plain meaning) Nevertheless, I guess this is needed. > Shell variable names in the patch should be changed to appropriate ones. Yeah, not sure what a good name for this is. Something like 'DEBUGINFO_ONLY_DEBUG_PREFIX_MAP', maybe? It needs to be mentioned in the documentation somewhere, as well.