From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78369 invoked by alias); 13 Nov 2017 11:51:24 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 78358 invoked by uid 89); 13 Nov 2017 11:51:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Continue, downloaded, answers, Hx-spam-relays-external:ESMTPA X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Nov 2017 11:51:22 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 374A720D46; Mon, 13 Nov 2017 06:51:20 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Mon, 13 Nov 2017 06:51:20 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-162-230-154.range86-162.btcentralplus.com [86.162.230.154]) by mail.messagingengine.com (Postfix) with ESMTPA id B357C241BE; Mon, 13 Nov 2017 06:51:19 -0500 (EST) Subject: Re: [PATCH setup 0/5] Improve behavior after download error, v2 To: cygwin-apps@cygwin.com References: <20171110144339.12616-1-kbrown@cornell.edu> Cc: Ken Brown From: Jon Turney Message-ID: <3e22a9f8-7e09-64a6-d031-7655fe15a786@dronecode.org.uk> Date: Mon, 13 Nov 2017 11:51:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171110144339.12616-1-kbrown@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00045.txt.bz2 On 10/11/2017 14:43, Ken Brown wrote: > Currently setup goes back to the mirror selection page after a > download error if the user answers "Yes" to "Download incomplete. Try > again?". The same happens in unattended mode until the retries have > been exhausted. > > And if the user answers "No", then installation continues, even though > this can damage the user's installation. For example, if a package is > selected for reinstall but cannot be downloaded, it will be > uninstalled. > > This series of patches changes the behavior as follows: > > - In unattended mode, simply retry the download. > > - In interactive mode, pop up a dialog showing which packages had > download errors and giving the user the following options: > - Retry (retries download) > - Back (return to the package selection page) > - Continue, with a warning > - Cancel (exit) Thanks. This looks great. Please apply to master. > Ken Brown (5): > Just retry download after error in unattended mode > Fix off-by-one error in download retry report > Remove "Try again?" from exit message. > Query user after download error in interactive mode > Limit the number of packages shown in the IDD_DOWNLOAD_ERROR listbox You can drop this last one. I don't think you need to limit the list if we have a scrollable textbox to show it in. I was just pointing out that the list could be large, because I was assuming use of a MessageBox(), but you've sidestepped that since you are using a custom dialog.