From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68135 invoked by alias); 23 May 2016 13:54:04 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 68121 invoked by uid 89); 23 May 2016 13:54:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=schulman, sk:backwar, Schulman, humbly X-HELO: out2-smtp.messagingengine.com Received: from out2-smtp.messagingengine.com (HELO out2-smtp.messagingengine.com) (66.111.4.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 May 2016 13:53:53 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7E1432018A for ; Mon, 23 May 2016 09:53:51 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 23 May 2016 09:53:51 -0400 Received: from [192.168.1.102] (host86-141-130-112.range86-141.btcentralplus.com [86.141.130.112]) by mail.messagingengine.com (Postfix) with ESMTPA id 0218FF29EE for ; Mon, 23 May 2016 09:53:50 -0400 (EDT) Subject: Re: Building from source packages To: cygwin-apps@cygwin.com References: From: Jon Turney Message-ID: <3e344b98-1f87-18f2-6b69-4a8d2772ebcb@dronecode.org.uk> Date: Mon, 23 May 2016 13:54:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00096.txt.bz2 On 13/05/2016 20:44, Andrew Schulman wrote: >> * a few packages mistakenly use DEPENDS >> >> A few packages mistakenly use DEPENDS rather than DEPEND, which is >> silently ignored > > I'm surprised none of them are mine. It confuses me every time that I have to > use REQUIRES, but DEPEND instead of DEPENDS. I have to go look it up again once > or twice a month. > > To minimize the cognitive load on maintainers' brains, I humbly propose that > cygport honor both REQUIRE and REQUIRES, and DEPEND and DEPENDS. > > Or it that's too ugly, make them both of the same form, i.e. REQUIRE and DEPEND. > A one-time backwards-incompatible change that would make things easier in the > future. Yes, I get confused by it too, which is how I noticed this problem. But I'm not sure how to fix this. I wonder if it's possible to check the set of variables which exist after evaluating the cygport file, and warn if there are unexpected ones. (Any existing uses of temporary variables inside a cygport file would have to be unset before it exits to avoid warning about them, but that seems a fair price to pay...)