From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4202 invoked by alias); 27 Dec 2016 01:16:40 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 4186 invoked by uid 89); 27 Dec 2016 01:16:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.0 required=5.0 tests=BAYES_20,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*M:cygwin, NEVER, UD:gz, tarball X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Dec 2016 01:16:29 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32BBC4E4C7 for ; Tue, 27 Dec 2016 01:16:28 +0000 (UTC) Received: from [10.10.116.24] (ovpn-116-24.rdu2.redhat.com [10.10.116.24]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBR1GPSV004459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 26 Dec 2016 20:16:27 -0500 Subject: Re: [ITP] speexdsp-1.2rc3-1 To: cygwin-apps@cygwin.com References: <6fff2c5a-6908-4656-b814-8ee597882432@cygwin.com> <4b277a1d-787d-5af7-483f-55d131782687@acm.org> From: Yaakov Selkowitz Message-ID: <401881fe-ba62-8cdc-ea96-7b0508e77843@cygwin.com> Date: Tue, 27 Dec 2016 01:16:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <4b277a1d-787d-5af7-483f-55d131782687@acm.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00031.txt.bz2 On 2016-12-26 18:32, David Rothenberger wrote: > On 12/26/2016 12:55 PM, Yaakov Selkowitz wrote: >> This version does not come with the speexdsp library, which is now >> shipped separately upstream. This needs to be provided as well in order >> to not break packages which already use it. Are you able to ITP speexdsp? > > Sure, here you go. Thanks! A few nits: * Why a git snapshot instead of an official tarball? * A version number of "1.2rc3" may not sort properly with a future 1.2.0. Instead, drop all the git stuff and: VERSION=1.2 RELEASE=0.1.rc3 SRC_URI="http://downloads.xiph.org/releases/speex/speexdsp-${VERSION}${RELEASE##*.}.tar.gz" SRC_DIR="speexdsp-${VERSION}${RELEASE##*.}" * The following is problematic: libspeexdsp1_CONTENTS="usr/bin/*.dll" NEVER DO THIS. If the DLL ABI version number is changed upstream (either on purpose or by accident), you might miss it and end up packaging what should be libspeexdsp2 as libspeexdsp1, breaking existing installations. I have added this package under your name. Go ahead and upload with these fixes, and then I'll fix the dependencies of other packages accordingly. -- Yaakov