From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-045.btinternet.com (mailomta26-sa.btinternet.com [213.120.69.32]) by sourceware.org (Postfix) with ESMTPS id C819F3858CDB for ; Sun, 2 Apr 2023 17:39:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C819F3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-001.btmx-prd.synchronoss.net ([10.2.38.4]) by sa-prd-fep-045.btinternet.com with ESMTP id <20230402173951.WLWZ5235.sa-prd-fep-045.btinternet.com@sa-prd-rgout-001.btmx-prd.synchronoss.net>; Sun, 2 Apr 2023 18:39:51 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 64067D31032C10F0 X-Originating-IP: [86.140.195.75] X-OWM-Source-IP: 86.140.195.75 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeihedguddtkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeffkeeigfdujeehteduiefgjeeltdelgeelteekudetfedtffefhfeufefgueettdenucfkphepkeeirddugedtrdduleehrdejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkeeirddugedtrdduleehrdejhedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepufhtrhhomhgvkhhosehnvgigghhordguvgdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgvvhfkrfephhhoshhtkeeiqddugedtqdduleehqdejhedrrhgrnhhgvgekiedqudegtddrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhsthepshgr qdhprhguqdhrghhouhhtqddttddu X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (86.140.195.75) by sa-prd-rgout-001.btmx-prd.synchronoss.net (5.8.814) (authenticated as jonturney@btinternet.com) id 64067D31032C10F0; Sun, 2 Apr 2023 18:39:51 +0100 Message-ID: <427a2a31-26d1-7d0d-f90f-767546aac933@dronecode.org.uk> Date: Sun, 2 Apr 2023 18:39:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip Content-Language: en-GB To: "cygwin-apps@cygwin.com" , Achim Gratz References: <822a414c-be34-319e-c8d9-810cf7383e7e@dronecode.org.uk> <878rfec94o.fsf@Rainer.invalid> <197d05e2-2308-3a18-abbd-f6ced1c123aa@dronecode.org.uk> From: Jon Turney In-Reply-To: <197d05e2-2308-3a18-abbd-f6ced1c123aa@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1194.4 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30/03/2023 21:34, Jon Turney via Cygwin-apps wrote: > On 30/03/2023 20:49, Achim Gratz via Cygwin-apps wrote: >> Jon Turney via Cygwin-apps writes: >>> On 26/03/2023 19:12, Jon Turney via Cygwin-apps wrote: > Exchange the while loop using an iffy read construct to a for loop using a temporary file. I think this change from zero-delimited to whitespace means this will now fail to handle any filenames containing whitespace correctly? This commentary doesn't clearly identify what is wrong with the usage of read here. > avoid filename collisions by using an > SHA256 hash of the full file name. I think there is already a perfectly good, filesystem safe, computationally cheap unique identifier for each filename, which is it's ordinal number in the list of filenames we are examining. 'wait -f' seems to be new in bash 5.0. I assume this fails horribly on earlier bash versions. I'm ok with requiring that, but maybe we should check the bash version? On the plus side, the testsuite passes! :)