From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 32212386FC00 for ; Wed, 19 May 2021 17:24:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 32212386FC00 Received: by mail-wm1-x32c.google.com with SMTP id l11-20020a05600c4f0bb029017a7cd488f5so1110957wmq.0 for ; Wed, 19 May 2021 10:24:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UTHfWoHewt3XoQdxe19Dr7+zlQAFr7MVhWZwGOJktuE=; b=mQ6r1OSmzcJ0Lrqd/rNojGjnAck48vMdj68Yd0SvraSWNWiee0X+nFQLMicY+D2IfZ POOCCgQZqe6laHlqMeIYc6bzDgufam2SBeeW6fcelb8y39lAG1+rYR/vUGLYQBFgUn0d OEKy3/n3tiKJHh6HXhvoibsKEhl9ahjPLNpJKmLbCwmJ9oNCDk1PhEZtsdanUIDr/uuo /G94xi8Ou+1DvQZ6YAxV7O1QE3ujYXRh/DuRdYN5x5jTFpBdkkeMEcUp+TTU71sJXVCj Jl3v5Yy08AjNa7ZViUVqEK5tnDRMXpYqyoi25zNVju0KFOBg8klIU49gk+WeKyaqgjoV Js5w== X-Gm-Message-State: AOAM531uHLnqgz5+ETAMnXcKFYvajXlXZMlR9OgFeJCpm2zJC5VQ6U7Q rGAm/MOH44nO8tTSbZCC+/4ej85rqJJJ5g== X-Google-Smtp-Source: ABdhPJzglqXrZEanv1txsUIU1nTSnWNuWCD1ddvaUbR/KtIfcyVgcr8egfrHZB59rchjBrYR0wJBrg== X-Received: by 2002:a1c:7515:: with SMTP id o21mr12706096wmc.90.1621445057250; Wed, 19 May 2021 10:24:17 -0700 (PDT) Received: from ?IPv6:2003:cc:9f04:e34a:8ddd:bef9:a0af:3839? (p200300cc9f04e34a8dddbef9a0af3839.dip0.t-ipconnect.de. [2003:cc:9f04:e34a:8ddd:bef9:a0af:3839]) by smtp.gmail.com with ESMTPSA id f188sm6498818wmf.24.2021.05.19.10.24.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 10:24:16 -0700 (PDT) Subject: Re: cygport test has zero exit status on failures To: cygwin-apps@cygwin.com References: <01ad01d74517$f9f4e6e0$eddeb4a0$@pdinc.us> <87h7jbuqir.fsf@Otto.invalid> <009c01d74b6c$1ce8f7e0$56bae7a0$@pdinc.us> <8735ukejz2.fsf@Otto.invalid> <03dc01d74c1a$80c3df60$824b9e20$@pdinc.us> <87k0nvdcho.fsf@Rainer.invalid> <051901d74c28$58efeac0$0acfc040$@pdinc.us> <87y2cbcnhi.fsf@Otto.invalid> <50c37d50-1965-50cb-feb9-f386ab0b1374@gmail.com> <6d3701d74ccc$9ec1cf60$dc456e20$@pdinc.us> From: Marco Atzeri Message-ID: <4368ad4c-6b3e-07db-e88c-b66ba54fa906@gmail.com> Date: Wed, 19 May 2021 19:24:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <6d3701d74ccc$9ec1cf60$dc456e20$@pdinc.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: it Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 17:24:19 -0000 On 19.05.2021 18:32, Jason Pyeron wrote: >> -----Original Message----- >> From: Marco Atzeri >> Sent: Wednesday, May 19, 2021 3:06 AM >> >> On 19.05.2021 07:16, ASSI wrote: >>> Jason Pyeron writes: >> >>> >>> cygport $p finish prep compile inst test pkg > > So for the pdfgrep that I am going to maintain, is it acceptable that I want the package to not happen until I address the test failure? Like so? you are the maintainer, it is your decision. We just give you our opinion based on our experience > ... > BUILD_REQUIRES="asciidoc gcc-g++ libpoppler-cpp-devel libgcrypt-devel libpcre-devel dejagnu texlive-collection-latex docbook-xml45" > > src_test() { > cd ${B} > make check > } This is the default. >> in general a generic test failure is not a valid reason to NOT package. >> Most of my packages have peculiar test failures that can be just ignored >> >> In several, I just use "cygmake -i check" in src_test >> to avoid premature stop of the tests. >> >> Others requires to be installed before the testsuite is >> properly executed. > > Since it is not required to be installed, I would like to lean towards stopping to fix first. The 1.4.1 seems fine. Or I am missing something ? > > v/r, > > Jason > Regards Marco