public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Brian Inglis <Brian.Inglis@Shaw.ca>
To: cygwin-apps@cygwin.com
Subject: Re: untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'
Date: Sat, 21 Jan 2023 23:34:54 -0700	[thread overview]
Message-ID: <440772b0-257a-9302-dfcd-dd53f73a92c7@Shaw.ca> (raw)
In-Reply-To: <8bf94b1a-3711-b648-e495-bfd319aee293@Shaw.ca>

On 2023-01-21 16:57, Brian Inglis via Cygwin-apps wrote:
> $ ssh cygwin untest dash-0.5.12-1
> Traceback (most recent call last):
>    File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
>      "__main__", mod_spec)
>    File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
>      exec(code, run_globals)
>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 83, in <module>
>      sys.exit(main())
>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 79, in main
>      untest(p)
>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 39, in untest
>      if not tool_util.permitted(p):
>    File "/sourceware/cygwin-staging/calm/calm/tool_util.py", line 50, in permitted
>      mlist = maintainers.add_packages(mlist, common_constants.PKGMAINT, 
> trustedMaint=common_constants.TRUSTEDMAINT)
> TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'

Allowed keyword arguments were only orphanMaint and prev_maint:

$ grep -H add_packages /usr/lib/python3.?/site-packages/**/maintainers*
/usr/lib/python3.9/site-packages/calm/maintainers.py:def add_packages(mlist, 
pkglist, orphanMaint=None, prev_maint=True):
/usr/lib/python3.9/site-packages/calm/maintainers.py:    mlist = 
add_packages(mlist, args.pkglist, orphanmaint, prev_maint)

Commit ad6b47c27b1113abacdfebf7234d38b6524606cd

https://cygwin.com/git/?p=cygwin-apps/calm.git;a=commitdiff;h=ad6b47c27b1113abacdfebf7234d38b6524606cd

removes orphanMaint but does not add trustedMaint in def:

https://cygwin.com/git/?p=cygwin-apps%2Fcalm.git&a=search&h=HEAD&st=grep&s=add_packages

calm/maintainers.py	
  139 def add_packages(mlist, pkglist, prev_maint=True):
  201     mlist = add_packages(mlist, args.pkglist, prev_maint)
calm/mkgitoliteconf.py	
   54     mlist = maintainers.add_packages(mlist, args.pkglist)
calm/package.py	
1091     mlist = maintainers.add_packages(mlist, args.pkglist)
calm/tool_util.py	
   50     mlist = maintainers.add_packages(mlist, common_constants.PKGMAINT, 
trustedMaint=common_constants.TRUSTEDMAINT)
test/test_calm.py	
  322         mlist = maintainers.add_packages(mlist, 
'testdata/pkglist/cygwin-pkg-maint')

Newer version not pushed, built, or installed on site?

-- 
Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry

  reply	other threads:[~2023-01-22  6:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-21 23:57 Brian Inglis
2023-01-22  6:34 ` Brian Inglis [this message]
2023-01-22 10:59   ` Jon Turney
2023-01-22 18:46     ` Brian Inglis
2023-01-22 22:01       ` Brian Inglis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440772b0-257a-9302-dfcd-dd53f73a92c7@Shaw.ca \
    --to=brian.inglis@shaw.ca \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).