From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114963 invoked by alias); 23 May 2016 13:44:35 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 113997 invoked by uid 89); 23 May 2016 13:44:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*F:D*org.uk, H*RU:sk:host86-, Hx-spam-relays-external:sk:host86-, H*r:sk:host86- X-HELO: out2-smtp.messagingengine.com Received: from out2-smtp.messagingengine.com (HELO out2-smtp.messagingengine.com) (66.111.4.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 May 2016 13:44:23 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0B8E320411; Mon, 23 May 2016 09:44:21 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 23 May 2016 09:44:21 -0400 Received: from [192.168.1.102] (host86-141-130-112.range86-141.btcentralplus.com [86.141.130.112]) by mail.messagingengine.com (Postfix) with ESMTPA id 4CBDDF29EE; Mon, 23 May 2016 09:44:20 -0400 (EDT) Subject: Re: [PATCH] Do not clear the prev, curr and exp fields of packagemeta. Never. References: <510b310a3f4f5a19abf1349216f013b3@xs4all.nl> Cc: Houder To: cygwin-apps@cygwin.com From: Jon Turney Message-ID: <44110727-fec0-caba-84f5-5e4908ee13dc@dronecode.org.uk> Date: Mon, 23 May 2016 13:44:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <510b310a3f4f5a19abf1349216f013b3@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00095.txt.bz2 On 04/05/2016 13:38, Houder wrote: > Please, submit this patch. Thanks for the patch. > This patch rectifies > > - packagemeta::ScanDownloadedFiles (package_meta.cc), and > - packagemeta::trustp (package_meta.h) > > Clarification: > Class packagemeta has "fields" prev, curr, exp and installed, which in fact > represent the info from setup.ini/installed.db, and should never be cleared > therefore. _Currently_ these fields are cleared in ScanDownloadedFiles() in > order to notify that the tarball for the associated field is not available. > This is a mistake, as it destroys relevant info (e.g. the version number of > a version). > To ascertain whether or not the associated tarball is available, one should > invoke .accesible(). Can you clarify a bit about the problem that this patch solves? And how you tested that it fixes it?