From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106893 invoked by alias); 20 Oct 2017 11:08:13 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 106324 invoked by uid 89); 20 Oct 2017 11:08:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:id X-HELO: limerock04.mail.cornell.edu Received: from limerock04.mail.cornell.edu (HELO limerock04.mail.cornell.edu) (128.84.13.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Oct 2017 11:08:10 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v9KB88OL011174 for ; Fri, 20 Oct 2017 07:08:08 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v9KB86Qh009319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 20 Oct 2017 07:08:07 -0400 Subject: Re: [PATCH] Revert "Don't override a Keep selection" To: cygwin-apps@cygwin.com References: <20171016191321.9504-1-kbrown@cornell.edu> <66510301-7c57-ac6c-9e4c-05cf5816d3a9@cornell.edu> <46f9afd9-03fb-b07c-de0e-22dd0586b153@cornell.edu> <63bf8a45-0661-7045-3dce-15c554e8248b@cornell.edu> <956a35ef-e577-a0ef-a758-f920b73a30eb@cornell.edu> From: Ken Brown Message-ID: <45147a59-77fb-7dce-723f-df356f722cc8@cornell.edu> Date: Fri, 20 Oct 2017 11:08:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <956a35ef-e577-a0ef-a758-f920b73a30eb@cornell.edu> Content-Type: multipart/mixed; boundary="------------E4BD4346331668643BC301B5" X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00091.txt.bz2 This is a multi-part message in MIME format. --------------E4BD4346331668643BC301B5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 357 On 10/19/2017 5:36 PM, Ken Brown wrote: > Here's a related question.  Currently if libsolv decides I should > install something and I choose Skip instead, it will get installed > anyway (with no problem report).  Maybe we should have a taskSkip that > generates a SOLVER_LOCK in that case, analogous to taskKeep? A patch to do that is attached. Ken --------------E4BD4346331668643BC301B5 Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-override-a-Skip-selection.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Don-t-override-a-Skip-selection.patch" Content-length: 4636 RnJvbSBhMTUzMzRhZjE3NmE0NDUyZWY2ZWVmOGQ0MmE0ZGUzNjQ4ZWQ4YjU0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGti cm93bkBjb3JuZWxsLmVkdT4KRGF0ZTogRnJpLCAyMCBPY3QgMjAxNyAwNjo1 OTo1NCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIERvbid0IG92ZXJyaWRlIGEg U2tpcCBzZWxlY3Rpb24KCkludHJvZHVjZSBTb2x2ZXJUYXNrczo6dGFza1Nr aXAsIGFuZCBnZW5lcmF0ZSBpdCB3aGVuIHRoZSB1c2VyIGNob29zZXMKdG8g U2tpcCBhIHBhY2thZ2UgdGhhdCB0aGUgc29sdmVyIHdhbnRzIHRvIGluc3Rh bGwuICBJbXBsZW1lbnQgaXQgYnkKc2VuZGluZyBhIFNPTFZFUl9MT0NLIGNv bW1hbmQgb24gdGhlIHBhY2thZ2UgbmFtZS4KLS0tCiBjaG9vc2UuY2MgIHwg IDIgKy0KIGxpYnNvbHYuY2MgfCAyMCArKysrKysrKysrKysrKystLS0tLQog bGlic29sdi5oICB8ICAyICsrCiAzIGZpbGVzIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY2hvb3Nl LmNjIGIvY2hvb3NlLmNjCmluZGV4IGFkMzc2MzkuLjJhNzc3NGQgMTAwNjQ0 Ci0tLSBhL2Nob29zZS5jYworKysgYi9jaG9vc2UuY2MKQEAgLTQyMCw3ICs0 MjAsNyBAQCBDaG9vc2VyUGFnZTo6Y2hhbmdlVHJ1c3QoaW50IGJ1dHRvbiwg Ym9vbCB0ZXN0LCBib29sIGluaXRpYWwpCiAgICAgewogICAgICAgLy8gYnV0 IGluaXRpYWxseSB3ZSB3YW50IGEgdGFzayBsaXN0IHdpdGggYW55IHBhY2th Z2UgY2hhbmdlcyBjYXVzZWQgYnkKICAgICAgIC8vIGNvbW1hbmQgbGluZSBv cHRpb25zCi0gICAgICAvLyBhbmQgd2UgZG9uJ3Qgd2FudCB0byBnZW5lcmF0 ZSBzcHVyaW91cyBLZWVwIHRhc2tzCisgICAgICAvLyBhbmQgd2UgZG9uJ3Qg d2FudCB0byBnZW5lcmF0ZSBzcHVyaW91cyB0YXNrS2VlcCBvciB0YXNrU2tp cCB0YXNrcwogICAgICAgZm9yIChwYWNrYWdlZGI6OnBhY2thZ2Vjb2xsZWN0 aW9uOjppdGVyYXRvciBwID0gZGIucGFja2FnZXMuYmVnaW4gKCk7CiAJICAg cCAhPSBkYi5wYWNrYWdlcy5lbmQgKCk7ICsrcCkKIAl7CmRpZmYgLS1naXQg YS9saWJzb2x2LmNjIGIvbGlic29sdi5jYwppbmRleCBlNjIzNTU1Li4yYTM3 YTkyIDEwMDY0NAotLS0gYS9saWJzb2x2LmNjCisrKyBiL2xpYnNvbHYuY2MK QEAgLTcyLDEzICs3MiwxOSBAQCBSZWxJZDJPcGVyYXRvcihJZCBpZCkKIC8v IGEgd3JhcHBlciBhcm91bmQgYSBsaWJzb2x2IFNvbHZhYmxlCiAvLyAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAorSWQKK1NvbHZhYmxlVmVy c2lvbjo6bmFtZV9pZCAoKSBjb25zdAoreworICBTb2x2YWJsZSAqc29sdmFi bGUgPSBwb29sX2lkMnNvbHZhYmxlKHBvb2wsIGlkKTsKKyAgcmV0dXJuIHNv bHZhYmxlLT5uYW1lOworfQorCiBjb25zdCBzdGQ6OnN0cmluZwogU29sdmFi bGVWZXJzaW9uOjpOYW1lICgpIGNvbnN0CiB7CiAgIGlmICghaWQpCiAgICAg cmV0dXJuICIiOwotICBTb2x2YWJsZSAqc29sdmFibGUgPSBwb29sX2lkMnNv bHZhYmxlKHBvb2wsIGlkKTsKLSAgcmV0dXJuIHN0ZDo6c3RyaW5nKHBvb2xf aWQyc3RyKHBvb2wsIHNvbHZhYmxlLT5uYW1lKSk7CisgIHJldHVybiBwb29s X2lkMnN0cihwb29sLCBuYW1lX2lkKCkpOwogfQogCiBjb25zdCBzdGQ6OnN0 cmluZwpAQCAtNTI1LDkgKzUzMSw4IEBAIFNvbHZlclRhc2tzOjpzZXRUYXNr cygpCiAgICAgICBwYWNrYWdlbWV0YSAqcGtnID0gcC0+c2Vjb25kOwogCiAg ICAgICAvLyBkZWNvZGUgVUkgc3RhdGUgdG8gYWN0aW9uCi0gICAgICAvLyBz a2lwIGFuZCBrZWVwIGRvbid0IGNoYW5nZSBkZXBlbmRlbmN5IHNvbHV0aW9u Ci0gICAgICAvLyBleGNlcHQgd2hlbiB3ZSB3YW50IHRvIGtlZXAgYSB2ZXJz aW9uIGRpZmZlcmVudCBmcm9tIHRoZSBvbmUKLSAgICAgIC8vIGNob3NlbiBi eSB0aGUgc29sdmVyCisgICAgICAvLyBrZWVwIGFuZCBza2lwIG5lZWQgYXR0 ZW50aW9uIG9ubHkgd2hlbiB0aGV5IGRpZmZlciBmcm9tIHRoZQorICAgICAg Ly8gc29sdmVyJ3Mgc29sdXRpb24KICAgICAgIGlmIChwa2ctPmluc3RhbGxl ZCAhPSBwa2ctPmRlc2lyZWQpCiAgICAgICAgIHsKICAgICAgICAgICBpZiAo cGtnLT5kZXNpcmVkKQpAQCAtNTQyLDYgKzU0Nyw5IEBAIFNvbHZlclRhc2tz OjpzZXRUYXNrcygpCiAJICBlbHNlIGlmIChwa2ctPmluc3RhbGxlZCAhPSBw a2ctPmRlZmF1bHRfdmVyc2lvbikKIAkgICAgYWRkKHBrZy0+aW5zdGFsbGVk LCB0YXNrS2VlcCk7IC8vIGtlZXAKIAl9CisgICAgICBlbHNlIGlmIChwa2ct PmRlZmF1bHRfdmVyc2lvbikKKwlhZGQocGtnLT5kZWZhdWx0X3ZlcnNpb24s IHRhc2tTa2lwKTsgLy8gc2tpcAorCiAgICAgICAvLyBvbmx5IGluc3RhbGwg YWN0aW9uIG1ha2VzIHNlbnNlIGZvciBzb3VyY2UgcGFja2FnZXMKICAgICAg IGlmIChwa2ctPnNyY3BpY2tlZCgpKQogICAgICAgICB7CkBAIC03MTQsNiAr NzIyLDggQEAgU29sdmVyU29sdXRpb246OnVwZGF0ZShTb2x2ZXJUYXNrcyAm dGFza3MsIHVwZGF0ZU1vZGUgdXBkYXRlLCBib29sIHVzZV90ZXN0X3BhY2sK IAljYXNlIFNvbHZlclRhc2tzOjp0YXNrS2VlcDoKIAkgIHF1ZXVlX3B1c2gy KCZqb2IsIFNPTFZFUl9MT0NLIHwgU09MVkVSX1NPTFZBQkxFLCBzdi5pZCk7 CiAJICBicmVhazsKKwljYXNlIFNvbHZlclRhc2tzOjp0YXNrU2tpcDoKKwkg IHF1ZXVlX3B1c2gyKCZqb2IsIFNPTFZFUl9MT0NLIHwgU09MVkVSX1NPTFZB QkxFX05BTUUsIHN2Lm5hbWVfaWQoKSk7CiAgICAgICAgIGRlZmF1bHQ6CiAg ICAgICAgICAgTG9nIChMT0dfUExBSU4pIDw8ICJ1bmtub3duIHRhc2sgIiA8 PCAoKmkpLnNlY29uZCA8PCBlbmRMb2c7CiAgICAgICAgIH0KZGlmZiAtLWdp dCBhL2xpYnNvbHYuaCBiL2xpYnNvbHYuaAppbmRleCBlNDQ4ODQxLi42NWUx NjEwIDEwMDY0NAotLS0gYS9saWJzb2x2LmgKKysrIGIvbGlic29sdi5oCkBA IC05Nyw2ICs5Nyw3IEBAIGNsYXNzIFNvbHZhYmxlVmVyc2lvbgogICBmcmll bmQgU29sdmVyU29sdXRpb247CiAKICAgY29uc3QgUGFja2FnZURlcGVuZHMg ZGVwbGlzdChJZCBrZXluYW1lKSBjb25zdDsKKyAgSWQgbmFtZV9pZCAoKSBj b25zdDsKIH07CiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQpAQCAtMTgzLDYgKzE4NCw3IEBAIGNsYXNzIFNvbHZlclRhc2tzCiAgICAg dGFza1VuaW5zdGFsbCwKICAgICB0YXNrUmVpbnN0YWxsLAogICAgIHRhc2tL ZWVwLAorICAgIHRhc2tTa2lwLAogICB9OwogICB2b2lkIGFkZChjb25zdCBT b2x2YWJsZVZlcnNpb24gJnYsIHRhc2sgdCkKICAgewotLSAKMi4xNC4yCgo= --------------E4BD4346331668643BC301B5--