From: Jon Turney <jon.turney@dronecode.org.uk>
To: Achim Gratz <Stromeko@nexgo.de>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: cygport
Date: Thu, 15 Sep 2022 18:45:24 +0100 [thread overview]
Message-ID: <45dd81c8-16fd-d34e-15ab-855727cbbc07@dronecode.org.uk> (raw)
In-Reply-To: <87tueb8nry.fsf@Rainer.invalid>
On 10/01/2022 18:10, Achim Gratz wrote:
>
> I've rebased the remaining patches on my to-upstream branch onto the
> current release of cygport:
>
> https://repo.or.cz/cygport/rpm-style.git/shortlog/refs/heads/to-upstream
>
> Note that some of these are required to correctly build and distribute
> Perl and its modules for Cygwin (which is one reason I carry these for
> several years now).
I'm not keen on reviewing patches supplied that way, but ok...
> 5bc72c1 lib/pkg_pkg: allow suppression of spurious package dependencies
As far as I recall, previous discussion of this petered out with "please
give a concrete example where the dependency autodetection is wrong, and
explain why it can't be fixed".
If I'm misremembering, please point that out.
The new variable this introduces needs documenting.
> f5764cf lib/pkg_info.cygport: implement automatic determination of the appropriate perl5_0xy requirement
This looks like a fix for the previous commit, mixed in with some rebase
detritus.
> f1fdfb4 lib/src_prep.cygpart: process various checksum digests
The change to cygpatch to allow .xz and .zst compressed patches needs
breaking out as a separate change. That should also improve the
documentation of PATCH_URI to mention that it handles compressed patch
files transparently.
This needs a documentation change to mention when prep will verify
checksums.
It seems that __chksum_verify() ignores the result of running *sum. Why?
Ideally, a test should be added or extended to exercise this.
> 63e00e5 lib/src_prep.cygpart: determine and deal correctly with another type of checksum
This should be combined with the previous patch?
> 8a325c5 bin/cygport.in: make system-wide defaults overrideable by user defaults and provide ability to change initial MAKEOPTS via CYGPORT_MAKEOPTS
This seems to be two separate changes.
The documentation for cygport.conf should be updated to reflect that
~/.cygport.conf overrides /etc/cygport.conf.
What it the use case for being able to override MAKEOPTS with a
environment variable?
CYGPORT_MAKEOPTS needs documenting.
> 74935d6 bin/cygport.in, lib/help.cygpart: implement --jobs/-j N option to specify number of jobs to use
This seems to contain part of the previous change, removing the break
when looping over config files.
Why do we need both -j and CYGPORT_MAKEOPTS?
> 7777191 allow for different package compression types and implement ZStandard decompression
The change to unpack .tar.zst or .zst sources needs to be separate.
Ideally, a test should be added or extended to exercise that.
If the intention is to set CYGPORT_TAR_EXT and CYGPORT_TAR_CMD in the
cygport, I don't think they need the CYGPORT_ prefix.
These variables need documenting.
This seems like a weird implementation to me. Why can't cygport set
TAR_CMD to invoke tar with the appropriate compression option, depending
on what TAR_EXT is set to?
> 34502d2 (stromenko/to-upstream) lib/src_install.cygpart: make_etc_defaults, create diff if files aren't matching
This seems kind of useful, but what's the reasoning behind saving a diff
vs. just saving a backup copy of the previous file?
The documentation for make_etc_defaults should mention this behaviour.
next prev parent reply other threads:[~2022-09-15 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 18:10 cygport Achim Gratz
2022-03-14 19:06 ` cygport Jon Turney
2022-03-14 20:12 ` cygport Achim Gratz
2022-03-14 20:50 ` cygport Jon Turney
2022-03-27 13:22 ` cygport Achim Gratz
2022-04-10 18:44 ` cygport Jon Turney
2022-04-10 18:57 ` cygport Achim Gratz
2022-09-15 17:45 ` Jon Turney [this message]
2022-09-15 19:34 ` cygport Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45dd81c8-16fd-d34e-15ab-855727cbbc07@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=Stromeko@nexgo.de \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).