From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-048.btinternet.com (mailomta13-sa.btinternet.com [213.120.69.19]) by sourceware.org (Postfix) with ESMTPS id DB6233839DF3 for ; Thu, 15 Sep 2022 17:45:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB6233839DF3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-048.btinternet.com with ESMTP id <20220915174525.SONX3226.sa-prd-fep-048.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Thu, 15 Sep 2022 18:45:25 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139452E3A90D08A X-Originating-IP: [81.153.98.219] X-OWM-Source-IP: 81.153.98.219 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedguddulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfhuffvfhgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeeuveehhfevjeehgeduhfegueduudffheekteelleefkefhhfdtteeiudelhfegieenucffohhmrghinhepohhrrdgtiienucfkphepkedurdduheefrdelkedrvdduleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrvdduledpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepufhtrhhomhgvkhhosehnvgigghhordguvgdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomh X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.219) by sa-prd-rgout-005.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139452E3A90D08A; Thu, 15 Sep 2022 18:45:25 +0100 Message-ID: <45dd81c8-16fd-d34e-15ab-855727cbbc07@dronecode.org.uk> Date: Thu, 15 Sep 2022 18:45:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Jon Turney Subject: Re: cygport To: Achim Gratz , "cygwin-apps@cygwin.com" References: <87tueb8nry.fsf@Rainer.invalid> Content-Language: en-GB In-Reply-To: <87tueb8nry.fsf@Rainer.invalid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3569.7 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/01/2022 18:10, Achim Gratz wrote: > > I've rebased the remaining patches on my to-upstream branch onto the > current release of cygport: > > https://repo.or.cz/cygport/rpm-style.git/shortlog/refs/heads/to-upstream > > Note that some of these are required to correctly build and distribute > Perl and its modules for Cygwin (which is one reason I carry these for > several years now). I'm not keen on reviewing patches supplied that way, but ok... > 5bc72c1 lib/pkg_pkg: allow suppression of spurious package dependencies As far as I recall, previous discussion of this petered out with "please give a concrete example where the dependency autodetection is wrong, and explain why it can't be fixed". If I'm misremembering, please point that out. The new variable this introduces needs documenting. > f5764cf lib/pkg_info.cygport: implement automatic determination of the appropriate perl5_0xy requirement This looks like a fix for the previous commit, mixed in with some rebase detritus. > f1fdfb4 lib/src_prep.cygpart: process various checksum digests The change to cygpatch to allow .xz and .zst compressed patches needs breaking out as a separate change. That should also improve the documentation of PATCH_URI to mention that it handles compressed patch files transparently. This needs a documentation change to mention when prep will verify checksums. It seems that __chksum_verify() ignores the result of running *sum. Why? Ideally, a test should be added or extended to exercise this. > 63e00e5 lib/src_prep.cygpart: determine and deal correctly with another type of checksum This should be combined with the previous patch? > 8a325c5 bin/cygport.in: make system-wide defaults overrideable by user defaults and provide ability to change initial MAKEOPTS via CYGPORT_MAKEOPTS This seems to be two separate changes. The documentation for cygport.conf should be updated to reflect that ~/.cygport.conf overrides /etc/cygport.conf. What it the use case for being able to override MAKEOPTS with a environment variable? CYGPORT_MAKEOPTS needs documenting. > 74935d6 bin/cygport.in, lib/help.cygpart: implement --jobs/-j N option to specify number of jobs to use This seems to contain part of the previous change, removing the break when looping over config files. Why do we need both -j and CYGPORT_MAKEOPTS? > 7777191 allow for different package compression types and implement ZStandard decompression The change to unpack .tar.zst or .zst sources needs to be separate. Ideally, a test should be added or extended to exercise that. If the intention is to set CYGPORT_TAR_EXT and CYGPORT_TAR_CMD in the cygport, I don't think they need the CYGPORT_ prefix. These variables need documenting. This seems like a weird implementation to me. Why can't cygport set TAR_CMD to invoke tar with the appropriate compression option, depending on what TAR_EXT is set to? > 34502d2 (stromenko/to-upstream) lib/src_install.cygpart: make_etc_defaults, create diff if files aren't matching This seems kind of useful, but what's the reasoning behind saving a diff vs. just saving a backup copy of the previous file? The documentation for make_etc_defaults should mention this behaviour.