public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: "Yaakov (Cygwin Ports)" <yselkowitz@users.sourceforge.net>
To: cygwin-apps@cygwin.com
Subject: Re: cygport-0.9.0 in release-2
Date: Mon, 25 Aug 2008 16:02:00 -0000	[thread overview]
Message-ID: <48B2D751.3060405@users.sourceforge.net> (raw)
In-Reply-To: <48B2D521.6050603@users.sourceforge.net>

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Yaakov (Cygwin Ports) wrote:
> I rebuilt and tested the X11R7 lndir on 1.7, and unfortunately it seems
> to have the same bug.  I would prefer to fix lndir and just use it
> exclusively then trying to deal with the workaround.  Could you take a
> look at the source (only one .c file) and see if you can help me figure
> it out?
> 
> http://ftp.sunsite.dk/projects/cygwinports/release/X11/lndir/lndir-1.0.1-1-src.tar.bz2

Based on the description of your problem, what about the attached patch?
 Your test case then works, but:

1) I have no idea what other side effects this may have;
2) Why does Cygwin act differently then every other *NIX here?
3) How many other packages is this behaviour going to affect?


Yaakov
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEAREIAAYFAkiy11EACgkQpiWmPGlmQSMjTACg36bx0b+epZXfFlb3F0GSCvgg
tz0AoJq8EeT9r4YjWkTTfLrO4255RPSe
=O57a
-----END PGP SIGNATURE-----

[-- Attachment #2: lndir-1.0.1-1.src.patch --]
[-- Type: text/x-patch, Size: 400 bytes --]

--- origsrc/lndir-1.0.1/lndir.c	2005-11-23 16:33:07.000000000 -0600
+++ src/lndir-1.0.1/lndir.c	2008-08-25 10:55:14.270794700 -0500
@@ -205,8 +205,10 @@
 	    if ((sb.st_mode & S_IFMT) == S_IFDIR)
 #endif
 	    {
+#ifndef __CYGWIN__
 		/* directory */
 		n_dirs--;
+#endif
 		if (dp->d_name[0] == '.' &&
 		    (dp->d_name[1] == '\0' || (dp->d_name[1] == '.' &&
 					       dp->d_name[2] == '\0')))

  reply	other threads:[~2008-08-25 16:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-24  7:10 Yaakov (Cygwin Ports)
2008-08-25 12:06 ` Eric Blake
2008-08-25 15:53   ` Yaakov (Cygwin Ports)
2008-08-25 16:02     ` Yaakov (Cygwin Ports) [this message]
2008-08-25 17:22       ` Yaakov (Cygwin Ports)
2008-08-27  3:14 ` Yaakov (Cygwin Ports)
2008-08-28  5:16   ` Reini Urban
2008-08-29  0:27     ` Yaakov (Cygwin Ports)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B2D751.3060405@users.sourceforge.net \
    --to=yselkowitz@users.sourceforge.net \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).