From: Ralph Hempel <rhempel@bmts.com>
To: cygwin-apps@cygwin.com, cygwin-apps@cygwin.com
Subject: Re: [PATCH] Setup 1.7 command line install/download in setup.exe
Date: Thu, 11 Dec 2008 01:49:00 -0000 [thread overview]
Message-ID: <49407162.70809@bmts.com> (raw)
In-Reply-To: <20081208104218.GB13860@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
Corinna Vinschen wrote:
> On Dec 5 11:24, Ralph Hempel wrote:
>> Some time ago, I mentioned on this list that the -D -L command
>> line options for setup.exe (1.7) don't operate quite the same as the
>> radio buttons on the setup dialog.
>> [...]
>
> The patch misses a ChangeLog entry...
OK, here's the patch and the changelog...
Ralph
[-- Attachment #2: setup-downloadinstall.changelog --]
[-- Type: text/plain, Size: 91 bytes --]
2008-09-03 Ralph Hempel
* source.cc: Add support for both -D and -L on command line
[-- Attachment #3: setup-downloadinstall.diff --]
[-- Type: text/x-diff, Size: 385 bytes --]
--- setup-clean/source.cc 2008-08-12 16:32:08.000000000 -0400
+++ setup/source.cc 2008-09-03 09:29:28.593750000 -0400
@@ -86,7 +86,9 @@
void
SourcePage::OnActivate ()
{
- if (DownloadOption)
+ if (DownloadOption && LocalOption)
+ source = IDC_SOURCE_NETINST;
+ else if (DownloadOption)
source = IDC_SOURCE_DOWNLOAD;
else if (LocalOption)
source = IDC_SOURCE_CWD;
next prev parent reply other threads:[~2008-12-11 1:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 13:40 Patch for " Ralph Hempel
2008-09-03 13:44 ` Ralph Hempel
2008-09-18 14:49 ` Ralph Hempel
2008-12-05 16:25 ` [PATCH] Setup 1.7 " Ralph Hempel
2008-12-08 10:41 ` Corinna Vinschen
2008-12-08 12:46 ` Ralph Hempel
2008-12-11 1:49 ` Ralph Hempel [this message]
2008-12-11 2:55 ` Christopher Faylor
2008-12-11 3:07 ` Christopher Faylor
2008-12-11 8:25 ` Ralph Hempel
2008-12-11 18:36 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49407162.70809@bmts.com \
--to=rhempel@bmts.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).