From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps <cygwin-apps@cygwin.com>
Subject: [setup topic/libsolv] Crash after incomplete download
Date: Wed, 01 Nov 2017 20:38:00 -0000 [thread overview]
Message-ID: <4966bc07-8a00-3324-6b6f-4da2213e974c@cornell.edu> (raw)
If there is a download failure and the user clicks Yes in response to
"Download Incomplete. Try again?", then setup will crash. The crash
occurs at PickView.cc:447 because i->source() is NULL.
I haven't yet analyzed this in further detail, but the crux of the issue
seems to be that we call do_ini_thread a second time without having
cleaned out the package database and the libsolv pool.
This is probably a symptom of a more general problem, which is that we
haven't thought carefully (or at least I haven't) about what happens
when we visit certain pages for a second time, after the libsolv pool
has been created.
Before I work further on this, I have a UI question. Is it really
reasonable that we go back to the mirror selection page after "Download
incomplete"? I understand the rationale, which is that the user might
want to try a different mirror after a download failure. But I
personally have always found this annoying. I would rather just retry
the download, which is what the message ("Download Incomplete. Try
again?") suggests is going to happen.
Ken
next reply other threads:[~2017-11-01 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 20:38 Ken Brown [this message]
2017-11-02 17:22 ` Jon Turney
2017-11-02 19:25 ` Ken Brown
2017-11-07 18:15 ` Jon Turney
2017-11-07 18:17 ` [PATCH setup 1/5] Make do_ini() succeed if found_ini_list is empty Jon Turney
2017-11-07 18:17 ` [PATCH setup 4/5] Correctly order preparing packagedb for chooser Jon Turney
2017-11-07 18:17 ` [PATCH setup 2/5] Simplify LocalDirPage::OnNext() Jon Turney
2017-11-07 18:17 ` [PATCH setup 3/5] Ensure packagedb and underlying solver pool is empty before we read setup.ini Jon Turney
2017-11-07 18:17 ` [PATCH setup 5/5] More crash avoidance in SolvableVersion member functions Jon Turney
2017-11-07 23:00 ` [setup topic/libsolv] Crash after incomplete download Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4966bc07-8a00-3324-6b6f-4da2213e974c@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).