From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31358 invoked by alias); 7 Oct 2011 10:55:55 -0000 Received: (qmail 31347 invoked by uid 22791); 7 Oct 2011 10:55:54 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,TW_YG X-Spam-Check-By: sourceware.org Received: from smtp-vbr9.xs4all.nl (HELO smtp-vbr9.xs4all.nl) (194.109.24.29) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Oct 2011 10:55:39 +0000 Received: from [192.168.178.22] (waterlander.xs4all.nl [83.160.52.146]) (authenticated bits=0) by smtp-vbr9.xs4all.nl (8.13.8/8.13.8) with ESMTP id p97Atbvw090580 for ; Fri, 7 Oct 2011 12:55:38 +0200 (CEST) (envelope-from waterlan@xs4all.nl) Message-ID: <4E8EDAAB.9060603@xs4all.nl> Date: Fri, 07 Oct 2011 10:55:00 -0000 From: Erwin Waterlander User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: cygwin-apps@cygwin.com Subject: Re: ITP libunistring 0.9.3-1 References: <4E8E14FB.80808@xs4all.nl> <1317950967.7236.20.camel@YAAKOV04> In-Reply-To: <1317950967.7236.20.camel@YAAKOV04> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com X-SW-Source: 2011-10/txt/msg00012.txt.bz2 Op 7-10-2011 3:29, Yaakov (Cygwin/X) schreef: > On Thu, 2011-10-06 at 22:52 +0200, Erwin Waterlander wrote: >> I propose package 'libunistring' for cygwin. > I presume you have another package in mind which will use this? Yes, I'm going to use it in my own package wcd. > >> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1.tar.bz2 >> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1-src.tar.bz2 > There are several packaging issues: > > 1) Libraries should be packaged in separate runtime and development > packages, so that nothing will break whenever the library ABI changes. OK. I overlooked that. I started with dos2unix's cygport file as an example. I'm still learning. > > 2) Your .cygport file uses internal functions. This is not supported. I see functions used also on other cyport files. I looked at libiconv's cygport file. > > 3) You have skipped the cygautoreconf step. As mentioned in the cygport > documentation, this is strongly discouraged, particularly where libtool > is involved. > > Therefore the .cygport should look like: > > DESCRIPTION="Unicode string library" > HOMEPAGE="http://www.gnu.org/s/libunistring/" > SRC_URI="mirror://gnu/libunistring/${P}.tar.gz" > > PKG_NAMES="libunistring0 libunistring-devel libunistring-doc" > libunistring0_CONTENTS="usr/bin/cygunistring-0.dll" > libunistring_devel_CONTENTS="usr/include/ usr/lib/" > libunistring_doc_CONTENTS="usr/share/doc/ usr/share/info/" > > That's it. Thanks. > > 4) I see this is one of Bruno's packages. He has some unconventional > views about the PE format, and Cygwin in particular. I would suggest > the attached patch. > >> category: Libs >> requires: libgcc1 >> sdesc: "Library for manipulating Unicode strings." >> ldesc: "This library provides functions for manipulating Unicode >> strings and for manipulating C strings according to the Unicode standard." > You will need separate .hint files for each subpackage, adding the > external-source tag. You also need to add a libiconv2 dependency to the > runtime package and libiconv to the devel package. > > > Thanks. And the source patch should be in a separate file isn't it (not included in the cygwin patch). I create a new package with your improvements. best regards, -- Erwin Waterlander