From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18148 invoked by alias); 5 Dec 2011 02:05:53 -0000 Received: (qmail 17632 invoked by uid 22791); 5 Dec 2011 02:05:50 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from out2.smtp.messagingengine.com (HELO out2.smtp.messagingengine.com) (66.111.4.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 02:05:37 +0000 Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id D56DF217BE for ; Sun, 4 Dec 2011 21:05:35 -0500 (EST) Received: from frontend2.nyi.mail.srv.osa ([10.202.2.161]) by compute6.internal (MEProxy); Sun, 04 Dec 2011 21:05:35 -0500 Received: from [192.168.1.3] (50-88-210-98.res.bhn.net [50.88.210.98]) by mail.messagingengine.com (Postfix) with ESMTPSA id 9211F482535; Sun, 4 Dec 2011 21:05:35 -0500 (EST) Message-ID: <4EDC26E4.1000304@cwilson.fastmail.fm> Date: Mon, 05 Dec 2011 02:05:00 -0000 From: Charles Wilson User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 MIME-Version: 1.0 To: Mailing List: CygWin-Apps Subject: Re: ATTENTION: Tcl/Tk transition References: <1319662955.7192.68.camel@YAAKOV04> <4EDAB47D.4050408@cwilson.fastmail.fm> <1323045203.1644.11.camel@YAAKOV04> In-Reply-To: <1323045203.1644.11.camel@YAAKOV04> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com X-SW-Source: 2011-12/txt/msg00007.txt.bz2 On 12/4/2011 7:33 PM, Yaakov (Cygwin/X) wrote: > On Sat, 2011-12-03 at 18:45 -0500, Charles Wilson wrote: >> Yaakov -- the installed tclConfig.sh and tkConfig.sh files include stuff >> like this: >> >> TCL_DEFS='-DPACKAGE_NAME=\"tcl\" -DPACKAGE_TARNAME=\"tcl\" >> -DPACKAGE_VERSION=\"8.5\" -DPACKAGE_STRING=\"tcl\ 8.5\" >> -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 .... >> >> This causes warnings (PACKAGE_NAME redefined, etc) when building other >> packages. > > Which packages are you referring to? I found this while building (msys) versions of tcl and tk, (loosely) based on your cygports. However...I modified tk's configure.in to do a "proper" AC_INIT. So now, tk defines PACKAGE_NAME as "tk" -- but inherits tclConfig's setting of "tcl" (and etc.). It's possible that because tk doesn't, OOB, use the proper AC_INIT invocation that you don't see this problem with your builds. But...is it really right for tk to self-identify as "tcl"? Fix that...and then you see the warning. However, it just seems unambiguously correct, to me, that derived packages should NOT inherit "tcl's" settings of those particular macros. -- Chuck