From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: "Åke Rehnman" <ake.rehnman@gmail.com>
Subject: Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)
Date: Wed, 17 May 2017 10:55:00 -0000 [thread overview]
Message-ID: <4a893f53-220d-ac33-0b94-e69aa8800281@dronecode.org.uk> (raw)
In-Reply-To: <e402101c-8e7d-98ed-b39a-c82100d6d59f@gmail.com>
On 16/05/17 18:05, Ã
ke Rehnman wrote:
> On 2017-05-16 16:00, Jon Turney wrote:
>> I am a bit confused about the behaviour I'm seeing, though.
>>
>> I'm expecting "file:///c:/path" and "file://host/path" to work, but
>> they don't seem to.
> Same behavior here...
Since those are apparently the correct form of URLs, any ideas about how
we might get them to work?
>> However, "file://c:/path" now works, which is good, and
>> "file:////host/path" continues to work
>>
>> The documentation for InternetOpenUrl() says "Only URLs beginning with
>> ftp:, http:, or https: are supported" so I'm wondering if this is
>> really something we should be expecting to work...
> Here is at least an enumeration of different schemes...
> https://msdn.microsoft.com/en-us/library/windows/desktop/aa385149(v=vs.85).aspx
Hmm... I'm not sure that's not just telling you what you can get back
from InternetCrackUrl (which we should probably switch to using in
NetIO::set_url() rather than doing things by hand)
>> Also, is there a reason for the hunk in nio-file.cc removing the
>> reporting of a problem opening the file?
>>
> It will complain for every setup file not found for instance if setup.xz
> is missing bug setup.ini is present. And besides, why should nio_file
> complain but not http and ftp?
Ah yes, I see the inconsistency now you point it out. Makes sense.
I guess that should be changed to a log message.
next prev parent reply other threads:[~2017-05-17 10:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 12:12 [PATCH setup 00/11] Various setup patches Jon Turney
2017-04-28 12:12 ` [PATCH setup 01/11] Remove pointless abstract base class IniDBBuilder Jon Turney
2017-04-28 12:12 ` [PATCH setup 02/11] Remove unused package_status_t stored in packageversion class Jon Turney
2017-04-28 12:13 ` [PATCH setup 07/11] Don't handle missing 'version:' Jon Turney
2017-04-28 12:13 ` [PATCH setup 03/11] Remove cygpackage::destroy() because it does nothing Jon Turney
2017-04-28 12:13 ` [PATCH setup 09/11] Make building with DEBUG less useless Jon Turney
2017-04-28 12:13 ` [PATCH setup 04/11] Make packageversion::source(|s) const Jon Turney
2017-04-28 12:13 ` [PATCH setup 08/11] Don't do unneeded work when changing stability level Jon Turney
2017-04-28 12:13 ` [PATCH setup 06/11] packageversion::sourcePackageSpecification() is const Jon Turney
2017-04-28 12:13 ` [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY) Jon Turney
2017-04-28 15:33 ` Åke Rehnman
2017-04-29 10:53 ` Jon Turney
2017-05-01 12:58 ` Jon Turney
2017-05-01 15:31 ` Åke Rehnman
2017-05-01 20:45 ` Jon Turney
2017-05-02 7:28 ` Åke Rehnman
2017-05-02 11:05 ` Jon Turney
2017-05-02 19:29 ` Åke Rehnman
2017-05-03 16:37 ` Jon Turney
[not found] ` <60ed2d4e-7c89-a9b8-e3ab-e3d0819b7e56@gmail.com>
2017-05-04 10:11 ` Jon Turney
2017-05-16 14:00 ` Jon Turney
[not found] ` <e402101c-8e7d-98ed-b39a-c82100d6d59f@gmail.com>
2017-05-17 10:55 ` Jon Turney [this message]
2017-05-03 7:22 ` Brian Inglis
2017-05-03 16:37 ` Jon Turney
2017-04-28 12:13 ` [PATCH setup 10/11] Don't show source-only packages in package list Jon Turney
2017-05-01 14:45 ` Yaakov Selkowitz
2017-05-01 19:35 ` Jon Turney
2017-04-28 12:13 ` [PATCH setup 05/11] Use const version of packageversion::depends() in PrereqChecker Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a893f53-220d-ac33-0b94-e69aa8800281@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=ake.rehnman@gmail.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).