From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17302 invoked by alias); 17 May 2017 10:55:54 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 17260 invoked by uid 89); 17 May 2017 10:55:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-languages-length:1507, schemes, H*u:i686, H*UA:i686 X-HELO: out2-smtp.messagingengine.com Received: from out2-smtp.messagingengine.com (HELO out2-smtp.messagingengine.com) (66.111.4.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 May 2017 10:55:50 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3664422443; Wed, 17 May 2017 06:55:52 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Wed, 17 May 2017 06:55:52 -0400 X-ME-Sender: Received: from [192.168.2.13] (226.208.125.91.dyn.plus.net [91.125.208.226]) by mail.messagingengine.com (Postfix) with ESMTPA id 69E067E0EE; Wed, 17 May 2017 06:55:51 -0400 (EDT) Subject: Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY) References: <20170428121205.12240-1-jon.turney@dronecode.org.uk> <20170428121205.12240-12-jon.turney@dronecode.org.uk> <3d79b33e-e067-c1df-9b90-084fb10dd272@dronecode.org.uk> <9452ab7f-986c-2394-8c24-6208e042787e@dronecode.org.uk> <506da115-b976-fdb2-bf1b-cec6addfbbbb@dronecode.org.uk> <0b6ab083-d470-c940-5557-d33be5c523cb@gmail.com> <664411e6-ac32-ab77-1b62-72bafc8bacd8@dronecode.org.uk> <60ed2d4e-7c89-a9b8-e3ab-e3d0819b7e56@gmail.com> Cc: =?UTF-8?Q?=c3=85ke_Rehnman?= To: cygwin-apps@cygwin.com From: Jon Turney Message-ID: <4a893f53-220d-ac33-0b94-e69aa8800281@dronecode.org.uk> Date: Wed, 17 May 2017 10:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-05/txt/msg00119.txt.bz2 On 16/05/17 18:05, Åke Rehnman wrote: > On 2017-05-16 16:00, Jon Turney wrote: >> I am a bit confused about the behaviour I'm seeing, though. >> >> I'm expecting "file:///c:/path" and "file://host/path" to work, but >> they don't seem to. > Same behavior here... Since those are apparently the correct form of URLs, any ideas about how we might get them to work? >> However, "file://c:/path" now works, which is good, and >> "file:////host/path" continues to work >> >> The documentation for InternetOpenUrl() says "Only URLs beginning with >> ftp:, http:, or https: are supported" so I'm wondering if this is >> really something we should be expecting to work... > Here is at least an enumeration of different schemes... > https://msdn.microsoft.com/en-us/library/windows/desktop/aa385149(v=vs.85).aspx Hmm... I'm not sure that's not just telling you what you can get back from InternetCrackUrl (which we should probably switch to using in NetIO::set_url() rather than doing things by hand) >> Also, is there a reason for the hunk in nio-file.cc removing the >> reporting of a problem opening the file? >> > It will complain for every setup file not found for instance if setup.xz > is missing bug setup.ini is present. And besides, why should nio_file > complain but not http and ftp? Ah yes, I see the inconsistency now you point it out. Makes sense. I guess that should be changed to a log message.