From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout04.t-online.de (mailout04.t-online.de [194.25.134.18]) by sourceware.org (Postfix) with ESMTPS id 357873858C50 for ; Tue, 27 Sep 2022 13:51:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 357873858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=t-online.de Received: from fwd70.dcpf.telekom.de (fwd70.aul.t-online.de [10.223.144.96]) by mailout04.t-online.de (Postfix) with SMTP id 860E92C70; Tue, 27 Sep 2022 15:51:14 +0200 (CEST) Received: from [192.168.2.101] ([79.230.173.42]) by fwd70.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1odAzQ-04asfQ0; Tue, 27 Sep 2022 15:51:12 +0200 Subject: Re: [Bug] setup regression From: Christian Franke To: Jon Turney , "cygwin-apps@cygwin.com" References: <87leqcocft.fsf@Rainer.invalid> <87h710obeh.fsf@Rainer.invalid> <87tu4z5owu.fsf@Rainer.invalid> <395d4def-71a5-c144-710f-772e64e5e93b@dronecode.org.uk> <835077d9-a870-fb4d-68dc-820d0838d1bb@t-online.de> Message-ID: <4d751290-09dd-b9c5-fcd1-aaf09b1aba89@t-online.de> Date: Tue, 27 Sep 2022 15:51:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 SeaMonkey/2.53.12 MIME-Version: 1.0 In-Reply-To: <835077d9-a870-fb4d-68dc-820d0838d1bb@t-online.de> Content-Type: multipart/mixed; boundary="------------4F5AE051C83ECA359D1A1B26" X-TOI-EXPURGATEID: 150726::1664286672-4AFF5689-8FFB33C1/0/0 CLEAN NORMAL X-TOI-MSGID: a106b8d4-5762-4a80-8fc5-bf16692ffbd9 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------4F5AE051C83ECA359D1A1B26 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Christian Franke wrote: > ... > I made the false assumption that default_version=empty in set_action() > always implies that the default version is not accessible. This is not > the case for packages selected for installation before chooser is > visible. > > I'm working on a new fix for the "Ctrl+I pressed but current version > is not accessible" case. ... See attached patch. It also fixes the same problem for the "Category" view. Testing shows that the problem only affects the display of the version number as the solver later silently removes such install requests. > The correct logic is already in toggle_action(): Install the most > recent accessible non-test ('naively_preferred') version. > I dropped this idea and aligned Ctrl+I behavior with "Install" from "Category" view instead. Toggle_action() behaves different in such corner cases as it always installs something. --------------4F5AE051C83ECA359D1A1B26 Content-Type: text/plain; charset=UTF-8; name="0001-Ignore-install-requests-if-version-is-not-accessible.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Ignore-install-requests-if-version-is-not-accessible.pa"; filename*1="tch" RnJvbSA3ZTFlZmQzNDZlMzU4OThlMzQ4NmZiODRjZjI1YjM4ODVhMmExNmVjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRnJhbmtlIDxjaHJpc3RpYW4uZnJh bmtlQHQtb25saW5lLmRlPgpEYXRlOiBUdWUsIDI3IFNlcCAyMDIyIDE1OjQxOjA2ICswMjAw ClN1YmplY3Q6IFtQQVRDSF0gSWdub3JlIGluc3RhbGwgcmVxdWVzdHMgaWYgdmVyc2lvbiBp cyBub3QgYWNjZXNzaWJsZQoKVGhpcyBhdm9pZHMgdGhhdCBhbiBlbXB0eSAiTmV3IiB2ZXJz aW9uIGlzIHNob3duIHdoZW4gaW5zdGFsbCBpcwpyZXF1ZXN0ZWQgdmlhICJJbnN0YWxsIiBm cm9tICJDYXRlZ29yeSIgdmlldyBvciBDdHJsK0kgYW5kIHRoZQp2ZXJzaW9uIGlzIG5vdCBh Y2Nlc3NpYmxlLgotLS0KIHBhY2thZ2VfbWV0YS5jYyB8IDEyICsrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9wYWNrYWdlX21l dGEuY2MgYi9wYWNrYWdlX21ldGEuY2MKaW5kZXggMDViODk0Ni4uZWJmYzk0NyAxMDA2NDQK LS0tIGEvcGFja2FnZV9tZXRhLmNjCisrKyBiL3BhY2thZ2VfbWV0YS5jYwpAQCAtNTM5LDYg KzUzOSwxNyBAQCBwYWNrYWdlbWV0YTo6c2VsZWN0X2FjdGlvbiAoaW50IGlkLCB0cnVzdHMg Y29uc3QgZGVmdHJ1c3QpCiAgICAgewogICAgICAgaWYgKGlkID09IHBhY2thZ2VtZXRhOjpO b0NoYW5nZV9hY3Rpb24pCiAgICAgICAgIHNldF9hY3Rpb24oKHBhY2thZ2VtZXRhOjpfYWN0 aW9ucylpZCwgaW5zdGFsbGVkKTsKKyAgICAgIGVsc2UgaWYgKGlkID09IEluc3RhbGxfYWN0 aW9uKQorCXsKKwkgIC8vIElnbm9yZSBpbnN0YWxsIHJlcXVlc3QgaWYgdGhlIGRlZmF1bHQg dmVyc2lvbiBpcyBub3QgYWNjZXNzaWJsZS4KKwkgIC8vIFRoaXMgYXNzdW1lcyB0aGF0IGFs bCBhdmFpbGFibGUgdmVyc2lvbnMgYXJlIGFscmVhZHkga25vd24uCisJICAvLyBUaGlzIGlz IG5vdCBhbHdheXMgdGhlIGNhc2Ugd2hlbiBzZXRfYWN0aW9uIGlzIGNhbGxlZCBkaXJlY3Rs eS4KKwkgIHBhY2thZ2V2ZXJzaW9uIHYgPSB0cnVzdHAgKHRydWUsIGRlZnRydXN0KTsKKwkg IGlmICh2LmFjY2Vzc2libGUgKCkpCisJICAgIHNldF9hY3Rpb24oSW5zdGFsbF9hY3Rpb24s IHYsIHRydWUpOworCSAgZWxzZQorCSAgICBzZXRfYWN0aW9uKE5vQ2hhbmdlX2FjdGlvbiwg aW5zdGFsbGVkKTsKKwl9CiAgICAgICBlbHNlCiAgICAgICAgIHNldF9hY3Rpb24oKHBhY2th Z2VtZXRhOjpfYWN0aW9ucylpZCwgdHJ1c3RwICh0cnVlLCBkZWZ0cnVzdCksIHRydWUpOwog ICAgIH0KQEAgLTYyNyw2ICs2MzgsNyBAQCBwYWNrYWdlbWV0YTo6c2V0X2FjdGlvbiAoX2Fj dGlvbnMgYWN0aW9uLCBwYWNrYWdldmVyc2lvbiBjb25zdCAmZGVmYXVsdF92ZXJzaW9uLAog ICBlbHNlIGlmIChhY3Rpb24gPT0gSW5zdGFsbF9hY3Rpb24pCiAgICAgewogICAgICAgZGVz aXJlZCA9IGRlZmF1bHRfdmVyc2lvbjsKKyAgICAgIC8vIElmIGRlc2lyZWQgaXMgZW1wdHks IGl0IHdpbGwgYmUgc2V0IHRvIHRoZSBzb2x2ZXIncyBwcmVmZXJyZWQgdmVyc2lvbiBsYXRl ci4KICAgICAgIGlmIChkZXNpcmVkKQogCXsKIAkgIGlmIChkZXNpcmVkICE9IGluc3RhbGxl ZCkKLS0gCjIuMzcuMgoK --------------4F5AE051C83ECA359D1A1B26--