From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-041.btinternet.com (mailomta10-re.btinternet.com [213.120.69.103]) by sourceware.org (Postfix) with ESMTPS id C70F83858CD1 for ; Sun, 10 Mar 2024 13:50:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C70F83858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C70F83858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.103 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710078638; cv=none; b=qvHFJDZ0Dla1tjCcbFaIIb4Vw4wQ6Ol31ZqqvWlojLacWfyRD1OF4yRZMNPYUla//4qTA68qQMDxSDIPrPCnW1ZXqSC/SdMkbR4m/m/aiZ9/TbUaG4+ZRTq6or8MTzIbcw84ZnF0jRGFAXHhDgau1fVZgoaHD6YsMMihqn1lcog= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710078638; c=relaxed/simple; bh=xsLWMzbc/IespC+N0fpO0RFD4n4blZtYTlMavU5T+w8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=x/uLnndDX0fIx32Z77NkazkwiROAYhbiFxwAAvzWlHz7K4gHPQIDl7vlPKK8mrmkDJqZticePW1ckHpb+iQuIY6QPwRfO6V1XODuXZN0wyu+P2yyR4pU2XBbS2ljIu0uELRj+JJ3UwTj6XiqaZ/HQpzHK96QMWm/7QiJCuefuW8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-041.btinternet.com with ESMTP id <20240310135033.YRUH21578.re-prd-fep-041.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Sun, 10 Mar 2024 13:50:33 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6577B5E30ADE571F X-Originating-IP: [81.153.98.185] X-OWM-Source-IP: 81.153.98.185 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvledrieelgdehjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhvegjtgfgsehtjeertddtvdejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeevvdekgfffteetueehgfdugefgkeevleejudduheevuedtveejfeevvdevvdfgvdenucfkphepkedurdduheefrdelkedrudekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtlegnpdhinhgvthepkedurdduheefrdelkedrudekhedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepvehhrhhishhtihgrnhdrhfhrrghnkhgvsehtqdhonhhlihhnvgdruggvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrvghvkffrpehhohhsthekuddqudehfedqleekqddukeehrdhrrghnghgvkeduqdduheefrdgsthgtvghnthhrrghlphhluhhsrdgtohhmpdgruhhthhgpuhhsvghrpehjohhnthhurhhnvgihsegsthhinhht vghrnhgvthdrtghomhdpghgvohfkrfepifeupdfovfetjfhoshhtpehrvgdqphhrugdqrhhgohhuthdqtddtvd X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.109] (81.153.98.185) by re-prd-rgout-002.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 6577B5E30ADE571F; Sun, 10 Mar 2024 13:50:33 +0000 Message-ID: <4e277f6b-882d-4aaa-bbed-bb505dec7deb@dronecode.org.uk> Date: Sun, 10 Mar 2024 13:50:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH Content-Language: en-US To: Christian Franke References: <06513e22-04c3-d0fd-ec1a-bddd845ae926@t-online.de> <7d8f27ba-b825-4ed5-9d3b-50170e834ec6@dronecode.org.uk> From: Jon Turney Cc: cygwin-apps@cygwin.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26/02/2024 19:53, Christian Franke via Cygwin-apps wrote: > >> Would it not make more sense to just re-export it if set? > > If the cygport file decides to set but not export it, there is possibly > no need to do it. An example is smartmontools.cygport which passes the > unexported variable as a parameter to configure. Ok, but exporting it is harmless there, right? >> (so that commands like "SOURCE_DATE_EPOCH=something cygport foo" work >> as expected?) >> > > Would make no difference as the 'VAR=val CMD...' syntax already exports > the variable to the CMD: > > $ unset FOO; FOO=bar sh -c 'sh -c "sh -c printenv\ FOO"' > bar > Ah, right. So you seem to be saying that the only situation where it's set but not exported is where it's set in the cygport. So we're just making people (need to remember to) explicitly write "export SOURCE_DATE_EPOCH" in their cygport where needed?