From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) by sourceware.org (Postfix) with ESMTPS id E20C93858C55 for ; Thu, 29 Sep 2022 19:15:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E20C93858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=none smtp.mailfrom=systematicsw.ab.ca Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id dspwov53lS8Wrdz0fo7gnS; Thu, 29 Sep 2022 19:15:49 +0000 Received: from [10.0.0.5] ([184.64.124.72]) by cmsmtp with ESMTP id dz0eoIPOflahmdz0eohpFY; Thu, 29 Sep 2022 19:15:49 +0000 X-Authority-Analysis: v=2.4 cv=d8PmdDvE c=1 sm=1 tr=0 ts=6335eee5 a=oHm12aVswOWz6TMtn9zYKg==:117 a=oHm12aVswOWz6TMtn9zYKg==:17 a=IkcTkHD0fZMA:10 a=94nOnFI1EgyDtX4ev68A:9 a=QEXdDO2ut3YA:10 Message-ID: <4ea3e2fe-a876-52b9-5f9a-f1da51017620@SystematicSw.ab.ca> Date: Thu, 29 Sep 2022 13:15:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Reply-To: Cygwin Applications Subject: Issue with another downstream over DESTDIR builds Content-Language: en-CA To: Cygwin Applications References: <61bc8c6e-ed8f-a812-6c05-9e68c4a0a3c7@SystematicSw.ab.ca> <3436aa36-d661-629e-b704-b4887bb0b60f@SystematicSw.ab.ca> <5a2c3997-6274-59ce-fb1a-630418bc49f0@SystematicSw.ab.ca> <608B851A-90F3-4A75-BB9E-1F972934A995@sk2.org> Cc: Brian Inglis From: Brian Inglis Organization: Systematic Software In-Reply-To: <608B851A-90F3-4A75-BB9E-1F972934A995@sk2.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfD6e04yZbEk/Cxpi/0ZJ5rs6rL6q57vTVsSaQy4vxRBV+Jxy5gSRoUMWqHWerwKtv/3TG/ldqr4gPlQivgw5ATvWBDQHxkNZBuHJcgJ4w2Q/dV6IeDrV zDz6pGiqlVdRzNq0GF4rDknzdJ0T28mwH8dNn6avL9eY+pbblN3+Bq/eiTF+wo3u8azH8ZJXqo+iTVC8Eb2e/YPpZ0+u3k82dZRa4coMsRp0HlTZsPvoHmE+ tx414RWmmxj/Xgo8wGqqrQ== X-Spam-Status: No, score=-1163.8 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists] I previously submitted a patch upstream to add DESTDIR when creating package symlinks so cygport builds work without patches. Now another downstream is disputing that, requesting the patch be reverted, saying that symlink targets are contents and should always be from the non-DESTDIR native source as per GNU "rules" in the autobook. We agreed to request other more experienced opinions on this issue from our support groups and report back. I am asking the perhaps more experienced professional maintainers to provide their considered opinion on this issue, demonstrated by the reversion patch below. > The link's target must not include $(DESTDIR), otherwise this ends up > included in the shipped link. Linking the theoretical target gives the > correct result. > > --- a/Makefile.in > +++ b/Makefile.in > @@ -115,7 +115,7 @@ > $(INSTALL_DATA) $(srcdir)/definitions.units $(DESTDIR)@UDAT@definitions.units > -rm -f $(DESTDIR)@UDAT@currency.units > $(INSTALL_DATA) $(srcdir)/currency.units $(DESTDIR)@CDAT@currency.units > - if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf $(DESTDIR)@CDAT@currency.units $(DESTDIR)@UDAT@currency.units;fi > + if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf @CDAT@currency.units $(DESTDIR)@UDAT@currency.units;fi > $(INSTALL_DATA) $(srcdir)/locale_map.txt $(DESTDIR)@UDAT@locale_map.txt > if test $(HAVE_PYTHON) = yes; then \ > $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo units_cur|sed '$(transform)'`;fi -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.]