From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id D5F4F3858034 for ; Wed, 19 May 2021 07:05:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5F4F3858034 Received: by mail-wr1-x433.google.com with SMTP id z17so12749173wrq.7 for ; Wed, 19 May 2021 00:05:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9jpivRpcNa0cNRb1W63l/Cbx4WhRWL3/ayLFu6RxEn0=; b=AwKlsZutHObqKFJHfdI0CC6QScitSssSyxHrbUIlu+9iExEKGppsDD7eUBuKjlcYDY +9tC63/oBNJSnKb7cFSROUhKSy/044NogiBjVp8fm6d+qpKusaJu/SDJiFprYt4SG877 YHFuI/KoY7ltzjGK2rqw95qkqFFwl6X6cZpEDgk/sg9UL1IsDrB5WBRQfyLfCg26BqLR /o5E08TeuIkJ1WOhtjnQynTndQEqwQmmDKv1SUl7mkN3DLTAmaLz8VFp/rd7zmxVeXJ4 pf77ruIWuHIj6sHwElX/k4imkDU5u+hq7hBRtmqIN47viLBxZpzQR7/zEyiUxgac0uhO 3NvQ== X-Gm-Message-State: AOAM532SPMszQeVnGemuCZSrhUL/8O2lkOuR8fsx5LcL0DWJl900obo5 rxBNCnwiFMos3970Vlqw6DUnhzE74fCIhA== X-Google-Smtp-Source: ABdhPJwo4dHtIFE7okqrxTmucT4mKj6fRqg5HuBDS+xWk1Ln+oLDm9NZXUMB9Qr9V6Fxdq1D2QxfTw== X-Received: by 2002:adf:edc9:: with SMTP id v9mr10672828wro.103.1621407934599; Wed, 19 May 2021 00:05:34 -0700 (PDT) Received: from ?IPv6:2003:cc:9f04:e34a:8ddd:bef9:a0af:3839? (p200300cc9f04e34a8dddbef9a0af3839.dip0.t-ipconnect.de. [2003:cc:9f04:e34a:8ddd:bef9:a0af:3839]) by smtp.gmail.com with ESMTPSA id r11sm18394635wrp.46.2021.05.19.00.05.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 00:05:34 -0700 (PDT) Subject: Re: cygport test has zero exit status on failures To: cygwin-apps@cygwin.com References: <01ad01d74517$f9f4e6e0$eddeb4a0$@pdinc.us> <87h7jbuqir.fsf@Otto.invalid> <009c01d74b6c$1ce8f7e0$56bae7a0$@pdinc.us> <8735ukejz2.fsf@Otto.invalid> <03dc01d74c1a$80c3df60$824b9e20$@pdinc.us> <87k0nvdcho.fsf@Rainer.invalid> <051901d74c28$58efeac0$0acfc040$@pdinc.us> <87y2cbcnhi.fsf@Otto.invalid> From: Marco Atzeri Message-ID: <50c37d50-1965-50cb-feb9-f386ab0b1374@gmail.com> Date: Wed, 19 May 2021 09:05:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87y2cbcnhi.fsf@Otto.invalid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: it Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 07:05:37 -0000 On 19.05.2021 07:16, ASSI wrote: > Jason Pyeron writes: > >> In any case the all or all-test does not execute the test step, so the >> customization of the src_test does not impact the default behaviors. > > That's beside the point. We were only talking about the test behaviours > or at least I was, anyway. Now again, if you do that in the cygport > file you mix that expectation of getting a return value (that really > comes from the way you run cygport in the CI and determine the test > status) with the package definition. If you force that to satisfy your > CI requirements, you also break the flow for folks who (as an example) > rather do > > cygport $p finish prep compile inst test pkg > > because a test fail would now error out before getting to the packaging > step. Which is why I was musing that your preference in how to treat a > test fail should really be injected from the run-time environment rather > than the package definition. Once that mechanism is in place I can also > start writing my own src_test functions that switch their behaviour > depending on that setting so that these package definitions would work > in either environment. in general a generic test failure is not a valid reason to NOT package. Most of my packages have peculiar test failures that can be just ignored In several, I just use "cygmake -i check" in src_test to avoid premature stop of the tests. Others requires to be installed before the testsuite is properly executed. > Regards, > Achim. Regards Marco