From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19087 invoked by alias); 7 Oct 2013 15:03:25 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 19073 invoked by uid 89); 7 Oct 2013 15:03:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_50 autolearn=ham version=3.3.2 X-HELO: smtpout05.bt.lon5.cpcloud.co.uk Received: from smtpout05.bt.lon5.cpcloud.co.uk (HELO smtpout05.bt.lon5.cpcloud.co.uk) (65.20.0.125) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Oct 2013 15:03:24 +0000 X-CTCH-RefID: str=0001.0A090204.5252CD19.0095,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-Junkmail-Premium-Raw: score=28/97,refid=2.7.2:2013.10.7.101214:17:28.394,ip=86.139.180.185,rules=__MOZILLA_MSGID, __HAS_MSGID, __SANE_MSGID, __HAS_FROM, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __TO_MALFORMED_2, __TO_NO_NAME, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __SUBJ_ALPHA_END, __IN_REP_TO, __CT, __CTYPE_HAS_BOUNDARY, __CTYPE_MULTIPART, __CTYPE_MULTIPART_MIXED, __BAT_BOUNDARY, __ANY_URI, __URI_NO_WWW, __URI_NO_PATH, __SUBJ_ALPHA_NEGATE, __FORWARDED_MSG, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_2000_2999, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, __URI_NS, SXL_IP_DYNAMIC[185.180.139.86.fur], HTML_00_01, HTML_00_10, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, RDNS_SUSP, BODY_SIZE_7000_LESS, MIME_TEXT_ONLY_MP_MIXED X-CTCH-Spam: Unknown Received: from [192.168.1.72] (86.139.180.185) by smtpout05.bt.lon5.cpcloud.co.uk (8.6.100.09) (authenticated as jonturney@btinternet.com) id 524DECDF004BBBBF; Mon, 7 Oct 2013 16:02:48 +0100 Message-ID: <5252CD17.4080001@dronecode.org.uk> Date: Mon, 07 Oct 2013 15:03:00 -0000 From: Jon TURNEY User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: cygwin-apps@cygwin.com CC: Achim Gratz Subject: Re: [PATCH 1/4 setup] package re-/de-installation from CLI References: <87a9lexyk8.fsf@Rainer.invalid> <20130724115129.GT9689@calimero.vinschen.de> <874nbjbsbw.fsf@Rainer.invalid> <874nbjade0.fsf_-_@Rainer.invalid> In-Reply-To: <874nbjade0.fsf_-_@Rainer.invalid> Content-Type: multipart/mixed; boundary="------------060103000203060101090008" X-SW-Source: 2013-10/txt/msg00047.txt.bz2 This is a multi-part message in MIME format. --------------060103000203060101090008 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 1280 On 24/07/2013 21:53, Achim Gratz wrote: > From 1686e0beac98867bf1fe358a8fe9a9d8647d4a3a Mon Sep 17 00:00:00 2001 > From: Achim Gratz > Date: Fri, 8 Feb 2013 20:58:20 +0100 > Subject: [PATCH 1/4] Remove detrimental initialization > > * choose.cc (createListview): Remove superflous and detrimental > default trust setting. This has already been set correctly > in OnInit. > --- > choose.cc | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/choose.cc b/choose.cc > index 6d5f3b7..4e0bcd4 100644 > --- a/choose.cc > +++ b/choose.cc > @@ -148,11 +148,6 @@ ChooserPage::createListview () > log (LOG_BABBLE) << "Failed to set View button caption %ld" << > GetLastError () << endLog; > > - for (packagedb::packagecollection::iterator i = db.packages.begin(); i != db.packages.end(); i++) > - { > - i->second->set_requirements(chooser->deftrust); > - } > - There have been a few reports that setup no longer installs the dependencies of explicitly specified packages in unattended mode, and this seems to be the culprit. A small patch to fix this is attached. (I note with amazement that setup has two dependency solvers: one in PrereqChecker, and one in packageversion) --------------060103000203060101090008 Content-Type: text/plain; charset=windows-1252; name="0001-Fix-selecting-of-package-dependencies-in-unattended-.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-selecting-of-package-dependencies-in-unattended-.pa"; filename*1="tch" Content-length: 1019 >From 29da1520437fc3edfe9b53b7e07441af91d2b1ad Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Mon, 7 Oct 2013 15:07:35 +0100 Subject: [PATCH setup] Fix selecting of package dependencies in unattended mode Signed-off-by: Jon TURNEY --- prereq.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/prereq.cc b/prereq.cc index 675bdfe..a46ca7e 100644 --- a/prereq.cc +++ b/prereq.cc @@ -150,9 +150,10 @@ PrereqPage::OnUnattended () if (unattended_mode == chooseronly) return -1; - // in unattended mode, carry on to download/install - // (this can only happen if there some kind of problem with dependencies, as all required dependencies - // should be selected automatically by the chooser page in unattended mode, so we should never get here) + // in unattended mode, add the missing requirements, then carry on to download/install + PrereqChecker p; + p.selectMissing (); + return whatNext(); } -- 1.8.3.4 --------------060103000203060101090008--