From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24457 invoked by alias); 22 Apr 2014 17:50:13 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 24445 invoked by uid 89); 22 Apr 2014 17:50:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: smtpout07.bt.lon5.cpcloud.co.uk Received: from smtpout07.bt.lon5.cpcloud.co.uk (HELO smtpout07.bt.lon5.cpcloud.co.uk) (65.20.0.127) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Apr 2014 17:50:11 +0000 X-CTCH-RefID: str=0001.0A090202.5356ABCF.010E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-Junkmail-Premium-Raw: score=7/97,refid=2.7.2:2014.3.20.104516:17:7.944,ip=,rules=__MOZILLA_MSGID, __HAS_MSGID, __SANE_MSGID, __HAS_FROM, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __TO_MALFORMED_2, __TO_NO_NAME, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __ANY_URI, URI_ENDS_IN_HTML, __URI_NO_MAILTO, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __FORWARDED_MSG, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_2000_2999, __MIME_TEXT_ONLY, __URI_NS, HTML_00_01, HTML_00_10, BODY_SIZE_5000_LESS, BODY_SIZE_7000_LESS X-CTCH-Spam: Unknown Received: from [192.168.1.72] (86.164.67.104) by smtpout07.bt.lon5.cpcloud.co.uk (8.6.100.99.10223) (authenticated as jonturney@btinternet.com) id 5321F74A01073EC9 for cygwin-apps@cygwin.com; Tue, 22 Apr 2014 18:50:07 +0100 Message-ID: <5356ABE0.8050606@dronecode.org.uk> Date: Tue, 22 Apr 2014 17:50:00 -0000 From: Jon TURNEY User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: cygwin-apps@cygwin.com Subject: Re: [PATCH setup 3/3] Add the last element of URL path to site chooser, if interesting. References: <1398078987-5116-1-git-send-email-jon.turney@dronecode.org.uk> <1398078987-5116-4-git-send-email-jon.turney@dronecode.org.uk> <20140421141028.GD661@ednor.casa.cgf.cx> <53555F7C.7070708@dronecode.org.uk> <20140422075315.GB5959@calimero.vinschen.de> <20140422144744.GA7528@ednor.casa.cgf.cx> In-Reply-To: <20140422144744.GA7528@ednor.casa.cgf.cx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-04/txt/msg00063.txt.bz2 On 22/04/2014 15:47, Christopher Faylor wrote: > On Tue, Apr 22, 2014 at 09:53:15AM +0200, Corinna Vinschen wrote: >> On Apr 21 19:12, Jon TURNEY wrote: >>> On 21/04/2014 15:10, Christopher Faylor wrote: >>>> On Mon, Apr 21, 2014 at 12:16:27PM +0100, Jon TURNEY wrote: >>>>> If I add the site http://mirrors.kernel.org/sources.redhat.com/cygwinports/ to >>>>> setup's mirror list, using the GUI or --site option, I get two indistinguishable >>>>> entries named http://mirrors.kernel.org in the mirror list box. >>>>> >>>>> So, to make the site chooser list entries more distinguishable, add the last >>>>> element of the URL path to the site chooser, if it exists and isn't 'cygwin' (or >>>>> some other alternatives used by current mirrors) >>>>> >>>>> As Corinna pointed out in Nov 2010, there is still a corner case of URLs which >>>>> share protocol, hostname and the last element of the URL path being >>>>> indistinguishable. Additionally, it will need updating for any new mirrors which >>>>> don't use one of the expected strings for the last path element in the URL. >>>> >>>> I'd actually be ok with just displaying the whole URL even if it ends with Cygwin. >>>> Is there a reason not to do that? >>> >>> Last time this was discussed [1], I think you felt that the current site list >>> and dialog box is too small to display the full URL usefully. >>> >>> [1] http://cygwin.com/ml/cygwin-apps/2010-11/msg00134.html >> >> The dialog has still a lot of space to the left and right of the URL >> list window. We could resize it to take the full available space even >> in the smallest dialog size. I think that would be sufficient most >> of the time. And the dialog can be resized if it doesn't suffice. > > I agree. I was going to suggest resizing (maybe I did before too). > We'd like to get a new version of setup.exe released soon. I think > these changes would be nice to have in it. Any chance you could do > that Jon? Sure, I'll take another look when I can. per IRC [1/3] and [2/3] applied, [3/3] withdrawn.