[ITA] p7zip

[ITA] p7zip

[Tony Kelman]

Hi,

I noticed that all of Chuck Wilson's packages are now listed as orphaned. 
I'm particularly interested in getting one of them, p7zip, uploaded to the 
64-bit distribution. I sent a few messages to the main list in March 
discussing what I needed to change in order to get the existing cygport to 
build in 64 bit Cygwin. I'm willing to adopt the package, if someone can 
guide me through the rest of the process.

Let me know if I'm doing this right. Package files are uploaded here:
https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1.tar.xz
https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1-src.tar.xz
https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/setup.hint

I put the source up in a GitHub repository so you can see the two small 
tweaks I had to make: https://github.com/tkelman/cygwin-p7zip/commits/master
One required repackaging the upstream source tarball to fix line endings on 
a man file (so a patch would apply correctly), the other was to switch to a 
different makefile fragment to use a C version of a CRC routine instead of 
an architecture-dependent assembly version. There's a 64 bit assembly 
version of the same routine included in the source, but I could never get it 
to work reliably. I reported the problem upstream and never got a response: 
https://sourceforge.net/p/p7zip/support-requests/6/#2150

Let me know if any comments or anything else I need to do.

-Tony

P.S: For fun and to see if it would work, I used the AppVeyor CI service to 
build this. You can see the log here 
https://ci.appveyor.com/project/tkelman/cygwin-p7zip/build/1.0.13. Kinda 
neat, but there's a 30 minute time limit which could get restrictive for 
bigger packages. Has anyone tried cross-compiling Cygwin packages from 
something like Travis CI?

Re: [ITA] p7zip

[Andrew Schulman]

> Hi,
> 
> I noticed that all of Chuck Wilson's packages are now listed as orphaned. 
> I'm particularly interested in getting one of them, p7zip, uploaded to the 
> 64-bit distribution. I sent a few messages to the main list in March 
> discussing what I needed to change in order to get the existing cygport to 
> build in 64 bit Cygwin. I'm willing to adopt the package, if someone can 
> guide me through the rest of the process.
> 
> Let me know if I'm doing this right. Package files are uploaded here:
> https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1.tar.xz
> https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1-src.tar.xz
> https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/setup.hint

Packaging is GTG.

Re: [ITA] p7zip

[Jon TURNEY]

On 26/07/2014 09:00, Tony Kelman wrote:
> I noticed that all of Chuck Wilson's packages are now listed as
> orphaned. I'm particularly interested in getting one of them, p7zip,
> uploaded to the 64-bit distribution. I sent a few messages to the main
> list in March discussing what I needed to change in order to get the
> existing cygport to build in 64 bit Cygwin. I'm willing to adopt the
> package, if someone can guide me through the rest of the process.
>
> Let me know if I'm doing this right. Package files are uploaded here:
> https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1.tar.xz
>
> https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1-src.tar.xz
>
> https://ci.appveyor.com/api/buildjobs/1cxy8w15aq971cyr/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/setup.hint
>
>
> I put the source up in a GitHub repository so you can see the two small
> tweaks I had to make:
> https://github.com/tkelman/cygwin-p7zip/commits/master
> One required repackaging the upstream source tarball to fix line endings
> on a man file (so a patch would apply correctly),

Thanks for doing this.

Rather than changing the upstream source tarball, you can add something 
like:

CYGPORT_USE_UNSTABLE_API=1
src_unpack_hook() {
        dos2unix man1/7zr.1
}

> the other was to
> switch to a different makefile fragment to use a C version of a CRC
> routine instead of an architecture-dependent assembly version. There's a
> 64 bit assembly version of the same routine included in the source, but
> I could never get it to work reliably. I reported the problem upstream
> and never got a response:
> https://sourceforge.net/p/p7zip/support-requests/6/#2150
>
> Let me know if any comments or anything else I need to do.

/usr/share/doc/Cygwin/p7zip.README is still about 9.20.1-1.  Since this 
file is no longer mandatory, you may remove it rather than updating it.

Otherwise, GTG.

Re: [ITA] p7zip

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

On Aug  4 08:35, Andrew Schulman wrote:
> > Thanks all for the feedback and help. Sorry for showing up at a bad time.
> > 
> > > Note: You should perhaps remove the "keepdir" that preserves the
> > > /usr/lib/p7zip/Codecs directory.  This drops a zero-size .keep-p7zip
> > > file in there that elicits a warning from p7zip since it isn't a codec.
> > > On the other hand, no warnings if the directory is simply missing and I
> > > don't know of any package that tries to drop anything in there anyway.
> > 
> > I made this suggested change, and think I got everything uploaded.
> > https://cygwin.com/cgi-bin2/package-grep.cgi?grep=p7zip&arch=x86_64
> > looks promising, anyway. Guessing the sdesc from setup.hint doesn't
> > get indexed as often?
> > 
> > Now I should write to cygwin-announce, yeah? And we can remove p7zip
> > from https://cygwin.com/cygwin-64bit-missing.

Done.

> > That wasn't so bad! I skimmed through the list of orphaned packages
> > to see if there was anything else that I'm familiar with building from
> > source, but nothing jumped out at me.
> 
> People who adopt orphaned packages get a gold star. You can visit yours at
> http://cygwin.com/goldstars/#TK .

That was quick!  I'm glad you're casting goldstars, not shuriken :)


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ITA] p7zip

[Andrew Schulman]

> Thanks all for the feedback and help. Sorry for showing up at a bad time.
> 
> > Note: You should perhaps remove the "keepdir" that preserves the
> > /usr/lib/p7zip/Codecs directory.  This drops a zero-size .keep-p7zip
> > file in there that elicits a warning from p7zip since it isn't a codec.
> > On the other hand, no warnings if the directory is simply missing and I
> > don't know of any package that tries to drop anything in there anyway.
> 
> I made this suggested change, and think I got everything uploaded.
> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=p7zip&arch=x86_64
> looks promising, anyway. Guessing the sdesc from setup.hint doesn't
> get indexed as often?
> 
> Now I should write to cygwin-announce, yeah? And we can remove p7zip
> from https://cygwin.com/cygwin-64bit-missing.
> 
> That wasn't so bad! I skimmed through the list of orphaned packages
> to see if there was anything else that I'm familiar with building from
> source, but nothing jumped out at me.

People who adopt orphaned packages get a gold star. You can visit yours at
http://cygwin.com/goldstars/#TK .

Re: [ITA] p7zip

[Tony Kelman]

Thanks all for the feedback and help. Sorry for showing up at a bad time.

> Note: You should perhaps remove the "keepdir" that preserves the
> /usr/lib/p7zip/Codecs directory.  This drops a zero-size .keep-p7zip
> file in there that elicits a warning from p7zip since it isn't a codec.
> On the other hand, no warnings if the directory is simply missing and I
> don't know of any package that tries to drop anything in there anyway.

I made this suggested change, and think I got everything uploaded.
https://cygwin.com/cgi-bin2/package-grep.cgi?grep=p7zip&arch=x86_64
looks promising, anyway. Guessing the sdesc from setup.hint doesn't
get indexed as often?

Now I should write to cygwin-announce, yeah? And we can remove p7zip
from https://cygwin.com/cygwin-64bit-missing.

That wasn't so bad! I skimmed through the list of orphaned packages
to see if there was anything else that I'm familiar with building from
source, but nothing jumped out at me.

-Tony

Re: [ITA] p7zip

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]

On Aug  3 20:03, Achim Gratz wrote:
> Marco Atzeri writes:
> > 5 votes is for ITP of new package not included in a main linux distri.
> > It does not apply to ITA.
> 
> OK.
> 
> > as CGF left who will take care of adding Tony to the
> > authorized uploaders ?
> 
> That would probably have to be done by Corinna or Yaakov.  But I'm not
> sure who has access to sourceware.

Right now we're in a transition period.  Some stuff is a bit in limbo,
but we'll get to it eventually.

As for the people who have the required permissions on sware, that will
be Eric Blake, Jon Turney, Yaakov and me.  Yaakov volunteered to take
over the bulk of the Cygwin infrastructure tasks on sourceware, but that
shouldn't mean we leave Yaakov alone.  After all even Yaakov has
vacation sometime :)

The idea is that Yaakov looks into this stuff in the first place, but he
will provide a bit of documentation for the various tasks so we four can
do this on a floating time-sharing basis (assuming Eric and Jon agree to
help out).

When we have a grip on how everything works, we might consider changes,
but for the time being, please let us time to get the grip.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ITA] p7zip

[Achim Gratz]

Marco Atzeri writes:
> 5 votes is for ITP of new package not included in a main linux distri.
> It does not apply to ITA.

OK.

> as CGF left who will take care of adding Tony to the
> authorized uploaders ?

That would probably have to be done by Corinna or Yaakov.  But I'm not
sure who has access to sourceware.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [ITA] p7zip

[Yaakov Selkowitz]

On Sun, 2014-08-03 at 18:02 +0200, Marco Atzeri wrote:
> as CGF left who will take care of adding Tony to the
> authorized uploaders ?

I will, but like all transitions, this looks like it will be a bit
bumpy.  As soon as I have things cleared up, I'll ack the SSH key
thread.


Yaakov

Re: [ITA] p7zip

[Marco Atzeri]

On 03/08/2014 17:12, Achim Gratz wrote:
> Tony Kelman writes:
>> I'm a bit unclear what needs to happen next, despite reading all of
>> https://cygwin.com/setup.html several times. Do I need another GTG
>> for the slightly-modified version I posted?
>
> GTG from me (unless the rules get slightly relaxed since you're just
> taking over you'd need five votes).

Hi Achim,
5 votes is for ITP of new package not included in a main linux distri.
It does not apply to ITA.

> Note: You should perhaps remove the "keepdir" that preserves the
> /usr/lib/p7zip/Codecs directory.  This drops a zero-size .keep-p7zip
> file in there that elicits a warning from p7zip since it isn't a codec.
> On the other hand, no warnings if the directory is simply missing and I
> don't know of any package that tries to drop anything in there anyway.
>
>
> Regards,
> Achim.
>

as CGF left who will take care of adding Tony to the
authorized uploaders ?

Regards

Marco

Re: [ITA] p7zip

[Achim Gratz]

Tony Kelman writes:
> I'm a bit unclear what needs to happen next, despite reading all of
> https://cygwin.com/setup.html several times. Do I need another GTG
> for the slightly-modified version I posted?

GTG from me (unless the rules get slightly relaxed since you're just
taking over you'd need five votes).

Note: You should perhaps remove the "keepdir" that preserves the
/usr/lib/p7zip/Codecs directory.  This drops a zero-size .keep-p7zip
file in there that elicits a warning from p7zip since it isn't a codec.
On the other hand, no warnings if the directory is simply missing and I
don't know of any package that tries to drop anything in there anyway.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: [ITA] p7zip

[Andrew Schulman]

> > Yes, there's ARCH, ARCH_i686, and ARCH_x86_64.  See
> > /usr/share/doc/cygport/manual.html.
> 
> Thanks, that's a great resource. I'm used to long-form docs being
> online somewhere rather than already installed along with the package.
> 
> I'm a bit unclear what needs to happen next, despite reading all of
> https://cygwin.com/setup.html several times. Do I need another GTG
> for the slightly-modified version I posted? Or do I just ask "please
> upload" for that set of files now?

Ah, okay.  No, unfortunately that page has fallen out of date with current
practice.  Sorry about that.

Package maintainers now upload their own packages.  The procedure is
described at https://sourceware.org/cygwin-apps/package-upload.html.

In your request for upload privileges, be sure to mention that you're
adopting p7zip, so you get listed as maintainer for that and will be
allowed to upload it.

Andrew

Re: [ITA] p7zip

[Tony Kelman]

> Yes, there's ARCH, ARCH_i686, and ARCH_x86_64.  See
> /usr/share/doc/cygport/manual.html.

Thanks, that's a great resource. I'm used to long-form docs being
online somewhere rather than already installed along with the package.

I'm a bit unclear what needs to happen next, despite reading all of
https://cygwin.com/setup.html several times. Do I need another GTG
for the slightly-modified version I posted? Or do I just ask "please
upload" for that set of files now?

https://ci.appveyor.com/api/buildjobs/76tibkftkdcnehl2/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1.tar.xz
https://ci.appveyor.com/api/buildjobs/76tibkftkdcnehl2/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1-src.tar.xz
https://ci.appveyor.com/api/buildjobs/76tibkftkdcnehl2/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/setup.hint

-Tony

Re: [ITA] p7zip

[Andrew Schulman]

> On the topic of cygport, is there a variable that indicates whether --32 or
> --64 was specified?

Yes, there's ARCH, ARCH_i686, and ARCH_x86_64.  See
/usr/share/doc/cygport/manual.html.

Re: [ITA] p7zip

[Tony Kelman]

> Rather than changing the upstream source tarball, you can add something 
> like:
>
> CYGPORT_USE_UNSTABLE_API=1
> src_unpack_hook() {
>        dos2unix man1/7zr.1
> }

Ah, great, thanks, I was wondering if there was something like that in 
cygport.
Now I know.

On the topic of cygport, is there a variable that indicates whether --32 or
--64 was specified? I tried building a 32 bit version of the package from
within 64 bit Cygwin to see if it would work, and it didn't quite come out
right. I imagine some more configuration in the cygport steps would be
necessary to really get that sorted.

> /usr/share/doc/Cygwin/p7zip.README is still about 9.20.1-1. Since this
> file is no longer mandatory, you may remove it rather than updating it.

Was also wondering about that. I could update the maintainer, and/or bump
the -1 version number to reflect my small packaging updates. Wasn't sure on
the best approach since the package has not been uploaded as 64 bit yet.
If there are bug reports or a reason to rebuild the 32 bit version I could,
but the existing version seems to be working fine so I wasn't in a hurry
there. Upstream hasn't released new sources in a long time either, I don't
expect updated versions to be very frequent.

New build with your suggested changes:
https://ci.appveyor.com/api/buildjobs/76tibkftkdcnehl2/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1.tar.xz
https://ci.appveyor.com/api/buildjobs/76tibkftkdcnehl2/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/p7zip-9.20.1-1-src.tar.xz
https://ci.appveyor.com/api/buildjobs/76tibkftkdcnehl2/artifacts/p7zip-9.20.1-1.x86_64/dist/p7zip/setup.hint

-Tony