From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6208 invoked by alias); 15 Sep 2017 16:53:07 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 6189 invoked by uid 89); 15 Sep 2017 16:53:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1540, our, HContent-Transfer-Encoding:8bit X-HELO: limerock01.mail.cornell.edu Received: from limerock01.mail.cornell.edu (HELO limerock01.mail.cornell.edu) (128.84.13.241) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Sep 2017 16:53:04 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v8FGr2nT003741; Fri, 15 Sep 2017 12:53:02 -0400 Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v8FGr0qu003127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 15 Sep 2017 12:53:01 -0400 Subject: Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) To: Jon Turney , cygwin-apps@cygwin.com References: <20170531105015.162228-1-jon.turney@dronecode.org.uk> <488ba627-de58-ddc7-7f69-696adae76b8a@cornell.edu> <9bcf50cf-81bc-c9d1-3ac3-b7e1a3522045@dronecode.org.uk> From: Ken Brown Message-ID: <5441628f-a99a-1611-616a-da98ea9a0e12@cornell.edu> Date: Fri, 15 Sep 2017 16:53:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <9bcf50cf-81bc-c9d1-3ac3-b7e1a3522045@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00022.txt.bz2 On 9/15/2017 11:15 AM, Jon Turney wrote: > On 08/09/2017 19:54, Ken Brown wrote: >> Finally, I have a question for you, Jon: You introduced >> PrereqChecker::upgrade, which is true if and only if the user selects >> Current or Test.  I don't see why this is needed.  I've disabled the >> use of it and haven't noticed any ill effects.  Am I missing something? > > This is supposed to be passed into SolverSolution::update() and used to > determine if a SOLVER_UPDATE | SOLVER_SOLVABLE_ALL task is given to the > solver, causing all packages to be updated (if possible) (i.e. so 'Keep' > doesn't update anything) I've already arranged (by using SOLVER_LOCK) that 'Keep' doesn't update anything. So I don't think we need to worry about that case. On the other hand, if 'Current' or 'Test' is selected, then we already upgrade as appropriate in the task list sent to the solver, so I don't think it's necessary to send SOLVER_UPDATE | SOLVER_SOLVABLE_ALL to the solver in that case either. Anyway, as I said, I've already disabled the use of PrereqChecker::upgrade. More precisely, I've changed SolverSolution::update so that it never sends SOLVER_UPDATE | SOLVER_SOLVABLE_ALL. As a result, PrereqChecker::upgrade is simply ignored, and everything seems to be working OK. > I guess the UI could be improved to make the choice of 'Keep' or > 'Current' ('Update') orthogonal to 'Use test packages?' I'm not seeing a problem here, but maybe I'm misunderstanding you. Ken