From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47733 invoked by alias); 17 Feb 2016 14:23:50 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 47622 invoked by uid 89); 17 Feb 2016 14:23:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-languages-length:3081, Ruby, ruby, colon X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Feb 2016 14:23:48 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id F258E20943 for ; Wed, 17 Feb 2016 09:23:44 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Wed, 17 Feb 2016 09:23:44 -0500 Received: from [192.168.1.102] (host86-141-131-217.range86-141.btcentralplus.com [86.141.131.217]) by mail.messagingengine.com (Postfix) with ESMTPA id 9288FC00014 for ; Wed, 17 Feb 2016 09:23:44 -0500 (EST) From: Jon Turney Subject: Re: setup.hint documentation issues To: cygwin-apps@cygwin.com References: <56B9E71A.7010002@dronecode.org.uk> <20160209171010.GC25261@calimero.vinschen.de> Message-ID: <56C4826A.4080907@dronecode.org.uk> Date: Wed, 17 Feb 2016 14:23:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160209171010.GC25261@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00041.txt.bz2 On 09/02/2016 17:10, Corinna Vinschen wrote: > On Feb 9 13:18, Jon Turney wrote: >> * 'sdesc' text is mangled in setup.ini (but not the HTML package list) >> >> In particular, it is forced to start with a capital letter (which is >> incorrect when the sdesc starts with a command name which is properly >> lower-case, e.g. "dash shell", etc.), and any text up to and including the >> first colon is removed, presumably in an effort to prevent people writing >> the package name again, (which mangles perl and ruby module names in the >> description, e.g. "Ruby Net::HTTP persistent connection support", ""Perl >> Math::Int64 distribution", etc.) >> >> I'd suggest this mangling is removed, and sdesc starting "packagename:" is >> explicitly reported. > > Sounds good, but where is this mangling performed? Upset? Yes, upset currently does this mangling. >> * Handling of double-quoted text seems over-complicated >> >> A multi-line double-quoted value is terminated only by a double-quote at the >> end of the line, and embedded double-quotes are silently transformed to >> single-quotes (e.g proj had a sdesc of ""The PROJ Cartographic Projections >> Software (utilities)", where the erroneous nested double-quote was being >> transformed to a single-quote) >> >> There is no escaping of embedded double-quotes, and no way to represent one. >> >> Additionally, spaces after the leading quote are magically removed. >> >> Additionally, genini requires that sdesc and ldesc are double-quoted, but >> upset does not. >> >> I'd suggest that double-quoting of those keys is made mandatory, and >> embedded double-quotes are forbidden, as this permits simpler processing of >> this text, lexing character by character. > > What about existing packages? I've fixed the existing uses on sourceware (which were proj and I think one other package I unfortunately didn't take note of) >> * It's not very clear what 'skip' represents >> >> The description "The skip line indicates that that package should not appear >> in setup. It is intended for directories that exist in the hierarchy that >> should not be considered." is a bit vague to me. >> >> It's not totally clear if it's intended for indicating directories which >> should be empty, source-only packages, or something else. >> >> upset knows enough to omit packages which have no install tarfiles (i.e. are >> source-only) from from setup.ini, irrespective of 'skip'. >> >> However, the presence of 'skip' also causes the package to be omitted from >> the HTML package list. >> >> I think cygport's behaviour has changed over time, but currently will mark >> source-packages as 'skip', however there are several packages that are >> source-only (e.g. attica), that are missing 'skip'. > > IMHO we don't need "skip". A source-only package should be > automatically skipped anyway. What other reason do we need to ignore > a package? Yes, this is why I ask the question. I don't see what 'skip' adds above automatically noticing that there are no install tar files, only source tar files.