From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.8
Date: Sat, 19 Mar 2016 12:34:00 -0000 [thread overview]
Message-ID: <56ED4764.4090007@cornell.edu> (raw)
In-Reply-To: <20160319103209.GE11113@calimero.vinschen.de>
On 3/19/2016 6:32 AM, Corinna Vinschen wrote:
> On Mar 18 22:24, Ken Brown wrote:
>> On 3/18/2016 7:29 PM, Yaakov Selkowitz wrote:
>>> On 2016-03-18 18:05, Yaakov Selkowitz wrote:
>>>> On 2016-03-18 17:25, Ken Brown wrote:
>>>>> On 3/18/2016 5:45 PM, Corinna Vinschen wrote:
>>>>>> On Mar 18 16:58, Ken Brown wrote:
>>>>>>> On 3/18/2016 4:34 PM, Corinna Vinschen wrote:
>>>>>>>> I released a new Cygwin TEST version 2.5.0-0.8.
>>>>>>>>
>>>>>>>> If things are not going very wrong, this is basically what you'll
>>>>>>>> get as 2.5.0-1 release. Please, please test and report regressions.
>>>>>>>
>>>>>>> Does this release include Yaakov's overhaul of the feature test
>>>>>>> macros?
>>>>>>
>>>>>> Sorry, I completely forgot to metion this in my release mail, which
>>>>>> is especially weird because I created this test release to allow
>>>>>> testing
>>>>>> the new feature test macros in the first place. Sorry!
>>>>>
>>>>> The problem I reported in
>>>>> https://www.cygwin.com/ml/cygwin/2015-12/msg00183.html has reappeared.
>>>>> It looks like your fix
>>>>> (https://www.cygwin.com/ml/cygwin/2015-12/msg00199.html) got reverted.
>>>>
>>>> The commit message for removing the include did not indicate what
>>>> prompted it. However, the include is necessary for BSD compatibility,
>>>> and other software fails to build without it.
>>>>
>>>> I would look into emacs and see what feature test macro(s) they enable
>>>> on *Linux*, and use the same for Cygwin.
>>>
>>> Might this be it?
>>>
>>> http://git.savannah.gnu.org/cgit/emacs.git/tree/lib/sys_select.in.h
>>
>> This file is part of the Gnulib module that I mentioned in the thread I
>> cited above.
>>
>>> There's some seriously hackish things going on in that file, some of
>>> them Cygwin specific.
>>
>> I think such things are often necessary in Gnulib, but I'll leave it to Eric
>> to comment further. In any case, Eric said in our original discussion that
>> there might be a Gnulib fix for this problem, but then he and Corinna ended
>> up deciding it was better to remove the include.
>
> Glibc uses __USE_MISC to guard the inclusion of sys/select.h, newlib's
> header uses __BSD_VISIBLE which is almost the same. But we have the
> equivalent __MISC_VISIBLE as well. Do you want to change that, Yaakov?
>
> The discussion with Eric was about the POSIX-ness and at the time it
> seemed like the simplest solution to remove the include. But Yaakov
> is right. If it's the right thing to do for Glibc to include it
> with careful guarding, it should be the right thing for us as well.
So I think that means we're back to looking for a Gnulib solution.
Eric, can you follow up on that?
Ken
next prev parent reply other threads:[~2016-03-19 12:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <announce.20160318203409.GA11113@calimero.vinschen.de>
[not found] ` <56EC6BDA.7050505@cornell.edu>
2016-03-18 21:45 ` Corinna Vinschen
2016-03-18 22:25 ` Ken Brown
2016-03-18 22:40 ` Ken Brown
2016-03-18 23:05 ` Yaakov Selkowitz
2016-03-18 23:29 ` Yaakov Selkowitz
2016-03-19 2:24 ` Ken Brown
2016-03-19 10:32 ` Corinna Vinschen
2016-03-19 12:34 ` Ken Brown [this message]
2016-03-19 18:03 ` Ken Brown
2016-03-20 15:26 ` Corinna Vinschen
2016-03-20 19:27 ` Ken Brown
2016-03-20 19:40 ` Ken Brown
2016-03-20 20:18 ` Ken Brown
2016-03-20 20:47 ` Yaakov Selkowitz
2016-03-21 14:13 ` Ken Brown
2016-03-21 16:30 ` Corinna Vinschen
2016-03-21 17:59 ` Ken Brown
2016-03-22 11:15 ` Corinna Vinschen
2016-03-22 14:59 ` Ken Brown
2016-03-30 21:17 ` Corinna Vinschen
2016-03-31 11:55 ` Ken Brown
2016-03-20 4:50 ` Yaakov Selkowitz
2016-03-20 15:18 ` Corinna Vinschen
2016-03-20 10:59 ` Achim Gratz
2016-03-20 11:14 ` Marco Atzeri
2016-03-20 15:25 ` Corinna Vinschen
2016-03-20 19:27 ` Achim Gratz
2016-03-20 20:53 ` Corinna Vinschen
2016-03-20 21:30 ` Corinna Vinschen
2016-03-20 20:24 ` Achim Gratz
2016-03-20 20:45 ` Yaakov Selkowitz
2016-03-22 9:31 ` Achim Gratz
2016-03-25 9:00 ` Dodgy functions (was: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.8) Achim Gratz
2016-03-26 0:16 ` Dodgy functions Achim Gratz
2016-03-26 19:41 ` Dodgy functions (finitel, strold) Achim Gratz
2016-03-29 16:09 ` Doug Henderson
2016-03-29 16:09 ` Corinna Vinschen
2016-04-01 19:04 ` Achim Gratz
2016-03-22 17:43 ` [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.8 Chris Sutcliffe
2016-03-22 18:02 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ED4764.4090007@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).