public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Christian Franke <Christian.Franke@t-online.de>
Cc: cygwin-apps@cygwin.com
Subject: Re: [ITP] afflib 3.7.20-1
Date: Wed, 6 Mar 2024 20:50:29 +0000	[thread overview]
Message-ID: <57ddebc4-8949-45a3-970d-68d01159053f@dronecode.org.uk> (raw)
In-Reply-To: <8a58c2fe-ec47-2d98-8750-96ddc647b2d2@t-online.de>

On 06/03/2024 15:39, Christian Franke via Cygwin-apps wrote:
> Jon Turney wrote:
>>
>> Thanks!
>>
>>>
>>> libafflib_CONTENTS="
>>>     usr/bin/cygafflib-*.dll
>>
>> Any reason why this package doesn't include the soversion, i.e. why 
>> not libafflib0?
>>
> 
> Libtsk and libafflib are my first library packages, so I'm not sure what 
> the policy is. My recent package libtsk has been accepted without 
> soversion, so I omitted it also here. I assumed that the soversion will 

I'm going to suggest that was an oversight in the review.

> be added only when needed for new not backward compatible releases. The 
> upstream afflib project is mostly idling, so I don't expect any new 
> major lib versions in the near future.
> 
> If course, I could rename it to libafflib0 if desired.

As far as I know, there is no cost for doing this, and it saves grief if 
upstream ever bumps the soversion.

Also, it's probably best to explicitly list the filename with soversion 
in the CONTENTS, so that if upstream ever does change the soversion, it 
will be detected as a packaging failure, rather than producing a package 
with a mismatch between the soversion in it's name and in it's contents.

(Cygport should perhaps and detect and warn about apparently soversioned 
libraries that aren't in appropriately named packages, but...)


  reply	other threads:[~2024-03-06 20:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 13:53 Christian Franke
2024-03-06 14:31 ` Jon Turney
2024-03-06 15:39   ` Christian Franke
2024-03-06 20:50     ` Jon Turney [this message]
2024-03-06 22:26       ` Christian Franke
2024-03-07  5:43         ` marco atzeri
2024-03-08  8:53           ` Christian Franke
2024-03-22 18:45             ` Christian Franke
2024-03-21  9:04         ` Christian Franke
2024-03-21 16:09           ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57ddebc4-8949-45a3-970d-68d01159053f@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=Christian.Franke@t-online.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).