From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-048.btinternet.com (mailomta2-re.btinternet.com [213.120.69.95]) by sourceware.org (Postfix) with ESMTPS id 503393858028 for ; Sun, 25 Jun 2023 13:36:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 503393858028 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-001.btmx-prd.synchronoss.net ([10.2.54.4]) by re-prd-fep-048.btinternet.com with ESMTP id <20230625133617.UCGO17945.re-prd-fep-048.btinternet.com@re-prd-rgout-001.btmx-prd.synchronoss.net>; Sun, 25 Jun 2023 14:36:17 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 63F6BC5E0E1EE20D X-Originating-IP: [81.129.146.215] X-OWM-Source-IP: 81.129.146.215 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehtddgieehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepueeujedtkeelteeggedtkefhhfdtudfhgffhgffgteehieevtdefudejieegvdehnecuffhomhgrihhnpehgihhthhhusgdrtghomhdptgihghifihhnrdgtohhmnecukfhppeekuddruddvledrudegiedrvdduheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduvdelrddugeeirddvudehpdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgtphhtthhopehtohifohesthhofihordhnvghtpdhrvghvkffrpehhohhsthekuddquddvledqudegiedqvdduhedrrhgrnhhgvgekuddquddvledrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhnthgv rhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhstheprhgvqdhprhguqdhrghhouhhtqddttddu X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.129.146.215) by re-prd-rgout-001.btmx-prd.synchronoss.net (5.8.814) (authenticated as jonturney@btinternet.com) id 63F6BC5E0E1EE20D; Sun, 25 Jun 2023 14:36:17 +0100 Message-ID: <582b84f6-b7e0-9f2b-4b41-828d500b923c@dronecode.org.uk> Date: Sun, 25 Jun 2023 14:36:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [ITP] italic-man Content-Language: en-GB To: Thomas Wolff , "cygwin-apps@cygwin.com" References: <711af07e-46e4-4d3b-b28a-a64e37284d55@towo.net> <58be0826-44fc-4ac1-9d37-f66fdd28ef79@towo.net> From: Jon Turney In-Reply-To: <58be0826-44fc-4ac1-9d37-f66fdd28ef79@towo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/06/2023 22:45, Thomas Wolff via Cygwin-apps wrote: > > Am 16.02.2023 um 20:17 schrieb Thomas Wolff via Cygwin-apps: >> >> Am 16.02.2023 um 19:59 schrieb Jon Turney: >>> On 21/01/2023 17:04, Thomas Wolff via Cygwin-apps wrote: >>>> italic-man installs two scripts and hooks them into the workflow of >>>> the 'man' command so that the italic attribute of manual pages is >>>> actually displayed as italics in terminals that support it. >>>> >>>> cygport file attached >>> >>> Thanks very much for having another go at this. >>> >>> I'm still not overly keen on postinstall/preremove scripts which >>> modify a configuration file belonging to another package, so I think >>> I'm going to defer to Achim on approving this. >>> >>> Taking a step back, may I ask a couple of questions? >>> >>> - Can this be done as a patch to man-db and/or groff? >>> >>> (perhaps with a separate man-italic package which just contains a >>> marker file which enables the functionality?) >>> >>> - (If different) how would this be done in an upstreamable way? >> Thanks for taking a look. >> I understand your hesitation but there are a number of zp_ postinstall >> scripts around that make updates to mandb, mime db, desktop, various >> caches, maybe crontab. There's a difference between updating a cache or db of files which exist on the filesystem after the package update and modifying a file which might be overwritten by reinstalling or updating a different package. >> Well, yes, there could be a zp_ script for man that makes this entry >> to /etc/man_db.conf itself in the presence of the italic-man package. >> If that's desired and someone else updates man, I will cooperate on this. >> I think the installation of italic-man does this in an upstreamable >> way except for the postinstall mechanism of course which seems to be >> different (if existent at all) everywhere. >> Thomas > I've added a zp_man-db-italic.dash postinstall script as a proposal for > man-db to address your concerns, to be found in the repository > github.com/mintty/italic-man. However, I find not documentation about > these zp_ things, it seems they are just all called after each setup. So They are briefly covered in [1]. If that's missing some details, please let me know and I'll see what can be done to improve it. [1] https://cygwin.com/packaging-package-files.html#postinstall > would it actually make a difference whether the zp_ is a script of > italic-man or of man-db? I've also added a cygport file to the > repository so you can try the update if you like. > About your first question >> - Can this be done as a patch to man-db and/or groff? > Do you mean the whole thing should not be a separate package at all but > completely patched into man-db? Well, yes, that would avoid all the knots caused by post-install scripts with uncertain ordering I'm worrying about. Can you explain, in general terms, why this isn't a feature of stock man-db already? > Looking forward to your opinion and that of the man-db package maintainer. > And yes, the hook works on Linux too, so it could be provided somehow > upstream. Thanks continuing to grind away at this.