From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-045.btinternet.com (mailomta27-sa.btinternet.com [213.120.69.33]) by sourceware.org (Postfix) with ESMTPS id 282FD3858D20 for ; Sat, 28 Jan 2023 16:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 282FD3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.38.5]) by sa-prd-fep-045.btinternet.com with ESMTP id <20230128162435.NCSW5235.sa-prd-fep-045.btinternet.com@sa-prd-rgout-002.btmx-prd.synchronoss.net>; Sat, 28 Jan 2023 16:24:35 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139417C4D881E72 X-Originating-IP: [81.153.98.246] X-OWM-Source-IP: 81.153.98.246 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedruddvkedgkeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeehudeuveeujeeujeegueefhedttdekvedtudeileefteetfeefjeejudekfefggfenucffohhmrghinheptgihghifihhnrdgtohhmnecukfhppeekuddrudehfedrleekrddvgeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddvgeeipdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgtphhtthhopehtrghkrghshhhirdihrghnohesnhhifhhthidrnhgvrdhjph X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.246) by sa-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139417C4D881E72; Sat, 28 Jan 2023 16:24:35 +0000 Message-ID: <5a95e243-abb0-64e2-7959-106bc6b1af21@dronecode.org.uk> Date: Sat, 28 Jan 2023 16:24:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [ITA] SDL2 (2.26.2) Content-Language: en-GB To: Takashi Yano , "cygwin-apps@cygwin.com" References: <20230120193525.ff89fed0f8bf788405537af8@nifty.ne.jp> <20230122210550.0c7fa8aedaa8ebf7dc772dbc@nifty.ne.jp> From: Jon Turney In-Reply-To: <20230122210550.0c7fa8aedaa8ebf7dc772dbc@nifty.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1191.9 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,SUBJ_ALL_CAPS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/01/2023 12:05, Takashi Yano via Cygwin-apps wrote: > On Sat, 21 Jan 2023 14:58:55 +0000 > Jon Turney wrote: >> You've made some changes in the configuration here (switching from >> enabling pulseaudio to oss) >> >> I think you've also dropped the winmm patch. >> >> I don't understand enough to evaluate the correctness those changes, so >> it would be nice if you could explain that to me. > > Thanks for reviewing. The reason why I turnd off pulseaudio > is that the latency was unacceptably large, despite the fact > that pulseaudio is preferred over other sound drivers. > Due to this, ffplay missynchronized sound with video. > > Also, I guess OSS was previously disabled because it does not > work as expected due to a bug of cygwin: > https://cygwin.com/pipermail/cygwin-patches/2023q1/012134.html > and winmm was enabled instead. > > Now, the bug has been fixed and SDL2 gets working with OSS. > Therefore, we don't need winmm support anymore. I think > it is better not to call winmm directly from cygwin apps. > > BTW, I tried to modify SDL2 code to minimize the latency of > pulseaudio and it succeeded. So, I re-enabled the pulseaudio > and updated the package. > > Could you please review the package again? Thanks for this explanation, it all makes sense now. Please go ahead.