From: Brian Inglis <Brian.Inglis@Shaw.ca>
To: cygwin-apps@cygwin.com
Subject: Re: [ITA] libvpx
Date: Fri, 27 Oct 2023 13:01:51 -0600 [thread overview]
Message-ID: <60623de9-39f1-4bfd-add2-55dec6a3f033@Shaw.ca> (raw)
In-Reply-To: <d1e1c7ba-f2f3-4aa4-aa22-6013f98ad899@dronecode.org.uk>
On 2023-10-27 09:19, Jon Turney via Cygwin-apps wrote:
> On 26/10/2023 16:56, Brian Inglis via Cygwin-apps wrote:
>> Hi folks,
>>
>> I have built an updated release of libvpx with the CVE fixes included.
>> This is a Google WebM project which does not use autotools or libtool, so the
>> last maintainer did their own cygvpx dll build and relinked the executables.
>
> Taking a brief look over the cygport, if you're going to abstract out the
> soversion, you can use 'declare' to evaluate variable names
>
> e.g.
>
> ABI=8
> PKG_NAMES="... libvpx${ABI} ..."
> declare libvpx${ABI}_SUMMARY="$SUMMARY (runtime)"
> declare libvpx${ABI}_CONTENTS="usr/bin/cygvpx-${ABI}.dll"
Thanks Jon,
I never realized that, so will now be using it in a number of packages where ABI
changes occur.
>> The current test programs do not relink against the unstripped dll, possibly
>> because of their sizes requiring > 32 bit offsets, so I am no longer relinking
>> the test programs with the dll, only the distributed utilities.
>>
>> $ du libvpx-1.13.1-1.x86_64/{build,inst/usr/bin}/*.{dll,exe}
>> 23M libvpx-1.13.1-1.x86_64/build/cygvpx-8.dll
>> 26M libvpx-1.13.1-1.x86_64/build/test_intra_pred_speed.exe
>> 158M libvpx-1.13.1-1.x86_64/build/test_libvpx.exe
>> 33M libvpx-1.13.1-1.x86_64/build/test_rc_interface.exe
>> 3.3M libvpx-1.13.1-1.x86_64/build/vpxdec.exe
>> 3.5M libvpx-1.13.1-1.x86_64/build/vpxenc.exe
>> 3.4M libvpx-1.13.1-1.x86_64/inst/usr/bin/cygvpx-8.dll
>> 680K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxdec.exe
>> 700K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxenc.exe
>>
>> With codec performance tests disabled, this build also downloads 1.4GB of test
>> data files from Google under:
>>
>> https://storage.googleapis.com/downloads.webmproject.org/test_data/libvpx/
>>
>> which we presumably would prefer not to include in the src package, to
>
> Yeah, including it seems a bad idea.
>
>> run tests which take 2.75-3.5 hours out of a 3.75-4.5 hour build, with 5
>> failures in scallywag CI and 2 failures locally out of 1596 tests, shown in
>> the attached log, so I have questions into the upstream WebM libvpx project
>> about those.
>>
>> Full scallywag logs are available at:
>>
>> https://cygwin.com/cgi-bin2/jobs.cgi?id=7148&srcpkg=libvpx&user=Brian+Inglis
>
> Thanks.
>
> I've added this to your packages.
Cheers!
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut
-- Antoine de Saint-Exupéry
prev parent reply other threads:[~2023-10-27 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:56 Brian Inglis
2023-10-27 15:19 ` Jon Turney
2023-10-27 19:01 ` Brian Inglis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60623de9-39f1-4bfd-add2-55dec6a3f033@Shaw.ca \
--to=brian.inglis@shaw.ca \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).