* [ITA] libvpx
@ 2023-10-26 15:56 Brian Inglis
2023-10-27 15:19 ` Jon Turney
0 siblings, 1 reply; 3+ messages in thread
From: Brian Inglis @ 2023-10-26 15:56 UTC (permalink / raw)
To: Cygwin Apps
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
Hi folks,
I have built an updated release of libvpx with the CVE fixes included.
This is a Google WebM project which does not use autotools or libtool, so the
last maintainer did their own cygvpx dll build and relinked the executables.
The current test programs do not relink against the unstripped dll, possibly
because of their sizes requiring > 32 bit offsets, so I am no longer relinking
the test programs with the dll, only the distributed utilities.
$ du libvpx-1.13.1-1.x86_64/{build,inst/usr/bin}/*.{dll,exe}
23M libvpx-1.13.1-1.x86_64/build/cygvpx-8.dll
26M libvpx-1.13.1-1.x86_64/build/test_intra_pred_speed.exe
158M libvpx-1.13.1-1.x86_64/build/test_libvpx.exe
33M libvpx-1.13.1-1.x86_64/build/test_rc_interface.exe
3.3M libvpx-1.13.1-1.x86_64/build/vpxdec.exe
3.5M libvpx-1.13.1-1.x86_64/build/vpxenc.exe
3.4M libvpx-1.13.1-1.x86_64/inst/usr/bin/cygvpx-8.dll
680K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxdec.exe
700K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxenc.exe
With codec performance tests disabled, this build also downloads 1.4GB of test
data files from Google under:
https://storage.googleapis.com/downloads.webmproject.org/test_data/libvpx/
which we presumably would prefer not to include in the src package, to run tests
which take 2.75-3.5 hours out of a 3.75-4.5 hour build, with 5 failures in
scallywag CI and 2 failures locally out of 1596 tests, shown in the attached
log, so I have questions into the upstream WebM libvpx project about those.
Full scallywag logs are available at:
https://cygwin.com/cgi-bin2/jobs.cgi?id=7148&srcpkg=libvpx&user=Brian+Inglis
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut
-- Antoine de Saint-Exupéry
[-- Attachment #2: libvpx-pass-fail.log --]
[-- Type: text/plain, Size: 9951 bytes --]
scallywag.log-2023-10-26T06:49:56.3847823Z [==========] 1597 tests from 163 test suites ran. (889622 ms total)
scallywag.log:2023-10-26T06:49:56.3848609Z [ PASSED ] 1597 tests.
scallywag.log-2023-10-26T06:49:56.3849022Z
--
scallywag.log-2023-10-26T07:06:38.7784829Z Expected: (vd) != (0), actual: 0 vs 0
scallywag.log:2023-10-26T07:06:38.7786023Z [ FAILED ] SSE2/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x1008fb000) (0 ms)
scallywag.log-2023-10-26T07:06:38.7787128Z [----------] 1 test from SSE2/AddNoiseTest (0 ms total)
--
scallywag.log-2023-10-26T07:06:38.8239538Z [==========] 1597 tests from 165 test suites ran. (1002125 ms total)
scallywag.log:2023-10-26T07:06:38.8240341Z [ PASSED ] 1596 tests.
scallywag.log:2023-10-26T07:06:38.8240938Z [ FAILED ] 1 test, listed below:
scallywag.log:2023-10-26T07:06:38.8241955Z [ FAILED ] SSE2/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x1008fb000)
scallywag.log-2023-10-26T07:06:38.8242868Z
scallywag.log:2023-10-26T07:06:38.8243108Z 1 FAILED TEST
scallywag.log-2023-10-26T07:06:38.8243606Z YOU HAVE 97 DISABLED TESTS
--
scallywag.log-2023-10-26T07:23:13.7914593Z [==========] 1597 tests from 164 test suites ran. (994656 ms total)
scallywag.log:2023-10-26T07:23:13.7915396Z [ PASSED ] 1597 tests.
scallywag.log-2023-10-26T07:23:13.7915791Z
--
scallywag.log-2023-10-26T07:36:17.7847729Z Actual: it does.
scallywag.log:2023-10-26T07:36:17.8969258Z [ FAILED ] VP9/RealtimeTest.IntegerOverflowLarge/0, where GetParam() = (0x100c7c9b8, 0) (3454 ms)
scallywag.log-2023-10-26T07:36:17.8973043Z [----------] 1 test from VP9/RealtimeTest (3454 ms total)
--
scallywag.log-2023-10-26T07:39:15.0357677Z [==========] 1597 tests from 165 test suites ran. (960935 ms total)
scallywag.log:2023-10-26T07:39:15.0358589Z [ PASSED ] 1596 tests.
scallywag.log:2023-10-26T07:39:15.0359197Z [ FAILED ] 1 test, listed below:
scallywag.log:2023-10-26T07:39:15.0360270Z [ FAILED ] VP9/RealtimeTest.IntegerOverflowLarge/0, where GetParam() = (0x100c7c9b8, 0)
scallywag.log-2023-10-26T07:39:15.0361191Z
scallywag.log:2023-10-26T07:39:15.0361456Z 1 FAILED TEST
scallywag.log-2023-10-26T07:39:15.0361945Z YOU HAVE 15 DISABLED TESTS
--
scallywag.log-2023-10-26T07:39:20.4125625Z Actual: it does.
scallywag.log:2023-10-26T07:39:20.5227861Z [ FAILED ] VP9FrameSizeTestsLarge.TestInvalidSizes (3469 ms)
scallywag.log-2023-10-26T07:39:20.5229526Z [----------] 1 test from VP9FrameSizeTestsLarge (3469 ms total)
--
scallywag.log-2023-10-26T07:52:46.8055133Z [==========] 1597 tests from 162 test suites ran. (811457 ms total)
scallywag.log:2023-10-26T07:52:46.8056250Z [ PASSED ] 1596 tests.
scallywag.log:2023-10-26T07:52:46.8056874Z [ FAILED ] 1 test, listed below:
scallywag.log:2023-10-26T07:52:46.8057672Z [ FAILED ] VP9FrameSizeTestsLarge.TestInvalidSizes
scallywag.log-2023-10-26T07:52:46.8058333Z
scallywag.log:2023-10-26T07:52:46.8058581Z 1 FAILED TEST
scallywag.log-2023-10-26T07:52:46.8059085Z YOU HAVE 631 DISABLED TESTS
--
scallywag.log-2023-10-26T07:52:52.4338374Z Actual: it does.
scallywag.log:2023-10-26T07:52:52.5424917Z [ FAILED ] VP9FrameSizeTestsLarge.ValidSizes (3445 ms)
scallywag.log-2023-10-26T07:52:52.5426437Z [----------] 1 test from VP9FrameSizeTestsLarge (3445 ms total)
--
scallywag.log-2023-10-26T08:06:14.6959685Z [==========] 1596 tests from 164 test suites ran. (807585 ms total)
scallywag.log:2023-10-26T08:06:14.6960659Z [ PASSED ] 1595 tests.
scallywag.log:2023-10-26T08:06:14.6961145Z [ FAILED ] 1 test, listed below:
scallywag.log:2023-10-26T08:06:14.6969399Z [ FAILED ] VP9FrameSizeTestsLarge.ValidSizes
scallywag.log-2023-10-26T08:06:14.6969947Z
scallywag.log:2023-10-26T08:06:14.6970151Z 1 FAILED TEST
scallywag.log-2023-10-26T08:06:14.6970546Z YOU HAVE 163 DISABLED TESTS
--
scallywag.log-2023-10-26T08:20:50.3011841Z [==========] 1596 tests from 165 test suites ran. (875296 ms total)
scallywag.log:2023-10-26T08:20:50.3012854Z [ PASSED ] 1596 tests.
scallywag.log-2023-10-26T08:20:50.3013258Z
--
scallywag.log-2023-10-26T08:38:17.7423973Z Expected: (vd) != (0), actual: 0 vs 0
scallywag.log:2023-10-26T08:38:17.7424904Z [ FAILED ] C/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x100700050) (0 ms)
scallywag.log-2023-10-26T08:38:17.7425998Z [----------] 1 test from C/AddNoiseTest (0 ms total)
--
scallywag.log-2023-10-26T08:38:17.8020610Z [==========] 1596 tests from 163 test suites ran. (1047188 ms total)
scallywag.log:2023-10-26T08:38:17.8021335Z [ PASSED ] 1595 tests.
scallywag.log:2023-10-26T08:38:17.8021868Z [ FAILED ] 1 test, listed below:
scallywag.log:2023-10-26T08:38:17.8022773Z [ FAILED ] C/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x100700050)
scallywag.log-2023-10-26T08:38:17.8023539Z
scallywag.log:2023-10-26T08:38:17.8023756Z 1 FAILED TEST
scallywag.log-2023-10-26T08:38:17.8024196Z YOU HAVE 69 DISABLED TESTS
--
scallywag.log-2023-10-26T08:57:57.3695423Z [==========] 1596 tests from 162 test suites ran. (1179259 ms total)
scallywag.log:2023-10-26T08:57:57.3696297Z [ PASSED ] 1596 tests.
scallywag.log-2023-10-26T08:57:57.3696755Z
--
scallywag.log-2023-10-26T09:13:34.9618892Z [==========] 1596 tests from 158 test suites ran. (937281 ms total)
scallywag.log:2023-10-26T09:13:34.9619608Z [ PASSED ] 1595 tests.
scallywag.log-2023-10-26T09:13:34.9620115Z [ SKIPPED ] 1 test, listed below:
--
libvpx-cygport-64-all-check.log-00:58:30.011202 00:00:00.002063 [==========] 1596 tests from 167 test suites ran. (1006251 ms total)
libvpx-cygport-64-all-check.log:00:58:30.011279 00:00:00.000077 [ PASSED ] 1596 tests.
libvpx-cygport-64-all-check.log-00:58:30.011296 00:00:00.000017
--
libvpx-cygport-64-all-check.log-01:21:15.283605 00:00:00.000019 Expected: (vd) != (0), actual: 0 vs 0
libvpx-cygport-64-all-check.log:01:21:15.283641 00:00:00.000036 [ FAILED ] C/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x100700050) (0 ms)
libvpx-cygport-64-all-check.log-01:21:15.283672 00:00:00.000031 [----------] 1 test from C/AddNoiseTest (0 ms total)
--
libvpx-cygport-64-all-check.log-01:21:15.352063 00:00:00.002659 [==========] 1596 tests from 168 test suites ran. (1365001 ms total)
libvpx-cygport-64-all-check.log:01:21:15.352142 00:00:00.000079 [ PASSED ] 1595 tests.
libvpx-cygport-64-all-check.log:01:21:15.352162 00:00:00.000020 [ FAILED ] 1 test, listed below:
libvpx-cygport-64-all-check.log:01:21:15.352183 00:00:00.000021 [ FAILED ] C/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x100700050)
libvpx-cygport-64-all-check.log-01:21:15.352215 00:00:00.000032
libvpx-cygport-64-all-check.log:01:21:15.352228 00:00:00.000013 1 FAILED TEST
libvpx-cygport-64-all-check.log-01:21:15.352243 00:00:00.000016 YOU HAVE 86 DISABLED TESTS
--
libvpx-cygport-64-all-check.log-01:44:08.347529 00:00:00.002122 [==========] 1596 tests from 165 test suites ran. (1372657 ms total)
libvpx-cygport-64-all-check.log:01:44:08.347607 00:00:00.000078 [ PASSED ] 1596 tests.
libvpx-cygport-64-all-check.log-01:44:08.347623 00:00:00.000017
--
libvpx-cygport-64-all-check.log-02:04:52.801183 00:00:00.002619 [==========] 1596 tests from 163 test suites ran. (1244111 ms total)
libvpx-cygport-64-all-check.log:02:04:52.801257 00:00:00.000075 [ PASSED ] 1595 tests.
libvpx-cygport-64-all-check.log-02:04:52.801273 00:00:00.000016 [ SKIPPED ] 1 test, listed below:
--
libvpx-cygport-64-all-check.log-02:23:07.391824 00:00:00.019306 [==========] 1596 tests from 161 test suites ran. (1094248 ms total)
libvpx-cygport-64-all-check.log:02:23:07.391926 00:00:00.000102 [ PASSED ] 1596 tests.
libvpx-cygport-64-all-check.log-02:23:07.391946 00:00:00.000020
--
libvpx-cygport-64-all-check.log-02:43:47.078908 00:00:00.000074 Expected: (vd) != (0), actual: 0 vs 0
libvpx-cygport-64-all-check.log:02:43:47.078951 00:00:00.000044 [ FAILED ] SSE2/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x1008fb000) (17 ms)
libvpx-cygport-64-all-check.log-02:43:47.078999 00:00:00.000048 [----------] 1 test from SSE2/AddNoiseTest (17 ms total)
--
libvpx-cygport-64-all-check.log-02:43:47.149565 00:00:00.008889 [==========] 1596 tests from 161 test suites ran. (1239279 ms total)
libvpx-cygport-64-all-check.log:02:43:47.149639 00:00:00.000074 [ PASSED ] 1595 tests.
libvpx-cygport-64-all-check.log:02:43:47.149661 00:00:00.000022 [ FAILED ] 1 test, listed below:
libvpx-cygport-64-all-check.log:02:43:47.149683 00:00:00.000023 [ FAILED ] SSE2/AddNoiseTest.CheckNoiseAdded/1, where GetParam() = (4.4, 0x1008fb000)
libvpx-cygport-64-all-check.log-02:43:47.149716 00:00:00.000033
libvpx-cygport-64-all-check.log:02:43:47.149732 00:00:00.000016 1 FAILED TEST
libvpx-cygport-64-all-check.log-02:43:47.149751 00:00:00.000019 YOU HAVE 167 DISABLED TESTS
--
libvpx-cygport-64-all-check.log-03:04:15.193989 00:00:00.002410 [==========] 1596 tests from 162 test suites ran. (1227570 ms total)
libvpx-cygport-64-all-check.log:03:04:15.194067 00:00:00.000078 [ PASSED ] 1596 tests.
libvpx-cygport-64-all-check.log-03:04:15.194084 00:00:00.000017
--
libvpx-cygport-64-all-check.log-03:29:04.342736 00:00:00.015449 [==========] 1596 tests from 159 test suites ran. (1488792 ms total)
libvpx-cygport-64-all-check.log:03:29:04.342814 00:00:00.000078 [ PASSED ] 1596 tests.
libvpx-cygport-64-all-check.log-03:29:04.342831 00:00:00.000017
--
libvpx-cygport-64-all-check.log-03:49:12.449947 00:00:00.001979 [==========] 1596 tests from 158 test suites ran. (1207414 ms total)
libvpx-cygport-64-all-check.log:03:49:12.450020 00:00:00.000072 [ PASSED ] 1596 tests.
libvpx-cygport-64-all-check.log-03:49:12.450039 00:00:00.000020
--
libvpx-cygport-64-all-check.log-04:07:50.412238 00:00:00.001682 [==========] 1595 tests from 161 test suites ran. (1117620 ms total)
libvpx-cygport-64-all-check.log:04:07:50.412309 00:00:00.000071 [ PASSED ] 1595 tests.
libvpx-cygport-64-all-check.log-04:07:50.412331 00:00:00.000022
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ITA] libvpx
2023-10-26 15:56 [ITA] libvpx Brian Inglis
@ 2023-10-27 15:19 ` Jon Turney
2023-10-27 19:01 ` Brian Inglis
0 siblings, 1 reply; 3+ messages in thread
From: Jon Turney @ 2023-10-27 15:19 UTC (permalink / raw)
To: cygwin-apps, Brian Inglis
On 26/10/2023 16:56, Brian Inglis via Cygwin-apps wrote:
> Hi folks,
>
> I have built an updated release of libvpx with the CVE fixes included.
> This is a Google WebM project which does not use autotools or libtool,
> so the last maintainer did their own cygvpx dll build and relinked the
> executables.
Taking a brief look over the cygport, if you're going to abstract out
the soversion, you can use 'declare' to evaluate variable names
e.g.
ABI=8
PKG_NAMES="... libvpx${ABI} ..."
declare libvpx${ABI}_SUMMARY="$SUMMARY (runtime)"
declare libvpx${ABI}_CONTENTS="usr/bin/cygvpx-${ABI}.dll"
> The current test programs do not relink against the unstripped dll,
> possibly because of their sizes requiring > 32 bit offsets, so I am no
> longer relinking the test programs with the dll, only the distributed
> utilities.
>
> $ du libvpx-1.13.1-1.x86_64/{build,inst/usr/bin}/*.{dll,exe}
> 23M libvpx-1.13.1-1.x86_64/build/cygvpx-8.dll
> 26M libvpx-1.13.1-1.x86_64/build/test_intra_pred_speed.exe
> 158M libvpx-1.13.1-1.x86_64/build/test_libvpx.exe
> 33M libvpx-1.13.1-1.x86_64/build/test_rc_interface.exe
> 3.3M libvpx-1.13.1-1.x86_64/build/vpxdec.exe
> 3.5M libvpx-1.13.1-1.x86_64/build/vpxenc.exe
> 3.4M libvpx-1.13.1-1.x86_64/inst/usr/bin/cygvpx-8.dll
> 680K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxdec.exe
> 700K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxenc.exe
>
> With codec performance tests disabled, this build also downloads 1.4GB
> of test data files from Google under:
>
> https://storage.googleapis.com/downloads.webmproject.org/test_data/libvpx/
>
> which we presumably would prefer not to include in the src package, to
Yeah, including it seems a bad idea.
> run tests which take 2.75-3.5 hours out of a 3.75-4.5 hour build, with 5
> failures in scallywag CI and 2 failures locally out of 1596 tests, shown
> in the attached log, so I have questions into the upstream WebM libvpx
> project about those.
>
> Full scallywag logs are available at:
>
> https://cygwin.com/cgi-bin2/jobs.cgi?id=7148&srcpkg=libvpx&user=Brian+Inglis
Thanks.
I've added this to your packages.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ITA] libvpx
2023-10-27 15:19 ` Jon Turney
@ 2023-10-27 19:01 ` Brian Inglis
0 siblings, 0 replies; 3+ messages in thread
From: Brian Inglis @ 2023-10-27 19:01 UTC (permalink / raw)
To: cygwin-apps
On 2023-10-27 09:19, Jon Turney via Cygwin-apps wrote:
> On 26/10/2023 16:56, Brian Inglis via Cygwin-apps wrote:
>> Hi folks,
>>
>> I have built an updated release of libvpx with the CVE fixes included.
>> This is a Google WebM project which does not use autotools or libtool, so the
>> last maintainer did their own cygvpx dll build and relinked the executables.
>
> Taking a brief look over the cygport, if you're going to abstract out the
> soversion, you can use 'declare' to evaluate variable names
>
> e.g.
>
> ABI=8
> PKG_NAMES="... libvpx${ABI} ..."
> declare libvpx${ABI}_SUMMARY="$SUMMARY (runtime)"
> declare libvpx${ABI}_CONTENTS="usr/bin/cygvpx-${ABI}.dll"
Thanks Jon,
I never realized that, so will now be using it in a number of packages where ABI
changes occur.
>> The current test programs do not relink against the unstripped dll, possibly
>> because of their sizes requiring > 32 bit offsets, so I am no longer relinking
>> the test programs with the dll, only the distributed utilities.
>>
>> $ du libvpx-1.13.1-1.x86_64/{build,inst/usr/bin}/*.{dll,exe}
>> 23M libvpx-1.13.1-1.x86_64/build/cygvpx-8.dll
>> 26M libvpx-1.13.1-1.x86_64/build/test_intra_pred_speed.exe
>> 158M libvpx-1.13.1-1.x86_64/build/test_libvpx.exe
>> 33M libvpx-1.13.1-1.x86_64/build/test_rc_interface.exe
>> 3.3M libvpx-1.13.1-1.x86_64/build/vpxdec.exe
>> 3.5M libvpx-1.13.1-1.x86_64/build/vpxenc.exe
>> 3.4M libvpx-1.13.1-1.x86_64/inst/usr/bin/cygvpx-8.dll
>> 680K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxdec.exe
>> 700K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxenc.exe
>>
>> With codec performance tests disabled, this build also downloads 1.4GB of test
>> data files from Google under:
>>
>> https://storage.googleapis.com/downloads.webmproject.org/test_data/libvpx/
>>
>> which we presumably would prefer not to include in the src package, to
>
> Yeah, including it seems a bad idea.
>
>> run tests which take 2.75-3.5 hours out of a 3.75-4.5 hour build, with 5
>> failures in scallywag CI and 2 failures locally out of 1596 tests, shown in
>> the attached log, so I have questions into the upstream WebM libvpx project
>> about those.
>>
>> Full scallywag logs are available at:
>>
>> https://cygwin.com/cgi-bin2/jobs.cgi?id=7148&srcpkg=libvpx&user=Brian+Inglis
>
> Thanks.
>
> I've added this to your packages.
Cheers!
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut
-- Antoine de Saint-Exupéry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-27 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-26 15:56 [ITA] libvpx Brian Inglis
2023-10-27 15:19 ` Jon Turney
2023-10-27 19:01 ` Brian Inglis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).