public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>,
	Lemures Lemniscati <lemures.lemniscati@gmail.com>
Subject: Re: [ITA] giflib
Date: Sun, 29 May 2022 17:12:03 +0100	[thread overview]
Message-ID: <63bea768-4503-3a7f-813c-545036d2ce32@dronecode.org.uk> (raw)
In-Reply-To: <20220529204549.D6BB.50F79699@gmail.com>

On 29/05/2022 12:45, Lemures Lemniscati wrote:
> Hi!
> 
> 
> ITA for giflib, which has been maintained by Yaakov [1].

Thanks. I added this to your authorized packages.

Small comments on the .cygport:

> # Patch files whose names are in a default style of 'git format-patch'
> PATCH_URI+=$(\
>   find -maxdepth 1 -type f -name '[0-9][0-9][0-9][0-9]-*.patch' \
>   | sort \
> )

Hmm... there's probably a case to be made that this is something that 
cygport should be doing automatically.

It would certainly help with noticing when patches are removed from 
PATCH_URI but not from the source package repo...

> 
> BUILD_REQUIRES="\
>   cmake\
>   ninja\
> "

I don't think these need to be listed because they are implied by the 
respective inherits.

Certainly, if things are working as intended, scallywag can infer that.

  reply	other threads:[~2022-05-29 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-29 11:45 Lemures Lemniscati
2022-05-29 16:12 ` Jon Turney [this message]
2022-05-30  3:30   ` Lemures Lemniscati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63bea768-4503-3a7f-813c-545036d2ce32@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    --cc=lemures.lemniscati@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).