From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46153 invoked by alias); 6 Aug 2018 14:15:57 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 45991 invoked by uid 89); 6 Aug 2018 14:15:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=category, H*Ad:D*edu X-HELO: limerock03.mail.cornell.edu Received: from limerock03.mail.cornell.edu (HELO limerock03.mail.cornell.edu) (128.84.13.243) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Aug 2018 14:15:40 +0000 Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w76EFc8x009180 for ; Mon, 6 Aug 2018 10:15:38 -0400 Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w76EFafN009485 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 6 Aug 2018 10:15:37 -0400 Subject: Re: [PATCH setup 00/13] ListView Package Chooser To: cygwin-apps@cygwin.com References: <20180805220851.270212-1-jon.turney@dronecode.org.uk> From: Ken Brown Message-ID: <64d75f8c-ec4c-0e72-4961-4b2e1fa69911@cornell.edu> Date: Mon, 06 Aug 2018 14:15:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180805220851.270212-1-jon.turney@dronecode.org.uk> Content-Type: multipart/mixed; boundary="------------42AAAE5E2E8970C1E64C44D6" X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00021.txt.bz2 This is a multi-part message in MIME format. --------------42AAAE5E2E8970C1E64C44D6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 948 On 8/5/2018 6:08 PM, Jon Turney wrote: > Drag setup into the 1990s, by replacing the custom-drawn package chooser > with a ListView common control. > > As well as removing a lot of Win32 GDI drawing, this also enables the > following improvements to be much more straightforward: > > * Use standard UI elements to choose an action to take on a package or > category, rather than the weird UX of clicking to cycle around a list of > options of undisclosed length. This is a huge improvement over the existing UX. > * Add tooltips (initially, the ldesc as a tooltip for sdesc) This is also a big improvement. It's nice to see ldesc finally being used. I have one minor fix (patch attached) and one suggestion: It would be good, if possible, for setup to remember the column widths if the user changes them, just as it now remembers the size and position of the chooser window. Thanks for doing this. It must have been a lot of work. Ken --------------42AAAE5E2E8970C1E64C44D6 Content-Type: text/plain; charset=UTF-8; name="0001-Ensure-that-an-installed-packageversion-has-an-ldesc.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Ensure-that-an-installed-packageversion-has-an-ldesc.pa"; filename*1="tch" Content-length: 1302 RnJvbSBiZDE2NjAyYzA4ZTZlZGJhN2VmN2Y5MWIxNDlhOGU5YTBmZTQ1NTg3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGti cm93bkBjb3JuZWxsLmVkdT4KRGF0ZTogTW9uLCA2IEF1ZyAyMDE4IDEwOjA1 OjEyIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gRW5zdXJlIHRoYXQgYW4gaW5z dGFsbGVkIHBhY2thZ2V2ZXJzaW9uIGhhcyBhbiBsZGVzYyBpZgogcG9zc2li bGUKCkluIHBhY2thZ2VkYjo6cmVhZCgpLCBjb3B5IHRoZSBsZGVzYyBmcm9t IHNldHVwLmluaSB0byB0aGUKcGFja2FnZXZlcnNpb24gcmVhZCBmcm9tIGlu c3RhbGxlZC5kYi4gIE90aGVyd2lzZSwgYW4gaW5zdGFsbGVkCnBhY2thZ2Ug d2l0aCBvbmx5IG9uZSB2ZXJzaW9uIHdpbGwgbm90IGhhdmUgYW4gbGRlc2Mg dG8gdXNlIGFzIGEKdG9vbHRpcC4KLS0tCiBwYWNrYWdlX2RiLmNjIHwgMSAr CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQg YS9wYWNrYWdlX2RiLmNjIGIvcGFja2FnZV9kYi5jYwppbmRleCBiNzRhYWZk Li45YWEzYjhlIDEwMDY0NAotLS0gYS9wYWNrYWdlX2RiLmNjCisrKyBiL3Bh Y2thZ2VfZGIuY2MKQEAgLTE0OSw2ICsxNDksNyBAQCBwYWNrYWdlZGI6OnJl YWQgKCkKICAgICAgICAgICAgICAgICAgIGlmIChwdikKICAgICAgICAgICAg ICAgICAgICAgewogICAgICAgICAgICAgICAgICAgICAgIGRhdGEuc2Rlc2Mg PSBwdi5TRGVzYygpOworICAgICAgICAgICAgICAgICAgICAgIGRhdGEubGRl c2MgPSBwdi5MRGVzYygpOwogICAgICAgICAgICAgICAgICAgICAgIGRhdGEu YXJjaGl2ZSA9ICpwdi5zb3VyY2UoKTsKICAgICAgICAgICAgICAgICAgICAg ICBkYXRhLnN0YWJpbGl0eSA9IHB2LlN0YWJpbGl0eSgpOwogICAgICAgICAg ICAgICAgICAgICAgIGRhdGEuc3BrZ19pZCA9IHB2LnNvdXJjZVBhY2thZ2Uo KTsKLS0gCjIuMTcuMAoK --------------42AAAE5E2E8970C1E64C44D6--