From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cygwin-apps-return-39521-listarch-cygwin-apps=sources.redhat.com@cygwin.com>
Received: (qmail 114037 invoked by alias); 13 Oct 2018 17:19:48 -0000
Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm
Precedence: bulk
Sender: cygwin-apps-owner@cygwin.com
List-Id: <cygwin-apps.cygwin.com>
List-Subscribe: <mailto:cygwin-apps-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps@cygwin.com>
List-Help: <mailto:cygwin-apps-help@cygwin.com>, <http://sourceware.org/lists.html#faqs>
Mail-Followup-To: cygwin-apps@cygwin.com
Received: (qmail 114021 invoked by uid 89); 13 Oct 2018 17:19:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=Done
X-HELO: rgout02.bt.lon5.cpcloud.co.uk
Received: from rgout0204.bt.lon5.cpcloud.co.uk (HELO rgout02.bt.lon5.cpcloud.co.uk) (65.20.0.203) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Oct 2018 17:19:44 +0000
X-OWM-Source-IP: 31.51.205.159 (GB)
X-OWM-Env-Sender: jonturney@btinternet.com
X-VadeSecure-score: verdict=clean score=0/300, class=clean
X-SNCR-VADESECURE: CLEAN
Received: from [192.168.1.102] (31.51.205.159) by rgout02.bt.lon5.cpcloud.co.uk (9.0.019.26-1) (authenticated as jonturney@btinternet.com)        id 5B93D594032E57F2 for cygwin-apps@cygwin.com; Sat, 13 Oct 2018 18:19:42 +0100
Subject: Re: Zstandard support for setup
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
References: <874lg0d6l8.fsf@Rainer.invalid> <267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk> <87ftxdeji5.fsf@Rainer.invalid>
From: Jon Turney <jon.turney@dronecode.org.uk>
Message-ID: <652c8050-981b-27b3-0606-a834b895be5e@dronecode.org.uk>
Date: Sat, 13 Oct 2018 17:19:00 -0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <87ftxdeji5.fsf@Rainer.invalid>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-10/txt/msg00028.txt.bz2

On 10/10/2018 19:36, Achim Gratz wrote:
> Jon Turney writes:
>> This should check for ztd in configure.ac using PKG_CHECK_MODULES,
>> rather than just assuming -lzstd is going to work.
> 
> Done.
> 
>> + using namespace std;
>>
>> Please don't
> 
> Done.
> 
> https://repo.or.cz/cygwin-setup/local.git/patch/fff4b1448072efe5ebb6549cfe04bc15344a3973

Applied.

I removed the commented out logging, updated build instructions and 
build prerequisites installed in CI

Thanks.

>> compress_zstd.h:
>>
>> +/* this is the parent class for all compress IO operations.
>> + */
>>
>> Comment is incorrect
> 
> Done in the above, additionally remove the same copy&paste comment from
> two existing files:
> 
> https://repo.or.cz/cygwin-setup/local.git/patch/abf5afbfce47d1942f6d4c2f62fc8b1566920e2e

Applied.