From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-045.btinternet.com (mailomta8-re.btinternet.com [213.120.69.101]) by sourceware.org (Postfix) with ESMTPS id 58464394CC36 for ; Tue, 7 Jun 2022 18:18:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 58464394CC36 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-045.btinternet.com with ESMTP id <20220607181842.FIQC3219.re-prd-fep-045.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Tue, 7 Jun 2022 19:18:42 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A8DE8275A3788 X-Originating-IP: [86.139.167.41] X-OWM-Source-IP: 86.139.167.41 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=49/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedruddthedguddvudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucgoufhushhpvggtthffohhmrghinhculdegledmnecujfgurhepkfffgggfufhfhffvjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepleffjefhtdfgveelheeivdffudfgtedtvdetieevvedvheehleektdfgtdeffedvnecuffhomhgrihhnpehgihhthhhusgdrtghomhdprhgvphholhhoghihrdhorhhgpdhgihhthhhusgdrihhonecukfhppeekiedrudefledrudeijedrgedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdehngdpihhnvghtpeekiedrudefledrudeijedrgedupdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegrshesphhhphdrnhgvthdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomh X-RazorGate-Vade-Verdict: clean 49 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.105] (86.139.167.41) by re-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A8DE8275A3788; Tue, 7 Jun 2022 19:18:42 +0100 Message-ID: <657aca46-294f-d12f-db27-c4fb4cde2be8@dronecode.org.uk> Date: Tue, 7 Jun 2022 19:18:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [ITP] mle Content-Language: en-GB References: From: Jon Turney To: as@php.net, "cygwin-apps@cygwin.com" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1193.3 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 18:18:47 -0000 On 06/06/2022 15:33, as-GOAhiB59KME@public.gmane.org wrote: > Hello all, > > I'd like to submit a cygport for mle[0], a text editor. It's available > on various distros/OSs[1] including Debian, Fedora, FreeBSD, and > others. It's licensed under ASL 2.0. Thanks. > A first attempt at a cygport is here[2]. The editor depends on a > header-only library called uthash which I also attempted to package > here[3]. The other deps, libpcre2-devel and liblua-devel, are already > packaged. Is there a way to express a version constraint on the Lua > dep? It needs 5.4. Unfortunately, there is not currently. A few comments on the cygport files below. > [0] https://github.com/adsr/mle > [1] https://repology.org/project/mle/versions > [2] https://gist.github.com/adsr/4ecb4113f2d9c0e4ee389a800c0fd15b > NAME="mle" > VERSION=1.5.0 > HASH="bc05ec0eee4143d824010c6688fce526550ed508" > RELEASE=1 > CATEGORY="Editors" > SUMMARY="Flexible terminal-based text editor" > DESCRIPTION="mle is a small, flexible, terminal-based text editor written in C. > Notable features include: full Unicode support, syntax highlighting, scriptable > rc file, macros, search and replace (PCRE), window splitting, multiple cursors, > and integration with various shell commands." > HOMEPAGE="https://github.com/adsr/mle" > SRC_URI="https://github.com/adsr/mle/archive/${HASH}.tar.gz" Is there some reason why this can't be "https://github.com/adsr/mle/archive/refs/tags/v1.5.0.tar.gz" ? > SRC_DIR="mle-${HASH}" > BUILD_REQUIRES="libpcre2-devel uthash-devel liblua-devel" > USE_DESTDIR=1 I don't think setting USE_DESTDIR=1 is needed as this is the default. > > src_compile() { > cygmake -j1 If this is because the build system can't handle a parallel make, a comment to that effect here would be good. > } > > src_install() { > cd ${S} > cyginstall prefix=/usr > } > > mle_CONTENTS="usr/bin/mle.exe usr/share/doc usr/lib/debug usr/src/debug" This shouldn't list usr/{lib,src}/debug (as those belong in a debuginfo package), and I don't think you need this line at all, as the default will do the right thing? > [3] https://gist.github.com/adsr/e5e6beb373a427dca9e3093cc31b4cea > NAME="uthash-devel" Don't do this, because this becomes the name of the source package as well. Use NAME="uthash" and then PKG_NAMES="uthash-devel" > VERSION=2.3.0 > RELEASE=1 > CATEGORY="Libs" > SUMMARY="C macros for hash tables and more" > DESCRIPTION="uthash is a collection of header-only data-structure libraries for > hash maps (uthash), linked lists (utlist), dynamic arrays (utarray), dynamic > ring buffers (utringbuffer), intrusive stacks (utstack), and dynamic strings > (utstring)." > HOMEPAGE="https://troydhanson.github.io/uthash/" > SRC_URI="https://github.com/troydhanson/uthash/archive/refs/tags/v${VERSION}.tar.gz" > ARCH="noarch" > > src_compile() { > true > } > > src_install() { > cd ${S}/src > doinclude uthash.h utlist.h utarray.h utringbuffer.h utstack.h utstring.h > }