From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106842 invoked by alias); 2 May 2017 11:05:38 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 106800 invoked by uid 89); 2 May 2017 11:05:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:ESMTPA, HContent-Transfer-Encoding:8bit X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 11:05:35 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4BA1E208E7; Tue, 2 May 2017 07:05:36 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 02 May 2017 07:05:36 -0400 X-ME-Sender: Received: from [192.168.1.102] (host31-51-207-210.range31-51.btcentralplus.com [31.51.207.210]) by mail.messagingengine.com (Postfix) with ESMTPA id D9D3E7E15C; Tue, 2 May 2017 07:05:35 -0400 (EDT) Subject: Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY) References: <20170428121205.12240-1-jon.turney@dronecode.org.uk> <20170428121205.12240-12-jon.turney@dronecode.org.uk> <3d79b33e-e067-c1df-9b90-084fb10dd272@dronecode.org.uk> <9452ab7f-986c-2394-8c24-6208e042787e@dronecode.org.uk> <506da115-b976-fdb2-bf1b-cec6addfbbbb@dronecode.org.uk> <0b6ab083-d470-c940-5557-d33be5c523cb@gmail.com> From: Jon Turney To: cygwin-apps@cygwin.com Cc: =?UTF-8?Q?=c3=85ke_Rehnman?= Message-ID: <664411e6-ac32-ab77-1b62-72bafc8bacd8@dronecode.org.uk> Date: Tue, 02 May 2017 11:05:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <0b6ab083-d470-c940-5557-d33be5c523cb@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-05/txt/msg00009.txt.bz2 On 02/05/2017 08:28, Åke Rehnman wrote: > Hello all, > > On 2017-05-01 22:45, Jon Turney wrote: >> It seems this could be an existing bug which could have been triggered >> the proxy case. >> >> The attached incremental patch fixed this for me. > > Seem to work fine for https and ftp now, I don't have the means to test > ftps yet. Thanks very much for testing. > One thought though, why not let wininet take care of file:// URL's as > well? Or actually don't try to parse the url string at all and just pass > it down to NETIO_IE5 unfiltered? The advantage is setup would be able to I'd be happy to look at a separate patch to do this. > handle what ever protocols wininet has. Also letting wininet taking care > of file:// url's would let the user install from a local network I'm pretty sure I've done that in the past, so I think it already works. The form of file: URL required might not be strictly correct, though, (I think file:////server/pathname/ ?) I can't see how to get a file:// URL for a local directory to parse correctly, though. > resource (i.e file server). I'm been thinking of the case when someone > wants to use a local directory repo would be slightly more complicated > since relative paths does not work with file url's. One way to solve > this particular case would be to check the first character for '.' and > use that as an indicator to a local dir. Looking at the code, it seems that anything that is not recognized as a URL is just treated as a path, so this also may already be possible. -- Jon Turney Volunteer Cygwin/X X Server maintainer