From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115169 invoked by alias); 17 Oct 2017 19:32:03 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 115110 invoked by uid 89); 17 Oct 2017 19:32:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1421, HContent-Transfer-Encoding:8bit X-HELO: limerock02.mail.cornell.edu Received: from limerock02.mail.cornell.edu (HELO limerock02.mail.cornell.edu) (128.84.13.242) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 19:32:01 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v9HJVxWC022471 for ; Tue, 17 Oct 2017 15:31:59 -0400 Received: from [10.128.167.13] (dhcp-gs-9997.eduroam.cornell.edu [10.128.167.13]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v9HJVv9R019978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 17 Oct 2017 15:31:58 -0400 Subject: Re: [PATCH] Revert "Don't override a Keep selection" To: cygwin-apps@cygwin.com References: <20171016191321.9504-1-kbrown@cornell.edu> From: Ken Brown Message-ID: <66510301-7c57-ac6c-9e4c-05cf5816d3a9@cornell.edu> Date: Tue, 17 Oct 2017 19:32:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-PMX-Cornell-Gauge: Gauge=X X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00068.txt.bz2 On 10/17/2017 2:43 PM, Jon Turney wrote: > On 16/10/2017 20:13, Ken Brown wrote: >> This reverts (the rest of) commit b43b697.  Part of that commit was >> already reverted in commit ff0bb3d.  The rest is not needed either >> since we no longer send the upgrade flag to the solver after the user >> has made their selections. >> --- >>   libsolv.cc     | 14 +++----------- >>   libsolv.h      |  1 - >>   package_meta.h |  2 -- >>   3 files changed, 3 insertions(+), 14 deletions(-) > > Hmm... not sure about this. > > Say the initial upgrade solution had something like: package A 1.0 -> > 1.1, and A 1.1 has a dependency on package B 2.0, where currently B 1.0 > is installed (so B 1.0 -> 2.0) > > If the user then changes B to 'keep' (at 1.0), we should report a conflict? Good point. I wasn't thinking about dependencies with version relations. > Does keeping this cause a problem? No, but it's not actually effective at the moment, because after commit ff0bb3d, package_meta::default_version isn't being set. Maybe it should be set to reflect the initial upgrade solution. I'll play with this some more. > I guess we are generating a huge number of these tasks into the solver > because "Keep" is kind of overloaded between "Don't care (but it just > happens that I know that there's nothing to do)" and "Lock"? Yeah, this needs further thought. Ken