From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60021 invoked by alias); 1 Dec 2019 19:32:03 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 59959 invoked by uid 89); 1 Dec 2019 19:31:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=obsoletes, solver, Jon, Store X-HELO: NAM02-CY1-obe.outbound.protection.outlook.com Received: from mail-eopbgr760123.outbound.protection.outlook.com (HELO NAM02-CY1-obe.outbound.protection.outlook.com) (40.107.76.123) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Dec 2019 19:31:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=irqttEbVRdSVOlZXgPFndF3SX6VF8NeDJ7eNdOr+tP3ke0OGKYXduJLFK9cxQn8ccwzMCeWpjokOrWEixoZWEDyO4ibAA2RO21d434O1uo6ozo0/GHREy3IEJRnhwz3qHy/7kUpFzQECyJHD8F2q5blBRYp+lNnB2/pyUbrC/5o7KNNcGcSAYK+gXK6L00VTRL/yK7JpDw5KwNCWnN7LwpH+Ro33HB8bV/bTQbR9LFiZxnFxC+L4eNI7TyPuIxh7ywvQNymziAl2XBK7sD+p5hK2xLM5oPXKNDSfIMtZ99k9mYwkDrhtMhaRTiEnd2zSju2spQKZlrdPiTdeCRLt7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmYtnAdYqMJz1dTY/0cKbdyWSujL1EhIWnwQBsse/oI=; b=Sy4WU6IRuR3D69q4GCluEnbzhOHGmcytEK5jswPf4ttBK48T51hzu5f0MIWA62rwTRxbAZIDWubtERhwCx75kUuOqtdh6YjOduzcMImpHqKdNvymP1OAh3JA7iCv3TTHER9wVMxL8NpS8nPs8YfV25Way+mxPX9kdS8G3BXAV5LNxiX0nZ8Msk0aWxAEzCd+786IEhgi072b/UlsnzfVsCiuvLAcGw5Y1LTGPSbREdCSYA/0cylohOo8IcfuXq3n+rl90VcsOgKRgGK/G9cZW+I5AFSsMUs8z2/t22CstzUazlN+te9ULzcxfWy2/oYTAmD0hQHyecwt8b1UqexHZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmYtnAdYqMJz1dTY/0cKbdyWSujL1EhIWnwQBsse/oI=; b=ZzsQSOBSoY9ZxvUOXwbSy7xrjs/HPN21BIOp1SOqEkMFMyuUVcVoJmQ/UnjwfImyNXoK39f+5xv4bZQcLy1yO8+O+YcH720IrHmuic/cB8V9q8K0FbUvYihDeXtPC0txmRZwWgym3GsXlavLQLeRXFlhUsCnhADlAZCFKCnLF/U= Received: from DM6PR04MB5738.namprd04.prod.outlook.com (20.179.51.81) by DM6PR04MB5131.namprd04.prod.outlook.com (20.176.111.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.19; Sun, 1 Dec 2019 19:31:43 +0000 Received: from DM6PR04MB5738.namprd04.prod.outlook.com ([fe80::f894:edec:b80c:d524]) by DM6PR04MB5738.namprd04.prod.outlook.com ([fe80::f894:edec:b80c:d524%3]) with mapi id 15.20.2495.014; Sun, 1 Dec 2019 19:31:43 +0000 From: Ken Brown To: "cygwin-apps@cygwin.com" Subject: Re: [PATCH setup 00/11] Improve handling of specifying an obsolete package to be installed on the command line Date: Sun, 01 Dec 2019 19:32:00 -0000 Message-ID: <67c53414-03eb-fdae-250f-0a67b790e53b@cornell.edu> References: <20190801160519.32745-1-jon.turney@dronecode.org.uk> In-Reply-To: <20190801160519.32745-1-jon.turney@dronecode.org.uk> user-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=kbrown@cornell.edu; x-ms-oob-tlc-oobclassifiers: OLM:9508; received-spf: None (protection.outlook.com: cornell.edu does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: <1168E883056E0B4CAFD857288B7BFBEF@namprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JG2+LTpW5Jfh0Ab8SCGIT2RK/pX6378C7dPDPTsRDWvnjhxvMwCa5ayWAngyws1gTMIKZrAcxm39QlvLobt6LQ== X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00005.txt.bz2 On 8/1/2019 12:05 PM, Jon Turney wrote: > e.g. setup -q -g -P python3-lxml (which used to do something useful) > currently gets you an (empty) python3-lxml package, which will be replaced > by python36-lxml (which obsoletes it) on the next setup run. After this > change, python36-lxml is installed instead. >=20 > See also the dicusssion at > https://cygwin.com/ml/cygwin-apps/2017-10/msg00092.html et seq. (where I > come to the (incorrect) conclusion that since we don't need this for > interactive use, it's not needed) >=20 > Jon Turney (11): > Remove 'Bin?' column > Remove unused packagemeta::key > Make packagemeta::message private > Rename 'Default' packagemeta action to 'NoChange' for clarity > Store the requested action in packagemeta::set_action() > Use packagemeta::set_action() to update action > Use stored action in setting up solver > Allow better handling of an obsolete package specified on command line > Use stored action in packagemeta::list_actions() > Use stored action in packagemeta::action_caption() > Ensure we only set user_picked when appropriate >=20 > PickCategoryLine.cc | 2 +- > PickPackageLine.cc | 32 +--------------- > PickView.cc | 3 +- > PickView.h | 12 +++--- > choose.cc | 9 ++--- > libsolv.cc | 69 ++++++++++++++++++++------------- > libsolv.h | 1 + > package_db.cc | 4 +- > package_meta.cc | 93 ++++++++++++++++++++++----------------------- > package_meta.h | 16 ++++---- > 10 files changed, 113 insertions(+), 128 deletions(-) Jon, Since you don't seem to have gotten any feedback on this patch series, I ju= st=20 want to let you know that I've been running setup.exe with these patches fo= r a=20 couple months, and I haven't seen any regressions. (But I haven't done any= =20 systematic testing or review.) Ken