From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2120.outbound.protection.outlook.com [40.107.220.120]) by sourceware.org (Postfix) with ESMTPS id 8B7D63858D28 for ; Thu, 21 Jul 2022 13:50:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B7D63858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gxqmd/Z4d0I9CXfS+WLmMkCmRhzBD8G5oc0h7VL7TGcpQPZKkWu+Kg7zXgEfXDFWWy0+EtDFjHM9a/yMDdZtOp0VVWCBblc1OL65AArfKiQ69H2kfT4MzZLleXblwrW+ze0veA2DyRhnvJNS7HFUT8bjVoIJg5+Rsbicd79rvtRw5GE3kIdNI7cT3pCRapmdHDYAut+Xq9XkcL1dLQs9qTTB3LzyP49FJw1b1kf++XfN1w9UFZDNCd5/BqlUR2TvKvW0AYjluen9Ry/wu8f/NottBe3O7di0FFgKDV/AnaPI0wPBICj4PFFvMU41uVHOrmDeIOqPqNBAHQJMMFKaUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sS+q7lR3NrNNLqmnXzNl7yhbbJQqHmLFM2LHFLQvVuM=; b=WGlmo4V5GYBmV8dPerD2aT7jCWwCYBJkjIMWYOoS5XmpYIGjoTyH/TEJxhqLwoNEQaE3AKYlkkEZVnyX58p48Es/C513MTUNyMSKhD7XchGaHuyURJC8IWZbUkCDYisgcDaSI1wJwdC1Bcv0LZ0+h9jfWgKnXEkCCRdmDZOD1G2biiW94j6fqIFXijcCk5fGxDF9MGIK0A56f1D2Z6qq37UkuExdLwS4vRabeFDLbQtY2RouCMZdenN22ITuNG4ypC6ZwAF9hcsceWL2mcIAd/XhYe89qqUzQHu0NgkN8hr9xUfTgZKuctnOwqmR2vsb8/biJH278aypXR8hMGGbJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sS+q7lR3NrNNLqmnXzNl7yhbbJQqHmLFM2LHFLQvVuM=; b=irf50T7gsYmP3ZKqJ9dgL0s2AlIekLHoGLj3bIib0ip11YID8Q/oGNOPGj3HI2IZSVoiuNfP5PIvzbiHwsxIisV7F2XrNUHJqQpZaOmwLhvF0QxNCHpIOXWILORmfTHrIOfi0Tw4wqvGqXU/YdquLJslczOJZmVWFFnEpeTcC6s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by DM8PR04MB8005.namprd04.prod.outlook.com (2603:10b6:8:f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Thu, 21 Jul 2022 13:50:42 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::901f:a758:30f5:309d]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::901f:a758:30f5:309d%2]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 13:50:42 +0000 Message-ID: <6b3a9801-6ab9-e910-a55e-2a9d398edc5f@cornell.edu> Date: Thu, 21 Jul 2022 09:50:40 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH rebase] Make rebaseall a wrapper around the autorebase postinstall, script Content-Language: en-US To: cygwin-apps@cygwin.com References: <6d18fb7b-5af2-3c40-3358-c27260a27b48@cornell.edu> From: Ken Brown In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR07CA0027.namprd07.prod.outlook.com (2603:10b6:208:1a0::37) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8227e4a5-2594-4e39-89ab-08da6b200073 X-MS-TrafficTypeDiagnostic: DM8PR04MB8005:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iUtHaffQ2hRgqRNhKBu3djSduGxoYbbIFX2G7Zb6cg50loq3cPPF0bUXFRo6qH8QC7du7D6nC3f+I/WxmXBekYmQfzbE5ZMnXof4NKlLO/YXY6w9bnWLqvZnTTZkOGIw97Wt16fK4g5PhJEIRZF95JCG702/8zDAx+c+IdqROuHG/JSyUw8tq7148HYPgGsIbIzcYlVZqwp7bt5MixDj0szWn6KAe/uu6n/GEnHiFygmY52SQt5F9Xsxn4cQ2u/jiBJuQ7Odtsyv90GjuMEgeUDba2/WF4/HdZp6JgyHU4Pfq27zwvgEA5UUb+PrSKkv+yTGYaQMJhmUv3WdIUiSgw+sGXCoKNBlNbs3Th0e9bLMlvo09eVv8eqJ75Sf2atEkUNyAbE+Ua3wckgWw9W0Xnou6to4YxGKNhFfrtfxrDpnNK8NnjYyDl9AbSf9YNYXqZ5ZUsiCQj0RV0XcswLrY6KaAERHjURzDejHqmSiYRM7Yuis8JwNJ2SflxGupvWXKEeLkcFR/b4hIas+0TfbeowTEVjYdp1s/NzpUMTDH1tWEo8ej94befLAHfr05oCXzRumPsXiBTaJh7slD0CUTwEAVZcum2J1nSVMKO0TbUdI488FCA9hUmSyNI+mtzlUldxdcpPebkkUHdOmQ6AEiXc5+knqntpyr5Fq6fWUSwYp14DFJnwBTNAhg6HkRIkd8N3+g6/J5KGntOM+fooi70ve4apW1/AJi6a0rpAE6qlufwqUtS8LXQHQ6VmF8OEfPCeiPeaEwqBOKW46aLqnsvwdsrjGLK3vqCHfjOdPEHKruQzcSEBI10U81WeNx5a7h+DiHq9kFJpQsi5HHkS/2w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(6512007)(786003)(6486002)(478600001)(186003)(6916009)(38100700002)(31686004)(86362001)(41300700001)(2616005)(316002)(41320700001)(66476007)(8676002)(53546011)(5660300002)(4744005)(36756003)(66556008)(66946007)(6506007)(8936002)(75432002)(31696002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzI4YklTZnk1TjFhdWJtUXoyWVpKK2k1ZCtHRjBWNlRzT2txbjZ2SGNXcVUz?= =?utf-8?B?d3U4MVdjdE1Ublpkdm9jM1ZjcVZLYm54MTJzeS82ZlF5ZEJzZTVORUI3d2o5?= =?utf-8?B?UkZOUk9ZYkVMWXlubkdJNHVYZGhFMDhhdnR3aGZEd2d2NTd5cTM2TTQ0aWxq?= =?utf-8?B?WDFVeEU1MExhMVZJL21IQzNBOCtMa0FTaWFxazh2WjVVZUcwV0hTQ0hFcW5j?= =?utf-8?B?di9SOUpyNkM1Rm9xYlcxeHJ0MjV2MmxUc2xpRFE4eEowRS9SN1dMUUNUNzZ3?= =?utf-8?B?NWVFYzdYcVg5QjVZbDhSU2swN280L2FUOVV3Q2xFTXBFdHRiVjVtbDczS1lP?= =?utf-8?B?RTd4WUEreWdYZFhvL2dnZ1Z0dFF6QWp1Q0hRZ1NnUEhNc1pCUXl0NEpLSlJk?= =?utf-8?B?aXNBWXZtaEpkZEFucjc3UEhqaG4wcUJGK3NKZEJJS29vT0tNelhCbUhlc3Fl?= =?utf-8?B?d0tOa1c5MTF6RU13VDBCZW56blRQaHl2OVlFM0hXUTliTWV4NHliMkdCNnBi?= =?utf-8?B?azJ5SitZb3hyQ0dKdGFjVTk3V1JPTkQzU1NnVmtPeWFFcXFCMEYrSUFhUktL?= =?utf-8?B?SDRHdi96a3krMHJ2N0o5WGdKdkplZGdvbnh0MTBKanVOY2tjWGhBT2x5aGVr?= =?utf-8?B?bkkydk1kTTNNR0tIdlQyUG1jNzJkeVdDWXNzb09PZUt4WDRUbnJZMWRVOGpk?= =?utf-8?B?MSt0c0lvTjcxQ1Fja0RpZ0FHaWlocG5MQ0FBeXNwMTFLM0xkWkVtZXBjUU9E?= =?utf-8?B?NVhCenNOUXViWVdBOTUydzdNSWFYdTFzWWgva2dnUXNCUHpPSTc5Zk9ockFk?= =?utf-8?B?MHVCbWtiUm8xRFZCVFlkUVpNSVUzWHdvNDJvUTVzS0x1eU0rYVQzejQwcHpW?= =?utf-8?B?d2FOaTQralpJbzdNdDQ4UkVFc3BMZXZmMGVZQ1Q1aGdNRFYrb3YzNnc3RXh2?= =?utf-8?B?OHpMeDdBN3c4RExwcGs4UDZjVmhmMW5kcGtuMFMyMVUyT0QzTFFwSm5Dc1lL?= =?utf-8?B?UGhSQ1k3L3JsU0o5TTZaQUFidEI1dVE1UkFadmVXZUszWXQ3b2lwUjhMMWIv?= =?utf-8?B?aHRMRk51SVFrQjNxSXA4ZTdneW9pRTVOd2pWSkR5SFRVVVFZUjBIcHFrbWZm?= =?utf-8?B?ZENBMndRaXZQcWFWaWtCeW9kUVNHc2g2a1VnL1pWQW40dDRlWkszWnJYVEZl?= =?utf-8?B?dmtVeEU3b0RVN0k4WStGeTNHdTYwSjN6L2dHUXJjTTZpVEQ5dEFmVHdUV1V2?= =?utf-8?B?SEZZcm9FRGQ4M21aVzViUUtwSUE1VzJvL3ZNWGpUdnRuMmorWXNoMFhCWFZE?= =?utf-8?B?R2h4aTV4ZWJuQWVncUI4cVJLV3hWcGZwWHgvQzZ0a2owRG1KQjN4Y0VUZHBU?= =?utf-8?B?R0o5clpnZm84ZWhVanl1aFlkZ2pFa2liOE9PWC94V0JEb3Q2Mm11dHd2c3oy?= =?utf-8?B?amY0NTJEVUd5NU41WmR2RmE3QnNLUFg1MVNxQWJnUU40TUVWTE9kTHFIcU82?= =?utf-8?B?V1kwbkpQNjFnb3JrZTFqWG4zUGNaTkdzVHZIRG5YTkU2R3NPVG4xTkR4aWIw?= =?utf-8?B?TW5VVm52eWQzSXpmK0dCMXRjMVlaVFZBREpTYlJlbzdVbENrWDhYck1zbGZC?= =?utf-8?B?dnFJOXNwQnZwUi9hM2M1R0FoZ3VzQmFrNVNzQ2FPNVlQNW9rTE8yaXNhdlBX?= =?utf-8?B?cEtSdDgzaGVmKzl6Y3o4NmlYNWI0TnNqSEdKQktjUWR2eUVNZ251ZnAyRzV3?= =?utf-8?B?Sm0zZXJJb09qSG5CVEJieUpYSk4vQUs2Q2xRamVlWWFyWkY0Z3p5L3dQWDBl?= =?utf-8?B?SW9vQVpXdkIyUTRtSWNrWFF2Q01UNGJNcStFRzBPSkVIa1VmTFE0RmF0ek1y?= =?utf-8?B?Yk1KdzU5bjBnNXN1dWF1R3dyS2hzamNMTnM2WWNJOVFiWUg2N0MweTlMeUZy?= =?utf-8?B?ZmZzSFVqYi8yS1A0VVRaMzZqZjZsYnpuc05aNE9MdzcyLzVMNmlhWlRHQlB6?= =?utf-8?B?bVB2V25mc0NaVlVQTjZkQWRGdkdjL3FKWGRnNkpWT2QvTTB4NkpOSXF0L3Ex?= =?utf-8?B?YTBpOEs0b3FRdmJ2WDdoWCs0eEkyeTNNa1lDaHFHU2Q4L2cxeUFIb3lmNHFF?= =?utf-8?B?ekJCRnM2YjdHajdlYStnQm9EZ2lzYi9oSU5la1ZmOHJjVzhzZHh3U25DTlFa?= =?utf-8?Q?CzH6ZrTrG6k7MsMy1oW6F5+opmcvpTpFrHmOQ+U2FhUa?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 8227e4a5-2594-4e39-89ab-08da6b200073 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 13:50:42.2199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gGotKDaSt1kU4nVA1ZUGa47GCLfyq7kSQ1snyZ8xxzefHq0uvfMMXZE7Pm9hlR8tAIBaIi/rRoqNhz0ce5monQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR04MB8005 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 13:50:47 -0000 On 7/21/2022 5:09 AM, Corinna Vinschen wrote: > We're using the "?p=" URLs on the cygin-apps website, too. Maybe it's > just me, but to me it looks better if we change this to the 2nd form > where possible. What do you think? I agree that it looks better without the ?p=. I have no idea why the latter is used on the cygwin-apps website. > Just a style issue, but the two functions should stay first in the file. > Please move this code just right before the trap call. > > Other than that, LGTM. I've made all the changes you suggested and pushed it. Ken