calm: mksetupini doesn't allow non-empty source but empty install files for an obsolete package

[Ken Brown <kbrown@cornell.edu>]

I've created an obsolete package (as discussed starting at https://sourceware.org/ml/cygwin-apps/2017-05/msg00084.html).  But mksetupini doesn't like it:

mksetupini: package 'texlive-collection-htmlxml' version '20170520-1' source has no non-empty install tarfiles
mksetupini: package set has errors, not writing setup.ini

I thought the following would fix it:

--- a/calm/package.py
+++ b/calm/package.py
@@ -636,6 +636,9 @@ def validate_packages(args, packages):
             if packages[p].tars[packages[p].vermap[v]['source']].is_empty:
                 continue

+            if '_obsolete' in packages[p].vermap[v].get('category', ''):
+                continue
+
             if not packages[p].tars[packages[p].vermap[v]['source']].is_used:
                 logging.error("package '%s' version '%s' source has no non-empty install tarfiles" % (p, v))
                 error = True


But I must have something wrong, because I still get the error after this change.

Ken