From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57860 invoked by alias); 9 Oct 2017 19:32:29 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 57845 invoked by uid 89); 9 Oct 2017 19:32:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Jon, H*RU:sk:mail.me, Hx-spam-relays-external:sk:mail.me, H*r:sk:mail.me X-HELO: out1-smtp.messagingengine.com Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 19:32:27 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 086FE20E80 for ; Mon, 9 Oct 2017 15:32:26 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 09 Oct 2017 15:32:26 -0400 X-ME-Sender: Received: from [192.168.1.102] (host86-151-121-210.range86-151.btcentralplus.com [86.151.121.210]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C6877FA5E for ; Mon, 9 Oct 2017 15:32:25 -0400 (EDT) Subject: Re: [PATCH setup] Allow setup to parse more than 3 versions from the setup.ini file To: cygwin-apps@cygwin.com References: <1433349024-9776-1-git-send-email-jon.turney@dronecode.org.uk> <20150608134318.GO3416@calimero.vinschen.de> <05b7266e-6a83-b860-9079-f8fd8c310175@dronecode.org.uk> <4f1cf795-ad84-7ab6-5976-82f8c33812bc@dronecode.org.uk> <54bff98c-13c7-2213-928c-b8829c4b384f@dronecode.org.uk> <20161206184310.GE4078@calimero.vinschen.de> From: Jon Turney Message-ID: <6faced4d-c577-3c0b-4b07-2672445a58d0@dronecode.org.uk> Date: Mon, 09 Oct 2017 19:32:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20161206184310.GE4078@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00047.txt.bz2 On 06/12/2016 18:43, Corinna Vinschen wrote: > On Dec 6 17:21, Jon Turney wrote: >> From 35ecf968425762c72076059464dfb6c8b21a9331 Mon Sep 17 00:00:00 2001 >> From: Jon Turney >> Date: Wed, 31 Aug 2016 11:31:22 +0100 >> Subject: [PATCH setup] Allow setup to parse more than 3 versions from the >> setup.ini file >> >> This recognizes any "[foo]" line as introducing the information for another >> version, which doesn't have one of the trust levels [curr], [prev] or >> [test], and so isn't automatically selected when setup is told to install >> all packages at that trust level (by default, [curr]). >> >> Setup already does all the necessary sorting in version order etc. to use >> these additional versions. >> >> The value of carries no meaning, but the setup.ini specification >> mandates the use of "[ver]". >> >> * PackageTrust.h (trusts): Add TRUST_OTHER. >> * inilex.ll: tokenize any other [version] as the T_OTHER token. >> * iniparse.yy: Add T_OTHER token and set package trust >> to TRUST_OTHER when it is used. So, thinking about this change some more, I realize that there is a another way to do this, which doesn't break backwards compatibility with setup, by having multiple [prev] and [test] sections. [1] doesn't say that these section names are unique, and setup doesn't require that, I'm going to claim that it's valid :) Because of the way setup works, the last [test] section is the version which is selected when 'test' is selected, so a specific ordering of the sections would be required. The calm change to implement this is at [1]. So, for example we could have: @foo ... version: 250-0 ... [prev] version: 241-0 ... [prev] version: 243-0 ... [test] version: 251-0 ... [test] version: 252-0 ... 250-0 would be current, 252-0 would be test, and the other versions would also be available to install. [1] https://sourceware.org/cygwin-apps/setup.ini.html [2] https://github.com/jon-turney/calm/commit/c21cfdc8f8c94f615ff97000428c6e542d335dca