public inbox for
 help / color / mirror / Atom feed
From: Jon Turney <>
To: "" <>
Subject: Re: [ITP] git-filter-repo 2.34.0
Date: Sat, 12 Mar 2022 12:59:19 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 11/03/2022 21:54, Adam Dinwoodie wrote:
>>> - You're changing the shebang with both a patch file and with a line in
>>>    src_compile; you don't need to do both!  I suspect this is an artefact
>>>    of how Cygport packages the source files, but AIUI the canonical way
>>>    to do this sort of patching with Cygport is to drop the sed line from
>>>    your .cygport file and just keep the patch file that gets generated.
>> Yeah the patch file was automatically generated when I ran `cygport
>> all` and I wasn't sure what to do with it. To me it seems silly to
>> have a patch just to change the shebang line when `sed` works fine.
>> I'll try removing `sed` to see what happens.
> Cygport automatically generates patches when it detects a difference
> between the "src" and "origsrc" directories.  You're changing something
> in "src", so the patch gets generated.  The idea is that you can adjust
> things in the src directory by hand, then when you run cygport it'll
> automatically store the diffs so you never need to make the same changes
> again.

You can use DIFF_EXCLUDES to ignore that file for patch generation, if 
it's being modified in the src_compile(), like this.

(which seems to be now present in the cygport when I looked it over)

  reply	other threads:[~2022-03-12 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08  0:11 James Morris
2022-03-08  9:28 ` Adam Dinwoodie
2022-03-08 20:42   ` James Morris
2022-03-11 21:54     ` Adam Dinwoodie
2022-03-12 12:59       ` Jon Turney [this message]
2022-03-10 20:52 ` Marco Atzeri
2022-03-11 13:37   ` Jon Turney
2022-04-08 10:26     ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).