From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 8133D3870854 for ; Wed, 3 Jun 2020 16:41:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8133D3870854 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-507-RXQT0JMsOT6KotrXITAspQ-1; Wed, 03 Jun 2020 12:41:42 -0400 X-MC-Unique: RXQT0JMsOT6KotrXITAspQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74E379A405 for ; Wed, 3 Jun 2020 16:41:16 +0000 (UTC) Received: from ovpn-112-182.rdu2.redhat.com (ovpn-112-182.rdu2.redhat.com [10.10.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9BA72DE7C for ; Wed, 3 Jun 2020 16:41:15 +0000 (UTC) Message-ID: <7a01c2da88317fbbbdcf5f6f4a4b783fad32117b.camel@redhat.com> Subject: Re: Request for review: anthy 9100h+0.4 (Re: Update of packages by non-maintainer) From: Yaakov Selkowitz To: cygwin-apps@cygwin.com Date: Wed, 03 Jun 2020 12:41:14 -0400 In-Reply-To: <20200604.012050.1431284441844398224.yasu@utahime.org> References: <20200529.073435.1952274186863135803.yasu@utahime.org> <20200603.143156.1513397643549932284.yasu@utahime.org> <20200604.012050.1431284441844398224.yasu@utahime.org> Organization: Red Hat User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2020 16:41:46 -0000 On Thu, 2020-06-04 at 01:20 +0900, Yasuhiro KIMURA wrote: > From: Yasuhiro KIMURA > > So I gave up to use override.hint and decided to change version number > > to "9100h+0.4". It works fine with all of cygport, mksetupini and > > setup-x86_64. > > Anyway version number issue has sloved. So I would like to request for > review of anthy 9100h+0.4. Not ready yet; see comments inline. > * As for cygwin local patch, 9100h-no-undefined.patch is changed to > make it fit to new source tree. Others are removed. [snip] > * Add "MAKEOPTS=-j1" because parallel make causes build error. That's the whole purpose of the exeext patch, to fix parallel make. Before you remove patches, you first need to understand what the patch does, why it was needed, and see if it still is or not. If you don't know, then you should be asking rather than just dropping them. > PKG_NAMES="${NAME} lib${NAME}0 lib${NAME}-common lib${NAME}-devel emacs-${NAME}" [snip] > libanthy0_REQUIRES="libanthy-common" > libanthy0_CONTENTS="usr/bin/cyganthy*.dll" This is wrong; most of the DLLs will be -1.dll, so this needs to be libanthy1 (but see below!!). > 9100h-no-undefined.patch: This looks mostly fine, except: > --- origsrc/anthy-0.4/src-util/Makefile.am 2019-07-05 11:37:13.000000000 +0900 > +++ src/anthy-0.4/src-util/Makefile.am 2020-05-23 00:59:26.155191100 +0900 > @@ -26,5 +26,6 @@ > libanthyinput_la_SOURCES = input.c rkconv.c rkhelper.c\ > rkconv.h rkmap.h rkhelper.h > libanthyinput_la_LIBADD = ../src-main/libanthy.la > +libanthyinput_la_LDFLAGS = -no-undefined > > pkgdata_DATA = typetab dic-tool-usage.txt This should probably have -version-info flag as well upstream, otherwise you'll have conflicts with libanthy0 and libanthy1. -- Yaakov Selkowitz Senior Software Engineer - Platform Enablement Red Hat, Inc.