From: Jon Turney <jon.turney@dronecode.org.uk>
To: Christian Franke <Christian.Franke@t-online.de>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [PATCH setup] Add new option --no-write-registry
Date: Tue, 12 Jul 2022 13:50:39 +0100 [thread overview]
Message-ID: <7b954e44-601f-6448-c0a1-636be014635f@dronecode.org.uk> (raw)
In-Reply-To: <e73962fd-22b7-271b-caff-88035f33bed4@t-online.de>
On 09/07/2022 16:59, Christian Franke wrote:
> IMO useful for temporary test installs or "portable" installs to USB
> devices.
>
> The 0002-patch adds a related log message.
These patches are ok.
If you can provide a help-text for the new option, I will apply them.
> BTW: During testing I found that the "All Users" <> "Just Me" GUI
> setting has no effect at all. If setup is run elevated, "All Users" is
> always implied.
>
> This is likely because read_mounts() is called again after the "Root"
> dialog. It resets root_scope and does not re-read the registry.
Yeah. Thanks just seems like a bug, as what is selected in the UI/via
command line options should be controlling.
next prev parent reply other threads:[~2022-07-12 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 15:59 Christian Franke
2022-07-12 12:50 ` Jon Turney [this message]
2022-07-12 17:04 ` Christian Franke
2022-07-16 13:48 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b954e44-601f-6448-c0a1-636be014635f@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=Christian.Franke@t-online.de \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).