From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19741 invoked by alias); 13 Feb 2018 12:48:46 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 18870 invoked by uid 89); 13 Feb 2018 12:48:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=warm, Hx-spam-relays-external:ESMTPA X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 12:48:34 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E474C216DE for ; Tue, 13 Feb 2018 07:48:32 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Tue, 13 Feb 2018 07:48:32 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-179-112-159.range86-179.btcentralplus.com [86.179.112.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 8E4F0240DB for ; Tue, 13 Feb 2018 07:48:32 -0500 (EST) Subject: Re: [PATCH rebase 0/2] Avoid unncessary rebases To: cygwin-apps@cygwin.com References: <20180209115941.512448-1-jon.turney@dronecode.org.uk> From: Jon Turney Message-ID: <7d0d6735-afcc-99f1-0f85-fed10541cc5c@dronecode.org.uk> Date: Tue, 13 Feb 2018 12:48:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180209115941.512448-1-jon.turney@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00026.txt.bz2 On 09/02/2018 11:59, Jon Turney wrote: > Add some dignostics which report why a rebase is taking place. > > Use that information to fix some errors causing unnecessary rebases > After these fixes, 'rebase -s' is relatively quick, with a warm disk cache. But (i) we still read and extract the ImageBase out of every DLL in the database, in case it's changed, and (ii) rebaselst from autorebase seems to pass in a list of every DLL, not just the ones which have been added/removed by packaging changes, so I'm not entirely sure this is working as intended, or as well as it could...