From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH cygport] Produce obsoletes: headers in .hint files
Date: Tue, 13 Feb 2018 12:33:00 -0000 [thread overview]
Message-ID: <7d104508-783a-8ff3-8a4c-8763bd8e1b88@dronecode.org.uk> (raw)
In-Reply-To: <a25a92c9-6fd2-f7a3-b539-e09f8613133b@cygwin.com>
On 13/02/2018 06:30, Yaakov Selkowitz wrote:
> On 2018-02-06 15:13, Jon Turney wrote:
>> lib/pkg_pkg.cygpart | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/lib/pkg_pkg.cygpart b/lib/pkg_pkg.cygpart
>> index 0dba03d..aa6f0e8 100644
>> --- a/lib/pkg_pkg.cygpart
>> +++ b/lib/pkg_pkg.cygpart
>> @@ -718,6 +718,11 @@ requires: ${pkg_bin_requires} ${!pkg_requires_var}
>> sdesc: "${!pkg_summary_var:-${SUMMARY}}"
>> ldesc: "${!pkg_description_var:-${DESCRIPTION:-${!pkg_summary_var:-${SUMMARY}}}}"
>> _EOF
>> + if [ -n "${!pkg_obsoletes_var}" ]
>> + then
>> + cat >> ${distdir}/${PN}/${distsubdir}/${pkg_name[${n}]}-${PVR}.hint <<-_EOF
>> +obsoletes: ${!pkg_obsoletes_var}
>
> This is missing the closing _EOF in both hunks. (The testsuite did its
> job though, and failed pretty badly.) Pushed, with that change.
Thanks.
It seems I added the _EOF locally and forgot to check it in :(
prev parent reply other threads:[~2018-02-13 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 21:14 Jon Turney
2018-02-13 6:31 ` Yaakov Selkowitz
2018-02-13 12:33 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d104508-783a-8ff3-8a4c-8763bd8e1b88@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).